All of
 help / color / mirror / Atom feed
From: Sam Protsenko <>
To: Rob Herring <>
Cc: Krzysztof Kozlowski <>,
	Geert Uytterhoeven <>,
	Masahiro Yamada <>,
	David Virag <>,
	Jaewon Kim <>,,,
Subject: [PATCH] dt-bindings: Only show unique unit address warning for enabled nodes
Date: Fri,  3 Dec 2021 20:35:17 +0200	[thread overview]
Message-ID: <> (raw)

There are valid cases when two nodes can have the same address. For
example, in Exynos SoCs there is USI IP-core, which might be configured
to provide UART, SPI or I2C block, all of which having the same base
register address. But only one can be enabled at a time. That looks like

    usi@138200c0 {
        serial@13820000 {
            status = "okay";

        i2c@13820000 {
            status = "disabled";

When running "make dt_binding_check", it reports next warning:

    Warning (unique_unit_address):
    duplicate unit-address (also used in node

Disable "unique_unit_address" in DTC_FLAGS to suppress warnings like
that, but enable "unique_unit_address_if_enabled" warning, so that dtc
still reports a warning when two enabled nodes are having the same

Signed-off-by: Sam Protsenko <>
Reported-by: Rob Herring <>
Suggested-by: Rob Herring <>
 Documentation/devicetree/bindings/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index c9abfbe3f0aa..41c555181b6f 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -65,7 +65,9 @@ DT_DOCS = $(patsubst $(srctree)/%,%,$(shell $(find_all_cmd)))
 override DTC_FLAGS := \
 	-Wno-avoid_unnecessary_addr_size \
 	-Wno-graph_child_address \
-	-Wno-interrupt_provider
+	-Wno-interrupt_provider \
+	-Wno-unique_unit_address \
+	-Wunique_unit_address_if_enabled
 # Disable undocumented compatible checks until warning free
 override DT_CHECKER_FLAGS ?=

             reply	other threads:[~2021-12-03 18:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 18:35 Sam Protsenko [this message]
2021-12-06 20:19 ` [PATCH] dt-bindings: Only show unique unit address warning for enabled nodes Rob Herring
2021-12-07 12:16   ` Sam Protsenko
2021-12-06 20:19 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.