All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
	Matt Weber <matthew.weber@collins.com>,
	buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/iwd: enable required kernel dependencies
Date: Sat, 4 Dec 2021 21:28:03 +0100	[thread overview]
Message-ID: <20211204212803.344ccdc5@windsurf> (raw)
In-Reply-To: <CADvTj4p6pRZj=iTihdDXAZf7_sT6h0i-=krpMW+OE3YX55a7rA@mail.gmail.com>

On Wed, 1 Dec 2021 16:15:24 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> > > +define IWD_LINUX_CONFIG_FIXUPS
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_ASYMMETRIC_KEY_TYPE)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_AES)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_AES_NI_INTEL)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_AES_X86_64)  
> >
> > Not sure if it is good idea to add the x86_64 specific ones unconditionally
> > (they are marked in check_crypto() with ADD_OPTIONAL instead of ADD_MISSING)?  
> 
> Doesn't the infrastructure drop them automatically if they aren't selectable?

I think the point that Peter Seiderer was trying to make is that
CONFIG_CRYPTO_AES_NI_INTEL and CONFIG_CRYPTO_AES_X86_64 are not
mandatory for iwd, and therefore shouldn't be forced enabled here.

> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_CBC)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_CMAC)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_DES)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_DES3_EDE_X86_64)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_ECB)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_HMAC)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_MD4)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_MD5)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA1)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA1_SSSE3)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA256)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA256)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA256_SSSE3)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA512)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA512_SSSE3)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_USER_API_HASH)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_USER_API_SKCIPHER)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_KEYS)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_KEY_DH_OPERATIONS)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_PKCS7_MESSAGE_PARSER)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_PKCS8_PRIVATE_KEY_PARSER)
> > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_X509_CERTIFICATE_PARSER)
> > > +endef

Does it strictly need *all* those options ? We don't want to be too
aggressive in forcing kernel options. We should only force enable the
ones that are absolutely mandatory for iwd to work. We should not force
enable the options that *may* be used by iwd but are not needed in all
cases.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-12-04 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 13:51 [Buildroot] [PATCH 1/1] package/iwd: enable required kernel dependencies James Hilliard
2021-12-01 17:34 ` Peter Seiderer
2021-12-01 23:15   ` James Hilliard
2021-12-04 20:28     ` Thomas Petazzoni [this message]
2021-12-04 23:43       ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211204212803.344ccdc5@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=matthew.weber@collins.com \
    --cc=ps.report@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.