From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEBCDC433EF for ; Mon, 6 Dec 2021 04:18:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8D24D83068; Mon, 6 Dec 2021 05:18:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="nE8lRvNa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F0DD783023; Mon, 6 Dec 2021 05:18:11 +0100 (CET) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7FE5D83068 for ; Mon, 6 Dec 2021 05:18:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x52d.google.com with SMTP id m15so9224862pgu.11 for ; Sun, 05 Dec 2021 20:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Uyhy1fRkUmvvpKsXn159q+qh9RK2IWbSQTVFL6m43Yw=; b=nE8lRvNaQHkHACUSZNSy7p1uN4pswyd8ppIhx0KjchlA5aXu2xIUrS5gqbm9uxmogN zBXN5FPuquLJOb74MufyvKzxzfJjGcRElTDJJ1WQshDRB7UgEyaIIDJEX0Aa2Nd25yVi YD/6JWD65KxGVoH+rWvzpjmnGFL+Uzkh43XpoMp2qYdCs0oUAgUERUE9NMKNEQx5raYn fsxekQAEShZfHBQAdg6fKiCZlh6az5QX+O8NKDmjNwtvcCcnNq02Pz1+mclcwyRYbrpy 2vR1xiDniFVwLL29wXuMaw4BGDN8SvRR0HBq39lRrhXWGzNdiTDXrglknVt/UnvQxAUA Pa5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Uyhy1fRkUmvvpKsXn159q+qh9RK2IWbSQTVFL6m43Yw=; b=pZMgbR9/SeXFjNeU9LzAAp76yRirmUQioFHJ7By6Wwu3uZwr4qOiitlFvhbuLfzSwJ gh/IYkiPqhq1p396w/hB2H7tjgwFtoApoaaxPLYtwuG7tQip+P38e6fUE02BSoln3fCy K04mgHTd2z5BfzVhF4N0eJea2MsmbdLTfD3jPugJ8RskElz4kkvY8rV0+3jQkx33a+hr dq7Sh/fR/5dRfQNBfoAsn1BO52P3B3SWB+lTlvf8l21R9lUgE/7PpgDmQy7WMYyxwYph sJQLLcbxZuhgjo4iIXhtrGQnLXaSpVVEFiJYztTRFhtGpfBtGiPP4ERNOnXoAjRxGgry k3zw== X-Gm-Message-State: AOAM532F4KeU44WvtY3pol0WjjV0L5lWTsIFc5U2osw2jWpybLhLDOCk nQuXdk0NTtOsiNlxPs//LlyGYg== X-Google-Smtp-Source: ABdhPJxoyGBkjYDCqABCy/n0MBNOxJC81YNt9fjp/MDY/PlrWu9VDOF77+UrZ8Ikm+NdbgRRzTjGpw== X-Received: by 2002:a63:447:: with SMTP id 68mr8048637pge.162.1638764286822; Sun, 05 Dec 2021 20:18:06 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:290a:ce7f:bf96:e1e8]) by smtp.gmail.com with ESMTPSA id j1sm10033924pfe.158.2021.12.05.20.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Dec 2021 20:18:06 -0800 (PST) Date: Mon, 6 Dec 2021 13:18:02 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Simon Glass , Ilias Apalodimas , Tom Rini , U-Boot Mailing List , Alex Graf Subject: Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION Message-ID: <20211206041802.GB25701@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Ilias Apalodimas , Tom Rini , U-Boot Mailing List , Alex Graf References: <20211115014319.GA38596@laputa> <938593ce-c7fb-57a2-0294-3f21354d48a0@gmx.de> <20211115235110.GA5047@laputa> <7bfe1097-bcfb-36b5-18c4-30c067d53951@gmx.de> <20211116030127.GB5047@laputa> <20211203071657.GD17147@laputa> <4cbf0892-761a-7cfa-b810-d0c1234e5b76@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cbf0892-761a-7cfa-b810-d0c1234e5b76@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Dec 03, 2021 at 05:06:56PM +0100, Heinrich Schuchardt wrote: > On 12/3/21 08:16, AKASHI Takahiro wrote: > > Heinrich, > > > > On Tue, Nov 16, 2021 at 12:01:27PM +0900, AKASHI Takahiro wrote: > > > On Tue, Nov 16, 2021 at 01:02:55AM +0100, Heinrich Schuchardt wrote: > > > > On 11/16/21 00:51, AKASHI Takahiro wrote: > > > > > > > Is the patch good enough to include in the series? > > > > > > > > > > > > > > If not, you could reply to it with what needs doing. > > > > > ? I have already replied to your patch:) > > > > > Basically, it seems to be fine to me. > > > > > > > > > > > > Regards, > > > > > > > Simon > > > > > > > > > > > > > The patch is not usable as is. It assumes only GPT partioning is used. > > > > > @Heinrich > > > > > I don't get your point. Either my patch or Simon's is not specific > > > > > to GPT at all. > > > > > > > > > > So I'm going to start respinning my patch for a next round of discussion. > > > > > > > > A field name gpt_part_info obviously relates to GPT? > > > > > > No. > > > > > > IICU, the structure, disk_partition, is not particularly GPT-specific > > > as such type of data are used over various partition drivers. > > > In my patch series, I simply reuse "struct disk_part" as a structure > > > holding a partition number and partition information (= disk_partition). > > > > So do you agree that we won't have "partition-table" devices for now? > > > > -Takahiro Akashi > > We don't need the partition-table to be a udevice now. We still can > later convert the partition drivers to a uclass if we deem it helpful. OK. I'm going to prepare for next RFC. -Takahiro Akashi > Best regards > > Heinrich > > > > > > > > -Takahiro Akashi > > > > > > > Up to now this string exists only in cmd/gpt.c. > > > > > > > > Best regards > > > > > > > > Heinrich > > > > > > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > Instead all partition table drivers need to be converted to drivers for > > > > > > the new uclass. > > > > > > > > > > > > Best regards > > > > > > > > > > > > Heinrich > > > > >