From: Ameer Hamza <amhamza.mgc@gmail.com>
To: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
amhamza.mgc@gmail.com
Subject: [PATCH] net: dsa: mv88e6xxx: initialize return variable on declaration
Date: Mon, 6 Dec 2021 16:32:19 +0500 [thread overview]
Message-ID: <20211206113219.17640-1-amhamza.mgc@gmail.com> (raw)
Uninitialized err variable defined in mv88e6393x_serdes_power
function may cause undefined behaviour if it is called from
mv88e6xxx_serdes_power_down context.
Addresses-Coverity: 1494644 ("Uninitialized scalar variable")
Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
drivers/net/dsa/mv88e6xxx/serdes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index 55273013bfb5..33727439724a 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -1507,7 +1507,7 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
bool on)
{
u8 cmode = chip->ports[port].cmode;
- int err;
+ int err = 0;
if (port != 0 && port != 9 && port != 10)
return -EOPNOTSUPP;
--
2.25.1
next reply other threads:[~2021-12-06 11:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 11:32 Ameer Hamza [this message]
2021-12-06 13:21 ` [PATCH] net: dsa: mv88e6xxx: initialize return variable on declaration Andrew Lunn
2021-12-06 22:29 ` Marek Behún
2021-12-07 0:25 ` Jakub Kicinski
2021-12-07 13:06 ` Marek Behún
2021-12-08 14:04 ` [PATCH v2] net: dsa: mv88e6xxx: error handling for serdes_power functions Ameer Hamza
2021-12-08 14:09 ` Ameer Hamza
2021-12-08 15:04 ` Jakub Kicinski
2021-12-08 15:40 ` Marek Behún
2021-12-08 15:58 ` [PATCH v3] " Ameer Hamza
2021-12-08 16:18 ` Marek Behún
2021-12-09 1:28 ` Jakub Kicinski
2021-12-09 4:06 ` Ameer Hamza
2021-12-09 4:07 ` [PATCH v4] " Ameer Hamza
2021-12-09 4:15 ` Ameer Hamza
2021-12-09 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206113219.17640-1-amhamza.mgc@gmail.com \
--to=amhamza.mgc@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.