From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: david@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com,
si-wei.liu@oracle.com, joao.m.martins@oracle.com,
eblake@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,
arei.gonglei@huawei.com, marcandre.lureau@redhat.com,
Jonah Palmer <jonah.palmer@oracle.com>,
lvivier@redhat.com, thuth@redhat.com, michael.roth@amd.com,
groug@kaod.org, dgilbert@redhat.com, eric.auger@redhat.com,
stefanha@redhat.com, boris.ostrovsky@oracle.com,
kwolf@redhat.com, mathieu.poirier@linaro.org,
raphael.norwitz@nutanix.com, pbonzini@redhat.com
Subject: Re: [PATCH v10 0/8] hmp,qmp: Add commands to introspect virtio devices
Date: Mon, 6 Dec 2021 16:57:52 -0500 [thread overview]
Message-ID: <20211206165617-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <819408538.haW0C61HAu@silver>
On Mon, Dec 06, 2021 at 07:13:49PM +0100, Christian Schoenebeck wrote:
> On Montag, 6. Dezember 2021 17:09:45 CET Jonah Palmer wrote:
> > On 12/6/21 08:50, Christian Schoenebeck wrote:
> > > On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote:
> > >> This series introduces new QMP/HMP commands to dump the status of a
> > >> virtio device at different levels.
> > >>
> > >> [Jonah: Rebasing previous patchset from Nov. 10 (v9). Original patches
> > >>
> > >> are by Laurent Vivier from May 2020.
> > >>
> > >> Rebase from v9 to v10 includes reformatting virtio.json examples and
> > >> command structures for better consistency. Also removed all enums from
> > >> virtio.json and replaced their purpose with string literals.
> > >>
> > >> Removed @ndescs from VirtioQueueElement, as the number of descriptors
> > >> can be inferred from the length of the @descs chain.
> > >>
> > >> Lastly, removed the examples in hmp-commands-info.hx to fix
> > >> 'inconsistent
> > >> literal block quoting' warning from Sphinx.]
> > >
> > > I have not followed the entire discussion. AFAICS this is intended to
> > > monitor status information on virtio level only, like virtqueue fill
> > > status, etc.
> > >
> > > One thing that I am looking for is monitoring device specific information
> > > above virtio level, e.g. certain performance numbers or statistics that
> > > only make sense for the specific device. That would not fit into any of
> > > these commands, right?
> > >
> > > Best regards,
> > > Christian Schoenebeck
> >
> > Correct. These are just one-shot commands that dump information on virtio
> > devices (including vhosts), their virtqueues, and virtqueue elements as they
> > are at the time of the command.
> >
> > Jonah
>
> What I would find useful though on this virtio level: also being able to query
> the maximum and average fill state of the two ring buffers of each virtqueue.
> That would allow to identify performance bottlenecks.
>
> Best regards,
> Christian Schoenebeck
Adding this to vhost would need some interface work though.
Also, collecting these stats isn't free or trivial,
so I imagine we would need commands to enable/disable data collection.
--
MST
prev parent reply other threads:[~2021-12-06 21:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:43 [PATCH v10 0/8] hmp,qmp: Add commands to introspect virtio devices Jonah Palmer
2021-12-06 12:43 ` [PATCH v10 1/8] virtio: drop name parameter for virtio_init() Jonah Palmer
2021-12-06 13:35 ` Christian Schoenebeck
2021-12-06 12:43 ` [PATCH v10 2/8] virtio: add vhost support for virtio devices Jonah Palmer
2021-12-06 12:43 ` [PATCH v10 3/8] qmp: add QMP command x-query-virtio Jonah Palmer
2021-12-07 6:43 ` Markus Armbruster
2021-12-06 12:43 ` [PATCH v10 4/8] qmp: add QMP command x-query-virtio-status Jonah Palmer
2021-12-07 6:52 ` Markus Armbruster
2021-12-06 12:43 ` [PATCH v10 5/8] qmp: decode feature & status bits in virtio-status Jonah Palmer
2021-12-06 12:43 ` [PATCH v10 6/8] qmp: add QMP commands for virtio/vhost queue-status Jonah Palmer
2021-12-07 9:29 ` Markus Armbruster
2021-12-06 12:43 ` [PATCH v10 7/8] qmp: add QMP command x-query-virtio-queue-element Jonah Palmer
2021-12-07 9:48 ` Markus Armbruster
2021-12-06 12:43 ` [PATCH v10 8/8] hmp: add virtio commands Jonah Palmer
2021-12-06 13:50 ` [PATCH v10 0/8] hmp, qmp: Add commands to introspect virtio devices Christian Schoenebeck via
2021-12-06 16:09 ` [PATCH v10 0/8] hmp,qmp: " Jonah Palmer
2021-12-06 18:13 ` [PATCH v10 0/8] hmp, qmp: " Christian Schoenebeck via
2021-12-06 21:57 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206165617-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=groug@kaod.org \
--cc=joao.m.martins@oracle.com \
--cc=jonah.palmer@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=raphael.norwitz@nutanix.com \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.