Re: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string

From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Priyanka Jain <priyanka.jain@nxp.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Michael Walle <michael@walle.cc>, Tom Rini <trini@konsulko.com>,
	Leo Li <leoyang.li@nxp.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string
Date: Tue, 7 Dec 2021 14:06:29 +0000	[thread overview]
Message-ID: <20211207140629.qquvxbnp7vauysnc@skbuf> (raw)
In-Reply-To: <AM6PR04MB51445F0F683AF85EA18FE2EAE66E9@AM6PR04MB5144.eurprd04.prod.outlook.com>

On Tue, Dec 07, 2021 at 04:53:11AM +0000, Priyanka Jain wrote:
> >-----Original Message-----
> >From: Vladimir Oltean <vladimir.oltean@nxp.com>
> >Sent: Thursday, December 2, 2021 8:24 PM
> >To: u-boot@lists.denx.de
> >Cc: Michael Walle <michael@walle.cc>; Tom Rini <trini@konsulko.com>;
> >Priyanka Jain <priyanka.jain@nxp.com>; Leo Li <leoyang.li@nxp.com>; Simon
> >Glass <sjg@chromium.org>
> >Subject: [PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string
> >
> >Now that all in-tree boards have been converted to the compatible strings
> >from Linux, delete the support for the ad-hoc "pcf2127-rtc" one.
> >
> >Cc: Simon Glass <sjg@chromium.org>
> >Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> >---
> > drivers/rtc/pcf2127.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index
> >291ef0329a3e..2f3fafb4968f 100644
> >--- a/drivers/rtc/pcf2127.c
> >+++ b/drivers/rtc/pcf2127.c
> >@@ -120,7 +120,6 @@ static const struct rtc_ops pcf2127_rtc_ops = {  };
> >
> > static const struct udevice_id pcf2127_rtc_ids[] = {
> >-	{ .compatible = "pcf2127-rtc" },
> > 	{ .compatible = "nxp,pcf2127" },
> > 	{ .compatible = "nxp,pcf2129" },
> > 	{ .compatible = "nxp,pca2129" },
> >--
> >2.25.1
> 
> Kindly confirm no existing platform uses this?
> Is build tested pass for all platforms?

I don't know how to trigger a build test for all platforms, sorry.
But I ran a "grep" across the whole tree for "pcf2127-rtc".
In fact I noticed just now that there is one extra occurrence at the
time of this patch in fsl-ls1028a-rdb.dts (the board itself whose dts is
synced with Linux in the next to last patch). I definitely meant to
change the fsl-ls1028a-rdb.dts RTC compatible string as part of a
separate patch as well, but it appears that I missed it and I'm doing it
as part of the dts sync patch. I'll change this in the next series.

Hopefully the fact that there aren't any remaining occurrences of the
string in the tree is sufficient proof?