All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH 17/18] crypto: dh - try to match domain parameters to a known safe-prime group
Date: Tue, 07 Dec 2021 15:06:25 +0800	[thread overview]
Message-ID: <202112071438.gJPtedGv-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4273 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211201004858.19831-18-nstange@suse.de>
References: <20211201004858.19831-18-nstange@suse.de>
TO: Nicolai Stange <nstange@suse.de>
TO: Herbert Xu <herbert@gondor.apana.org.au>
TO: "David S. Miller" <davem@davemloft.net>
CC: netdev(a)vger.kernel.org
CC: "Stephan Müller" <smueller@chronox.de>
CC: Hannes Reinecke <hare@suse.de>
CC: Torsten Duwe <duwe@suse.de>
CC: Zaibo Xu <xuzaibo@huawei.com>
CC: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
CC: David Howells <dhowells@redhat.com>
CC: Jarkko Sakkinen <jarkko@kernel.org>

Hi Nicolai,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master jmorris-security/next-testing v5.16-rc4 next-20211206]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolai-Stange/crypto-dh-infrastructure-for-NVM-in-band-auth-and-FIPS-conformance/20211201-085159
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: arm-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211207/202112071438.gJPtedGv-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
crypto/dh_helper.c:493 lookup_group_id() warn: we never enter this loop

Old smatch warnings:
crypto/dh_helper.c:466 get_safe_prime_group() warn: we never enter this loop

vim +493 crypto/dh_helper.c

802c7f1c84e4b5a Salvatore Benedetto 2016-06-22  473  
2048fab14cfd860 Nicolai Stange      2021-12-01  474  static enum dh_group_id lookup_group_id(const char *g, size_t g_size,
2048fab14cfd860 Nicolai Stange      2021-12-01  475  					const char *p, size_t p_size)
2048fab14cfd860 Nicolai Stange      2021-12-01  476  {
2048fab14cfd860 Nicolai Stange      2021-12-01  477  	int i;
2048fab14cfd860 Nicolai Stange      2021-12-01  478  
2048fab14cfd860 Nicolai Stange      2021-12-01  479  	/* All safe-prime groups use a generator of g == 2. */
2048fab14cfd860 Nicolai Stange      2021-12-01  480  	while (g_size && !*g) {
2048fab14cfd860 Nicolai Stange      2021-12-01  481  		++g;
2048fab14cfd860 Nicolai Stange      2021-12-01  482  		--g_size;
2048fab14cfd860 Nicolai Stange      2021-12-01  483  	}
2048fab14cfd860 Nicolai Stange      2021-12-01  484  
2048fab14cfd860 Nicolai Stange      2021-12-01  485  	if (g_size != 1 || *g != 2)
2048fab14cfd860 Nicolai Stange      2021-12-01  486  		return dh_group_id_unknown;
2048fab14cfd860 Nicolai Stange      2021-12-01  487  
2048fab14cfd860 Nicolai Stange      2021-12-01  488  	while (p_size && !*p) {
2048fab14cfd860 Nicolai Stange      2021-12-01  489  		++p;
2048fab14cfd860 Nicolai Stange      2021-12-01  490  		--p_size;
2048fab14cfd860 Nicolai Stange      2021-12-01  491  	}
2048fab14cfd860 Nicolai Stange      2021-12-01  492  
2048fab14cfd860 Nicolai Stange      2021-12-01 @493  	for (i = 0; i < ARRAY_SIZE(safe_prime_groups); ++i) {
2048fab14cfd860 Nicolai Stange      2021-12-01  494  		if (safe_prime_groups[i].p_size != p_size)
2048fab14cfd860 Nicolai Stange      2021-12-01  495  			continue;
2048fab14cfd860 Nicolai Stange      2021-12-01  496  
2048fab14cfd860 Nicolai Stange      2021-12-01  497  		if (!memcmp(safe_prime_groups[i].p, p, p_size))
2048fab14cfd860 Nicolai Stange      2021-12-01  498  			return safe_prime_groups[i].group_id;
2048fab14cfd860 Nicolai Stange      2021-12-01  499  	}
2048fab14cfd860 Nicolai Stange      2021-12-01  500  
2048fab14cfd860 Nicolai Stange      2021-12-01  501  	return dh_group_id_unknown;
2048fab14cfd860 Nicolai Stange      2021-12-01  502  }
2048fab14cfd860 Nicolai Stange      2021-12-01  503  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

             reply	other threads:[~2021-12-07  7:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07  7:06 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-12-01  0:48 [PATCH 00/18] crypto: dh - infrastructure for NVM in-band auth and FIPS conformance Nicolai Stange
2021-12-01  0:48 ` [PATCH 17/18] crypto: dh - try to match domain parameters to a known safe-prime group Nicolai Stange
2021-12-01  7:34   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202112071438.gJPtedGv-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.