From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF98C433F5 for ; Tue, 7 Dec 2021 17:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235433AbhLGRxt (ORCPT ); Tue, 7 Dec 2021 12:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235609AbhLGRxt (ORCPT ); Tue, 7 Dec 2021 12:53:49 -0500 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C59C2C061574; Tue, 7 Dec 2021 09:50:18 -0800 (PST) Received: by mail-ot1-x32e.google.com with SMTP id n17-20020a9d64d1000000b00579cf677301so19038214otl.8; Tue, 07 Dec 2021 09:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EDFh1r5r/ZcOnjpO/CjZwpC73g63xRkCk8EVNbc6eFc=; b=O2TQNDzIEHFsQsyCoHeFlIpxXnFKkvcUNKuxVy90RKJYpLvMN/Y7ydCd42DkUUa4GO 6EraAUQnjUNMWiR3gxBlgtRgmhdrwAsJTvPoOz4uLDN+ORMaH3DO4mFsh1C7k5n+Nl6V O2NW2poIE2OUNbVjE1h4+nKPaydta3/I16LgjxKkg5NrLJ6M8lltozTVTE6KUZmrHacA puuKiqHGhNVwwTOUUQLsClO3uis5GvB598s4T6hL6cY9dTyC6GKZ2nJLr3wrKM/zd7LE pIWgsDEDH5e62LtH2DCoojfUyPOCrfrFo4WEF7nPhcchC2y+wCs+LA9q4FG7J0cepmCd cWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=EDFh1r5r/ZcOnjpO/CjZwpC73g63xRkCk8EVNbc6eFc=; b=NemlHSprS50OM94vmS3+qLgLdONeklrcmEjisssKvde9O0rcJ0W08kwImmptNoA45N gPWpCQhIxJuomy/i5ENIVyRcJBJEAGW+p9Jhd3AsBeJwPXJcbgPP3DPlcEe4frJTIu9Y 0y+AvvmKHHHxvIH4C+yoR5UodshbjqOgo3sp5ffN4/yfHNI4MZ6VKv2iisXjIFmN4kAz 5VIumj/VITkkblNEP6Rs04cXOKmtH7E5AKOwXmkbrTdbeYgDEINfttkhgml37pEZtQJO +qtOXf7ZgBT80wPYu0QllosLyzR4S8SZCin0w+Yzli5SGF6dXKZ2o+nJOJl2ndRRBvtL 7krw== X-Gm-Message-State: AOAM532q9a/vmmBBQCJf58M0wHwc7qI+mzxy6ryud9FU2Yjp47f3CgYA RoBcgGRu0V56lEjqfO0GGlA= X-Google-Smtp-Source: ABdhPJz5NEMZhyEIVOrhke+tk4W0O4ugmlRVIoZ1Bfx5B09XzUIf6n+4yzDyhsCqye3OI79MHvCtZw== X-Received: by 2002:a9d:6641:: with SMTP id q1mr36944119otm.323.1638899418123; Tue, 07 Dec 2021 09:50:18 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id bl33sm59047oib.47.2021.12.07.09.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 09:50:17 -0800 (PST) Sender: Guenter Roeck Date: Tue, 7 Dec 2021 09:50:15 -0800 From: Guenter Roeck To: Zev Weiss Cc: linux-hwmon@vger.kernel.org, Jean Delvare , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] hwmon: (pmbus) Add Delta AHE-50DC fan control module driver Message-ID: <20211207175015.GA772416@roeck-us.net> References: <20211207071521.543-1-zev@bewilderbeest.net> <20211207071521.543-2-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211207071521.543-2-zev@bewilderbeest.net> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, Dec 06, 2021 at 11:15:20PM -0800, Zev Weiss wrote: > This device is an integrated module of the Delta AHE-50DC Open19 power > shelf. For lack of proper documentation, this driver has been developed > referencing an existing (GPL) driver that was included in a code release > from LinkedIn [1]. It provides four fan speeds, four temperatures, and > one voltage reading, as well as a handful of warning and fault > indicators. > > [1] https://github.com/linkedin/o19-bmc-firmware/blob/master/meta-openbmc/meta-linkedin/meta-deltapower/recipes-kernel/fancontrol-mod/files/fancontrol.c > Hmm, that reference isn't really accurate anymore. I think it would be better to just say that the device was found to be PMBus compliant. > Signed-off-by: Zev Weiss > --- > MAINTAINERS | 6 ++ > drivers/hwmon/pmbus/Kconfig | 12 ++++ > drivers/hwmon/pmbus/Makefile | 1 + > drivers/hwmon/pmbus/delta-ahe50dc-fan.c | 84 +++++++++++++++++++++++++ > 4 files changed, 103 insertions(+) > create mode 100644 drivers/hwmon/pmbus/delta-ahe50dc-fan.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0ac052200ecb..8bb7ba52d2f5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5425,6 +5425,12 @@ W: https://linuxtv.org > T: git git://linuxtv.org/media_tree.git > F: drivers/media/platform/sti/delta > > +DELTA AHE-50DC FAN CONTROL MODULE DRIVER > +M: Zev Weiss > +L: linux-hwmon@vger.kernel.org > +S: Maintained > +F: drivers/hwmon/pmbus/delta-ahe50dc-fan.c > + > DELTA DPS920AB PSU DRIVER > M: Robert Marko > L: linux-hwmon@vger.kernel.org > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig > index ffb609cee3a4..937e1c2c11e7 100644 > --- a/drivers/hwmon/pmbus/Kconfig > +++ b/drivers/hwmon/pmbus/Kconfig > @@ -66,6 +66,18 @@ config SENSORS_BPA_RS600 > This driver can also be built as a module. If so, the module will > be called bpa-rs600. > > +config SENSORS_DELTA_AHE50DC_FAN > + tristate "Delta AHE-50DC fan control module" > + depends on I2C > + select REGMAP_I2C > + help > + If you say yes here you get hardware monitoring support for > + the integrated fan control module of the Delta AHE-50DC > + Open19 power shelf. > + > + This driver can also be built as a module. If so, the module > + will be called delta-ahe50dc-fan. > + > config SENSORS_FSP_3Y > tristate "FSP/3Y-Power power supplies" > help > diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile > index 0ed4d596a948..a56b2897288d 100644 > --- a/drivers/hwmon/pmbus/Makefile > +++ b/drivers/hwmon/pmbus/Makefile > @@ -9,6 +9,7 @@ obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o > obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o > obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o > obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o > +obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.o > obj-$(CONFIG_SENSORS_FSP_3Y) += fsp-3y.o > obj-$(CONFIG_SENSORS_IBM_CFFPS) += ibm-cffps.o > obj-$(CONFIG_SENSORS_DPS920AB) += dps920ab.o > diff --git a/drivers/hwmon/pmbus/delta-ahe50dc-fan.c b/drivers/hwmon/pmbus/delta-ahe50dc-fan.c > new file mode 100644 > index 000000000000..07b1e7c5f5f5 > --- /dev/null > +++ b/drivers/hwmon/pmbus/delta-ahe50dc-fan.c > @@ -0,0 +1,84 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Delta AHE-50DC power shelf fan control module driver > + * > + * Copyright 2021 Zev Weiss > + */ > + > +#include > +#include > +#include > +#include Alphabetic include file order please. > + > +#include "pmbus.h" > + > +#define AHE50DC_PMBUS_READ_TEMP4 0xd0 > + > +static int ahe50dc_fan_read_word_data(struct i2c_client *client, int page, int phase, int reg) > +{ > + /* temp1 in (virtual) page 1 is remapped to mfr-specific temp4 */ > + if (page == 1) { > + if (reg == PMBUS_READ_TEMPERATURE_1) > + return i2c_smbus_read_word_data(client, AHE50DC_PMBUS_READ_TEMP4); > + return -EOPNOTSUPP; > + } > + return -ENODATA; > +} > + > +static struct pmbus_driver_info ahe50dc_fan_info = { > + .pages = 2, > + .format[PSC_FAN] = direct, > + .format[PSC_TEMPERATURE] = direct, > + .format[PSC_VOLTAGE_IN] = direct, > + .m[PSC_FAN] = 1, > + .b[PSC_FAN] = 0, > + .R[PSC_FAN] = 0, > + .m[PSC_TEMPERATURE] = 1, > + .b[PSC_TEMPERATURE] = 0, > + .R[PSC_TEMPERATURE] = 1, > + .m[PSC_VOLTAGE_IN] = 1, > + .b[PSC_VOLTAGE_IN] = 0, > + .R[PSC_VOLTAGE_IN] = 3, How did you determine the exponents ? The referenced driver doesn't seem to make a difference between voltage and temperature exponents (nor fan speed, which is a bit odd). > + .func[0] = PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2 | PMBUS_HAVE_TEMP3 | > + PMBUS_HAVE_VIN | PMBUS_HAVE_FAN12 | PMBUS_HAVE_FAN34 | > + PMBUS_HAVE_STATUS_FAN12 | PMBUS_HAVE_STATUS_FAN34 | PMBUS_PAGE_VIRTUAL, > + .func[1] = PMBUS_HAVE_TEMP | PMBUS_PAGE_VIRTUAL, > + .read_word_data = ahe50dc_fan_read_word_data, > +}; > + > +static struct pmbus_platform_data ahe50dc_fan_data = { > + .flags = PMBUS_NO_CAPABILITY, > +}; Is that necessary ? It should only be used if trying to read CAPABILITY reports bad data. Thanks, Guenter > + > +static int ahe50dc_fan_probe(struct i2c_client *client) > +{ > + client->dev.platform_data = &ahe50dc_fan_data; > + return pmbus_do_probe(client, &ahe50dc_fan_info); > +} > + > +static const struct i2c_device_id ahe50dc_fan_id[] = { > + { "ahe50dc_fan" }, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, ahe50dc_fan_id); > + > +static const struct of_device_id __maybe_unused ahe50dc_fan_of_match[] = { > + { .compatible = "delta,ahe50dc-fan" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ahe50dc_fan_of_match); > + > +static struct i2c_driver ahe50dc_fan_driver = { > + .driver = { > + .name = "ahe50dc_fan", > + .of_match_table = of_match_ptr(ahe50dc_fan_of_match), > + }, > + .probe_new = ahe50dc_fan_probe, > + .id_table = ahe50dc_fan_id, > +}; > +module_i2c_driver(ahe50dc_fan_driver); > + > +MODULE_AUTHOR("Zev Weiss "); > +MODULE_DESCRIPTION("Driver for Delta AHE-50DC power shelf fan control module"); > +MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(PMBUS); > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 776F9C433F5 for ; Tue, 7 Dec 2021 17:51:19 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J7nsf05t6z3c8w for ; Wed, 8 Dec 2021 04:51:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=O2TQNDzI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::336; helo=mail-ot1-x336.google.com; envelope-from=groeck7@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=O2TQNDzI; dkim-atps=neutral Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J7nrb2vCrz302G for ; Wed, 8 Dec 2021 04:50:22 +1100 (AEDT) Received: by mail-ot1-x336.google.com with SMTP id r10-20020a056830080a00b0055c8fd2cebdso19012001ots.6 for ; Tue, 07 Dec 2021 09:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EDFh1r5r/ZcOnjpO/CjZwpC73g63xRkCk8EVNbc6eFc=; b=O2TQNDzIEHFsQsyCoHeFlIpxXnFKkvcUNKuxVy90RKJYpLvMN/Y7ydCd42DkUUa4GO 6EraAUQnjUNMWiR3gxBlgtRgmhdrwAsJTvPoOz4uLDN+ORMaH3DO4mFsh1C7k5n+Nl6V O2NW2poIE2OUNbVjE1h4+nKPaydta3/I16LgjxKkg5NrLJ6M8lltozTVTE6KUZmrHacA puuKiqHGhNVwwTOUUQLsClO3uis5GvB598s4T6hL6cY9dTyC6GKZ2nJLr3wrKM/zd7LE pIWgsDEDH5e62LtH2DCoojfUyPOCrfrFo4WEF7nPhcchC2y+wCs+LA9q4FG7J0cepmCd cWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=EDFh1r5r/ZcOnjpO/CjZwpC73g63xRkCk8EVNbc6eFc=; b=oArj1L51JmnDvv1pbCoPraxXtGskBfH95O5jz0gdnavBE3LosdrY3JUTTPezDzA/61 9zjCjUzF05ccEraaG19CcMPUQwq8iNxUyigt2l9U2a0LxsV9IH82fzNfikEFvsWcU3pG idbMvOmgomhH4PK0lbE2Kw0ANhuZiF6HVZU3W1CRAYsTg3N5UQC0AWdqKpAPzLTHU8Lu fwMDAmzfnRm1CXk2IRnmwGEKcDvz7TKpUM4auaEHJxZcxYwVZgTIicl92WZyZ2JFXEhR 54NnV76rogWoYipeD2JuM7aBjB0z/PttDVTsmTrGvERNe9qmjV5FdOylD5iGLOWTdgWD YqeQ== X-Gm-Message-State: AOAM531lBMsTIoXmbunuDkPOAHSTvvkCU7IjJ8+KfIno2LqBV2wOrBTb b/JIfdUwneoUAB1wkMnqeI8= X-Google-Smtp-Source: ABdhPJz5NEMZhyEIVOrhke+tk4W0O4ugmlRVIoZ1Bfx5B09XzUIf6n+4yzDyhsCqye3OI79MHvCtZw== X-Received: by 2002:a9d:6641:: with SMTP id q1mr36944119otm.323.1638899418123; Tue, 07 Dec 2021 09:50:18 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id bl33sm59047oib.47.2021.12.07.09.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 09:50:17 -0800 (PST) Date: Tue, 7 Dec 2021 09:50:15 -0800 From: Guenter Roeck To: Zev Weiss Subject: Re: [PATCH v3 1/2] hwmon: (pmbus) Add Delta AHE-50DC fan control module driver Message-ID: <20211207175015.GA772416@roeck-us.net> References: <20211207071521.543-1-zev@bewilderbeest.net> <20211207071521.543-2-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211207071521.543-2-zev@bewilderbeest.net> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, openbmc@lists.ozlabs.org, Jean Delvare , linux-kernel@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Mon, Dec 06, 2021 at 11:15:20PM -0800, Zev Weiss wrote: > This device is an integrated module of the Delta AHE-50DC Open19 power > shelf. For lack of proper documentation, this driver has been developed > referencing an existing (GPL) driver that was included in a code release > from LinkedIn [1]. It provides four fan speeds, four temperatures, and > one voltage reading, as well as a handful of warning and fault > indicators. > > [1] https://github.com/linkedin/o19-bmc-firmware/blob/master/meta-openbmc/meta-linkedin/meta-deltapower/recipes-kernel/fancontrol-mod/files/fancontrol.c > Hmm, that reference isn't really accurate anymore. I think it would be better to just say that the device was found to be PMBus compliant. > Signed-off-by: Zev Weiss > --- > MAINTAINERS | 6 ++ > drivers/hwmon/pmbus/Kconfig | 12 ++++ > drivers/hwmon/pmbus/Makefile | 1 + > drivers/hwmon/pmbus/delta-ahe50dc-fan.c | 84 +++++++++++++++++++++++++ > 4 files changed, 103 insertions(+) > create mode 100644 drivers/hwmon/pmbus/delta-ahe50dc-fan.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0ac052200ecb..8bb7ba52d2f5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5425,6 +5425,12 @@ W: https://linuxtv.org > T: git git://linuxtv.org/media_tree.git > F: drivers/media/platform/sti/delta > > +DELTA AHE-50DC FAN CONTROL MODULE DRIVER > +M: Zev Weiss > +L: linux-hwmon@vger.kernel.org > +S: Maintained > +F: drivers/hwmon/pmbus/delta-ahe50dc-fan.c > + > DELTA DPS920AB PSU DRIVER > M: Robert Marko > L: linux-hwmon@vger.kernel.org > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig > index ffb609cee3a4..937e1c2c11e7 100644 > --- a/drivers/hwmon/pmbus/Kconfig > +++ b/drivers/hwmon/pmbus/Kconfig > @@ -66,6 +66,18 @@ config SENSORS_BPA_RS600 > This driver can also be built as a module. If so, the module will > be called bpa-rs600. > > +config SENSORS_DELTA_AHE50DC_FAN > + tristate "Delta AHE-50DC fan control module" > + depends on I2C > + select REGMAP_I2C > + help > + If you say yes here you get hardware monitoring support for > + the integrated fan control module of the Delta AHE-50DC > + Open19 power shelf. > + > + This driver can also be built as a module. If so, the module > + will be called delta-ahe50dc-fan. > + > config SENSORS_FSP_3Y > tristate "FSP/3Y-Power power supplies" > help > diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile > index 0ed4d596a948..a56b2897288d 100644 > --- a/drivers/hwmon/pmbus/Makefile > +++ b/drivers/hwmon/pmbus/Makefile > @@ -9,6 +9,7 @@ obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o > obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o > obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o > obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o > +obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.o > obj-$(CONFIG_SENSORS_FSP_3Y) += fsp-3y.o > obj-$(CONFIG_SENSORS_IBM_CFFPS) += ibm-cffps.o > obj-$(CONFIG_SENSORS_DPS920AB) += dps920ab.o > diff --git a/drivers/hwmon/pmbus/delta-ahe50dc-fan.c b/drivers/hwmon/pmbus/delta-ahe50dc-fan.c > new file mode 100644 > index 000000000000..07b1e7c5f5f5 > --- /dev/null > +++ b/drivers/hwmon/pmbus/delta-ahe50dc-fan.c > @@ -0,0 +1,84 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Delta AHE-50DC power shelf fan control module driver > + * > + * Copyright 2021 Zev Weiss > + */ > + > +#include > +#include > +#include > +#include Alphabetic include file order please. > + > +#include "pmbus.h" > + > +#define AHE50DC_PMBUS_READ_TEMP4 0xd0 > + > +static int ahe50dc_fan_read_word_data(struct i2c_client *client, int page, int phase, int reg) > +{ > + /* temp1 in (virtual) page 1 is remapped to mfr-specific temp4 */ > + if (page == 1) { > + if (reg == PMBUS_READ_TEMPERATURE_1) > + return i2c_smbus_read_word_data(client, AHE50DC_PMBUS_READ_TEMP4); > + return -EOPNOTSUPP; > + } > + return -ENODATA; > +} > + > +static struct pmbus_driver_info ahe50dc_fan_info = { > + .pages = 2, > + .format[PSC_FAN] = direct, > + .format[PSC_TEMPERATURE] = direct, > + .format[PSC_VOLTAGE_IN] = direct, > + .m[PSC_FAN] = 1, > + .b[PSC_FAN] = 0, > + .R[PSC_FAN] = 0, > + .m[PSC_TEMPERATURE] = 1, > + .b[PSC_TEMPERATURE] = 0, > + .R[PSC_TEMPERATURE] = 1, > + .m[PSC_VOLTAGE_IN] = 1, > + .b[PSC_VOLTAGE_IN] = 0, > + .R[PSC_VOLTAGE_IN] = 3, How did you determine the exponents ? The referenced driver doesn't seem to make a difference between voltage and temperature exponents (nor fan speed, which is a bit odd). > + .func[0] = PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2 | PMBUS_HAVE_TEMP3 | > + PMBUS_HAVE_VIN | PMBUS_HAVE_FAN12 | PMBUS_HAVE_FAN34 | > + PMBUS_HAVE_STATUS_FAN12 | PMBUS_HAVE_STATUS_FAN34 | PMBUS_PAGE_VIRTUAL, > + .func[1] = PMBUS_HAVE_TEMP | PMBUS_PAGE_VIRTUAL, > + .read_word_data = ahe50dc_fan_read_word_data, > +}; > + > +static struct pmbus_platform_data ahe50dc_fan_data = { > + .flags = PMBUS_NO_CAPABILITY, > +}; Is that necessary ? It should only be used if trying to read CAPABILITY reports bad data. Thanks, Guenter > + > +static int ahe50dc_fan_probe(struct i2c_client *client) > +{ > + client->dev.platform_data = &ahe50dc_fan_data; > + return pmbus_do_probe(client, &ahe50dc_fan_info); > +} > + > +static const struct i2c_device_id ahe50dc_fan_id[] = { > + { "ahe50dc_fan" }, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, ahe50dc_fan_id); > + > +static const struct of_device_id __maybe_unused ahe50dc_fan_of_match[] = { > + { .compatible = "delta,ahe50dc-fan" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ahe50dc_fan_of_match); > + > +static struct i2c_driver ahe50dc_fan_driver = { > + .driver = { > + .name = "ahe50dc_fan", > + .of_match_table = of_match_ptr(ahe50dc_fan_of_match), > + }, > + .probe_new = ahe50dc_fan_probe, > + .id_table = ahe50dc_fan_id, > +}; > +module_i2c_driver(ahe50dc_fan_driver); > + > +MODULE_AUTHOR("Zev Weiss "); > +MODULE_DESCRIPTION("Driver for Delta AHE-50DC power shelf fan control module"); > +MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(PMBUS); > -- > 2.34.1 >