From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B20C433F5 for ; Tue, 7 Dec 2021 20:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236724AbhLGUeK (ORCPT ); Tue, 7 Dec 2021 15:34:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232323AbhLGUeI (ORCPT ); Tue, 7 Dec 2021 15:34:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D0E8C061574; Tue, 7 Dec 2021 12:30:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C19B6B81DD1; Tue, 7 Dec 2021 20:30:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B158C341C3; Tue, 7 Dec 2021 20:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638909034; bh=vcoC+Uyri7g9qycwRWUHoUG2kf9GeTBEOaheV4ro89g=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=UObvtOcdnqtp3lRabJHPBO9zvAXJ1d/8eNBRjpZ6otbLk5LnSEQzlSDTGpRZLGxxH 13iT+3dRgQ8IOisWDu4P3YUC0pWIUffuoPYDmPtWatVLhy4/J4l92Hj2Zyzbkwparv 1ZG1oK5E7RSnyns00W5SMNR7/1qrVs8Xs9GcVOtRdQyGDsf7erHvqUK/it3a/gW7i6 ePaKGpU631QulUEhArFq7OhH+gqcp4gx/lKk/r3oR3ub4oofGrqCdE+i0DKw0AS8Em QWLrJXx0lbjJP9WAOu89mvdBmBPonky0RPbtTDWYiJoXIS6HDfoEjygJ2OGXjyjbAX 5o/RtIrwiImZA== Date: Tue, 7 Dec 2021 14:30:32 -0600 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Marc Zyngier , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Alyssa Rosenzweig , Mark Kettenis , Luca Ceresoli , kernel-team@android.com Subject: Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes Message-ID: <20211207203032.GA74708@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211207101621.GA466@lpieralisi> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 07, 2021 at 10:16:32AM +0000, Lorenzo Pieralisi wrote: > On Tue, Nov 30, 2021 at 11:56:32AM +0000, Lorenzo Pieralisi wrote: > > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote: > > > Apologies for the rapid fire (I tend to be much more conservative when > > > resending series), but given that this series has a direct impact on > > > other projects (such as u-boot), I'm trying to converge as quickly as > > > possible. > > > > > > This series aims at fixing a number of issues for the recently merged > > > Apple PCIe driver, all revolving around the mishandling of #PERST: > > > > > > - we didn't properly drive #PERST, and we didn't follow the specified > > > timings > > > > > > - the DT had the wrong polarity, which has impacts on the driver > > > itself > > > > > > Hopefully, this should address all the issues reported so far. > > > > > > * From v2: > > > - Fixed DT > > > - Fixed #PERST polarity in the driver > > > - Collected Pali's ack on patch #1 > > > > > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org > > > > > > Marc Zyngier (3): > > > PCI: apple: Follow the PCIe specifications when resetting the port > > > arm64: dts: apple: t8103: Fix PCIe #PERST polarity > > > PCI: apple: Fix #PERST polarity > > > > > > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++--- > > > drivers/pci/controller/pcie-apple.c | 12 +++++++++++- > > > 2 files changed, 15 insertions(+), 4 deletions(-) > > > > Hi Bjorn, > > > > this series is v5.16-rcX material for PCI fixes, can you pick patches > > 1,3 up please ? > > Hi Bjorn, > > Arnd acked patch 2, can we send the whole series upstream for one > of the upcoming -rcX please ? It is fixing code that was merged > in the last merge window. I put all three of these on for-linus and will ask Linus to pull them before -rc5. I do have open questions about the PERST# timing, but we can update this if needed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EC5EC433F5 for ; Tue, 7 Dec 2021 20:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=JRCcpiJMLZE7si7rUVyqcOzHoi3trao/t7z7z8Kg7hc=; b=UQDGEEhi/ALHPO L4GfDl10UFwCx4x+G9cVlUogpCB6FL7EFRjB35BMkHhemgYjP7gMYai1m2A0FCoPTdNDwXZwKpwue qu/cZg4KnUm4SOO3fjZNj5UP6mcPK+D+r6rvmv7RxHjOd5zhukJyFaKQMXpzidTjPPvHpwZvivtXx O3Sj3UFUycAC8qEndwOZiE/WHaSZDwjK8vZBeglUYSdFUqakXWvHrXUQrfEguwKZs4YrmrGQNELFZ zu5eNzAUIHqgkCr53s6Z3KlK3/h7n+4et8QfD9MxrsMpBe8Bn6gTzafWbr7qaaSqHCJCR6J/Uie3T Ok1T+FLIKpTT8vU5e79g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muh6n-00A2AI-IY; Tue, 07 Dec 2021 20:30:41 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muh6j-00A296-EZ for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 20:30:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8418AB81E4B; Tue, 7 Dec 2021 20:30:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B158C341C3; Tue, 7 Dec 2021 20:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638909034; bh=vcoC+Uyri7g9qycwRWUHoUG2kf9GeTBEOaheV4ro89g=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=UObvtOcdnqtp3lRabJHPBO9zvAXJ1d/8eNBRjpZ6otbLk5LnSEQzlSDTGpRZLGxxH 13iT+3dRgQ8IOisWDu4P3YUC0pWIUffuoPYDmPtWatVLhy4/J4l92Hj2Zyzbkwparv 1ZG1oK5E7RSnyns00W5SMNR7/1qrVs8Xs9GcVOtRdQyGDsf7erHvqUK/it3a/gW7i6 ePaKGpU631QulUEhArFq7OhH+gqcp4gx/lKk/r3oR3ub4oofGrqCdE+i0DKw0AS8Em QWLrJXx0lbjJP9WAOu89mvdBmBPonky0RPbtTDWYiJoXIS6HDfoEjygJ2OGXjyjbAX 5o/RtIrwiImZA== Date: Tue, 7 Dec 2021 14:30:32 -0600 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Marc Zyngier , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Alyssa Rosenzweig , Mark Kettenis , Luca Ceresoli , kernel-team@android.com Subject: Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes Message-ID: <20211207203032.GA74708@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211207101621.GA466@lpieralisi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_123037_671178_59EBCF07 X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 07, 2021 at 10:16:32AM +0000, Lorenzo Pieralisi wrote: > On Tue, Nov 30, 2021 at 11:56:32AM +0000, Lorenzo Pieralisi wrote: > > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote: > > > Apologies for the rapid fire (I tend to be much more conservative when > > > resending series), but given that this series has a direct impact on > > > other projects (such as u-boot), I'm trying to converge as quickly as > > > possible. > > > > > > This series aims at fixing a number of issues for the recently merged > > > Apple PCIe driver, all revolving around the mishandling of #PERST: > > > > > > - we didn't properly drive #PERST, and we didn't follow the specified > > > timings > > > > > > - the DT had the wrong polarity, which has impacts on the driver > > > itself > > > > > > Hopefully, this should address all the issues reported so far. > > > > > > * From v2: > > > - Fixed DT > > > - Fixed #PERST polarity in the driver > > > - Collected Pali's ack on patch #1 > > > > > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org > > > > > > Marc Zyngier (3): > > > PCI: apple: Follow the PCIe specifications when resetting the port > > > arm64: dts: apple: t8103: Fix PCIe #PERST polarity > > > PCI: apple: Fix #PERST polarity > > > > > > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++--- > > > drivers/pci/controller/pcie-apple.c | 12 +++++++++++- > > > 2 files changed, 15 insertions(+), 4 deletions(-) > > > > Hi Bjorn, > > > > this series is v5.16-rcX material for PCI fixes, can you pick patches > > 1,3 up please ? > > Hi Bjorn, > > Arnd acked patch 2, can we send the whole series upstream for one > of the upcoming -rcX please ? It is fixing code that was merged > in the last merge window. I put all three of these on for-linus and will ask Linus to pull them before -rc5. I do have open questions about the PERST# timing, but we can update this if needed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel