From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8303C433F5 for ; Wed, 8 Dec 2021 10:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbhLHKvC (ORCPT ); Wed, 8 Dec 2021 05:51:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbhLHKvC (ORCPT ); Wed, 8 Dec 2021 05:51:02 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9FAC061746 for ; Wed, 8 Dec 2021 02:47:30 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1muuTv-0006kc-Ql; Wed, 08 Dec 2021 11:47:27 +0100 Date: Wed, 8 Dec 2021 11:47:27 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org, Eric Garver , Phil Sutter Subject: Re: [PATCH nf] netfilter: nat: force port remap to prevent shadowing well-known ports Message-ID: <20211208104727.GD30918@breakpoint.cc> References: <20211129144218.2677-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > > We could avoid the rewrite for connections that are not being forwarded, > > but get_unique_tuple() and the callers don't propagate the required hook > > information for this. > > Probably you can scratch a bit to store in the struct nf_conn object > if this is locally generated flows? Yes, that's doable.