From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3927492824320419648==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 06/18] tcp: authopt: Hook into tcp core Date: Thu, 09 Dec 2021 00:45:04 +0800 Message-ID: <202112090014.hZOqnSC4-lkp@intel.com> In-Reply-To: List-Id: --===============3927492824320419648== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Leonard, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 1fe5b01262844be03de98afdd56d1d393df04d7e] url: https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initia= l-support-for-RFC5925-auth-option/20211208-194125 base: 1fe5b01262844be03de98afdd56d1d393df04d7e config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211209= /202112090014.hZOqnSC4-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/5935c41094c73eec0e3c39119= d7bfb22de066c3b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leonard-Crestez/tcp-Initial-suppor= t-for-RFC5925-auth-option/20211208-194125 git checkout 5935c41094c73eec0e3c39119d7bfb22de066c3b # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dum SUBARCH=3Di386 SHELL=3D/bin/bash= net/core/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from net/core/sock.c:139: include/net/tcp.h: In function 'tcp_parse_sig_options': >> include/net/tcp.h:433:17: warning: parameter 'md5ptr' set but not used [= -Wunused-but-set-parameter] 433 | const u8 **md5ptr, | ~~~~~~~~~~~^~~~~~ >> include/net/tcp.h:434:17: warning: parameter 'aoptr' set but not used [-= Wunused-but-set-parameter] 434 | const u8 **aoptr) | ~~~~~~~~~~~^~~~~ vim +/md5ptr +433 include/net/tcp.h 381 = 382 = 383 enum tcp_tw_status tcp_timewait_state_process(struct inet_timewait_s= ock *tw, 384 struct sk_buff *skb, 385 const struct tcphdr *th); 386 struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb, 387 struct request_sock *req, bool fastopen, 388 bool *lost_race); 389 int tcp_child_process(struct sock *parent, struct sock *child, 390 struct sk_buff *skb); 391 void tcp_enter_loss(struct sock *sk); 392 void tcp_cwnd_reduction(struct sock *sk, int newly_acked_sacked, int= newly_lost, int flag); 393 void tcp_clear_retrans(struct tcp_sock *tp); 394 void tcp_update_metrics(struct sock *sk); 395 void tcp_init_metrics(struct sock *sk); 396 void tcp_metrics_init(void); 397 bool tcp_peer_is_proven(struct request_sock *req, struct dst_entry *= dst); 398 void __tcp_close(struct sock *sk, long timeout); 399 void tcp_close(struct sock *sk, long timeout); 400 void tcp_init_sock(struct sock *sk); 401 void tcp_init_transfer(struct sock *sk, int bpf_op, struct sk_buff *= skb); 402 __poll_t tcp_poll(struct file *file, struct socket *sock, 403 struct poll_table_struct *wait); 404 int tcp_getsockopt(struct sock *sk, int level, int optname, 405 char __user *optval, int __user *optlen); 406 bool tcp_bpf_bypass_getsockopt(int level, int optname); 407 int tcp_setsockopt(struct sock *sk, int level, int optname, sockptr_= t optval, 408 unsigned int optlen); 409 void tcp_set_keepalive(struct sock *sk, int val); 410 void tcp_syn_ack_timeout(const struct request_sock *req); 411 int tcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, int= nonblock, 412 int flags, int *addr_len); 413 int tcp_set_rcvlowat(struct sock *sk, int val); 414 int tcp_set_window_clamp(struct sock *sk, int val); 415 void tcp_update_recv_tstamps(struct sk_buff *skb, 416 struct scm_timestamping_internal *tss); 417 void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk, 418 struct scm_timestamping_internal *tss); 419 void tcp_data_ready(struct sock *sk); 420 #ifdef CONFIG_MMU 421 int tcp_mmap(struct file *file, struct socket *sock, 422 struct vm_area_struct *vma); 423 #endif 424 void tcp_parse_options(const struct net *net, const struct sk_buff *= skb, 425 struct tcp_options_received *opt_rx, 426 int estab, struct tcp_fastopen_cookie *foc); 427 #if defined(CONFIG_TCP_MD5SIG) || defined(CONFIG_TCP_AUTHOPT) 428 int tcp_parse_sig_options(const struct tcphdr *th, 429 const u8 **md5ptr, 430 const u8 **aoptr); 431 #else 432 static inline int tcp_parse_sig_options(const struct tcphdr *th, > 433 const u8 **md5ptr, > 434 const u8 **aoptr) 435 { 436 aoptr =3D NULL; 437 md5ptr =3D NULL; 438 return 0; 439 } 440 #endif 441 static inline const u8 *tcp_parse_md5sig_option(const struct tcphdr = *th) 442 { 443 const u8 *md5, *ao; 444 int ret; 445 = 446 ret =3D tcp_parse_sig_options(th, &md5, &ao); 447 = 448 return (md5 && !ao && !ret) ? md5 : NULL; 449 } 450 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3927492824320419648==--