From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBBAC433FE for ; Wed, 8 Dec 2021 21:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238913AbhLHVrb (ORCPT ); Wed, 8 Dec 2021 16:47:31 -0500 Received: from mga01.intel.com ([192.55.52.88]:48098 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234333AbhLHVra (ORCPT ); Wed, 8 Dec 2021 16:47:30 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="262041637" X-IronPort-AV: E=Sophos;i="5.88,190,1635231600"; d="scan'208";a="262041637" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 13:10:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,190,1635231600"; d="scan'208";a="462933301" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 08 Dec 2021 13:09:57 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mv4CK-00012a-Vd; Wed, 08 Dec 2021 21:09:56 +0000 Date: Thu, 9 Dec 2021 05:09:48 +0800 From: kernel test robot To: Joseph CHANG , "David S . Miller" , Jakub Kicinski , Rob Herring Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: Add DM9051 driver Message-ID: <202112090508.QK50XeZi-lkp@intel.com> References: <20211202204656.4411-3-josright123@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202204656.4411-3-josright123@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joseph, Thank you for the patch! Yet something to improve: [auto build test ERROR on ce83278f313ce65a9bbd780a3e07fa3f62d82525] url: https://github.com/0day-ci/linux/commits/Joseph-CHANG/ADD-DM9051-NET-DEVICE/20211208-193833 base: ce83278f313ce65a9bbd780a3e07fa3f62d82525 config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211209/202112090508.QK50XeZi-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9ee7a9a16698431c764b4b21a0839e87f3692078 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joseph-CHANG/ADD-DM9051-NET-DEVICE/20211208-193833 git checkout 9ee7a9a16698431c764b4b21a0839e87f3692078 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/ethernet/davicom/dm9051.c: In function 'dm9051_read_mac_to_dev': >> drivers/net/ethernet/davicom/dm9051.c:255:35: error: assignment of read-only location '*(ndev->dev_addr + (sizetype)i)' 255 | ndev->dev_addr[i] = ior(db, DM9051_PAR + i); | ^ drivers/net/ethernet/davicom/dm9051.c:260:43: error: assignment of read-only location '*(ndev->dev_addr + (sizetype)i)' 260 | ndev->dev_addr[i] = ior(db, DM9051_PAR + i); | ^ drivers/net/ethernet/davicom/dm9051.c: In function 'dm_set_mac_lock': drivers/net/ethernet/davicom/dm9051.c:341:57: warning: passing argument 3 of 'dm_write_eeprom_func' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 341 | dm_write_eeprom_func(db, i / 2, &ndev->dev_addr[i]); | ^~~~~~~~~~~~~~~~~~ drivers/net/ethernet/davicom/dm9051.c:156:73: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const unsigned char *' 156 | static void dm_write_eeprom_func(struct board_info *db, int offset, u8 *data) | ~~~~^~~~ vim +255 drivers/net/ethernet/davicom/dm9051.c 245 246 /* functions process mac address is major from EEPROM 247 */ 248 static int dm9051_read_mac_to_dev(struct device *dev, struct net_device *ndev, 249 struct board_info *db) 250 { 251 int i; 252 u8 mac_fix[ETH_ALEN] = { 0x00, 0x60, 0x6e, 0x90, 0x51, 0xee }; 253 254 for (i = 0; i < ETH_ALEN; i++) > 255 ndev->dev_addr[i] = ior(db, DM9051_PAR + i); 256 if (!is_valid_ether_addr(ndev->dev_addr)) { 257 for (i = 0; i < ETH_ALEN; i++) 258 iow(db, DM9051_PAR + i, mac_fix[i]); 259 for (i = 0; i < ETH_ALEN; i++) 260 ndev->dev_addr[i] = ior(db, DM9051_PAR + i); 261 dev_info(dev, "dm9 [reg_netdev][%s][chip MAC: %pM (%s)]\n", 262 ndev->name, ndev->dev_addr, "FIX-1"); 263 return 0; 264 } 265 return 1; 266 } 267 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5711560846882585713==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/2] net: Add DM9051 driver Date: Thu, 09 Dec 2021 05:09:48 +0800 Message-ID: <202112090508.QK50XeZi-lkp@intel.com> In-Reply-To: <20211202204656.4411-3-josright123@gmail.com> List-Id: --===============5711560846882585713== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Joseph, Thank you for the patch! Yet something to improve: [auto build test ERROR on ce83278f313ce65a9bbd780a3e07fa3f62d82525] url: https://github.com/0day-ci/linux/commits/Joseph-CHANG/ADD-DM9051-NE= T-DEVICE/20211208-193833 base: ce83278f313ce65a9bbd780a3e07fa3f62d82525 config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211209/= 202112090508.QK50XeZi-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9ee7a9a16698431c764b4b21a= 0839e87f3692078 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joseph-CHANG/ADD-DM9051-NET-DEVICE= /20211208-193833 git checkout 9ee7a9a16698431c764b4b21a0839e87f3692078 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/ethernet/davicom/dm9051.c: In function 'dm9051_read_mac_to_d= ev': >> drivers/net/ethernet/davicom/dm9051.c:255:35: error: assignment of read-= only location '*(ndev->dev_addr + (sizetype)i)' 255 | ndev->dev_addr[i] =3D ior(db, DM9051_PAR + i); | ^ drivers/net/ethernet/davicom/dm9051.c:260:43: error: assignment of read-= only location '*(ndev->dev_addr + (sizetype)i)' 260 | ndev->dev_addr[i] =3D ior(db, DM9051_PAR= + i); | ^ drivers/net/ethernet/davicom/dm9051.c: In function 'dm_set_mac_lock': drivers/net/ethernet/davicom/dm9051.c:341:57: warning: passing argument = 3 of 'dm_write_eeprom_func' discards 'const' qualifier from pointer target = type [-Wdiscarded-qualifiers] 341 | dm_write_eeprom_func(db, i / 2, &ndev->d= ev_addr[i]); | ^~~~~~~~= ~~~~~~~~~~ drivers/net/ethernet/davicom/dm9051.c:156:73: note: expected 'u8 *' {aka= 'unsigned char *'} but argument is of type 'const unsigned char *' 156 | static void dm_write_eeprom_func(struct board_info *db, int offs= et, u8 *data) | = ~~~~^~~~ vim +255 drivers/net/ethernet/davicom/dm9051.c 245 = 246 /* functions process mac address is major from EEPROM 247 */ 248 static int dm9051_read_mac_to_dev(struct device *dev, struct net_dev= ice *ndev, 249 struct board_info *db) 250 { 251 int i; 252 u8 mac_fix[ETH_ALEN] =3D { 0x00, 0x60, 0x6e, 0x90, 0x51, 0xee }; 253 = 254 for (i =3D 0; i < ETH_ALEN; i++) > 255 ndev->dev_addr[i] =3D ior(db, DM9051_PAR + i); 256 if (!is_valid_ether_addr(ndev->dev_addr)) { 257 for (i =3D 0; i < ETH_ALEN; i++) 258 iow(db, DM9051_PAR + i, mac_fix[i]); 259 for (i =3D 0; i < ETH_ALEN; i++) 260 ndev->dev_addr[i] =3D ior(db, DM9051_PAR + i); 261 dev_info(dev, "dm9 [reg_netdev][%s][chip MAC: %pM (%s)]\n", 262 ndev->name, ndev->dev_addr, "FIX-1"); 263 return 0; 264 } 265 return 1; 266 } 267 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5711560846882585713==--