From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BAA4C433FE for ; Thu, 9 Dec 2021 10:17:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.242871.420005 (Exim 4.92) (envelope-from ) id 1mvGTf-0008SQ-Mg; Thu, 09 Dec 2021 10:16:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 242871.420005; Thu, 09 Dec 2021 10:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mvGTf-0008SJ-JT; Thu, 09 Dec 2021 10:16:39 +0000 Received: by outflank-mailman (input) for mailman id 242871; Thu, 09 Dec 2021 10:16:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mvGTd-0008SD-Cf for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:16:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 168e6522-58d9-11ec-a831-37629979565c; Thu, 09 Dec 2021 11:16:36 +0100 (CET) Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-169-43TT07apOyiRV62Y01BGhA-1; Thu, 09 Dec 2021 05:16:33 -0500 Received: by mail-qt1-f198.google.com with SMTP id e2-20020ac84142000000b002b4bc4ffc49so8028555qtm.8 for ; Thu, 09 Dec 2021 02:16:33 -0800 (PST) Received: from steredhat (host-87-21-203-138.retail.telecomitalia.it. [87.21.203.138]) by smtp.gmail.com with ESMTPSA id y18sm3753945qtx.19.2021.12.09.02.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 02:16:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 168e6522-58d9-11ec-a831-37629979565c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639044994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=skSdkMP3/Z5ledz3SKJURFKwF+2QK06u2MtL2wrAHEA=; b=eJ3PPnqGbgDhaOFwlkM/pWlsQIi+recOU/k/PNnRCXZzMyx/m2uDqlH2c4YmJC153IL2IV Osh0vpH9yIMFTkPN1Bobj65JcZFSRAKVMJRZseojpDEyUS+J2QuUaMWm/j/RA2z3upqyrX rU7B6ID90F2sIjtr8dQd5ubBGymX0xw= X-MC-Unique: 43TT07apOyiRV62Y01BGhA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=skSdkMP3/Z5ledz3SKJURFKwF+2QK06u2MtL2wrAHEA=; b=AGUKy0WQ8TLqHn09CNvsKn+TpE9BztbKP+AhEzY/CJ0K/h81UMKg/0LqArTV47buWZ w5jiHzavFRSAWxcOa9/Meqdsf5vjGEavp3zm1DbMcmLlWx7lLE5zgvXBbZYGQdC3OXiA fXg2Jt9voBbfJvG9a0WCWEqyZkm5aBpRncbaBVVoDsfXiZkxZKxKNAg3keNlNYE4HO3A ECZpgqjOBbSVw5dgwArE3DXlNpY/D7NKIbk0A/Nm8dN1IfYuuENFTDmRzbEm4bMSPTRy QnXtUb9s2AWOtUWzLpvXfWexYqWN5oh6vUaF0D9ZLwYcWtpVwVhtL6JqlqUAXA29Bacb h8CQ== X-Gm-Message-State: AOAM5338MK6LKovQMI0y2OQDRJHTcrURRsHI87jto767ZNzWYFgShYpt 6vOoDYebSMNmHwdgin6vVa5s8tBPQ0jrwUfNrJEOELnIQn4/EF179NOy1B/MubMDWjIxSZvaSLi ZVBkJJ+pPzqXhhbQO0fKUCPX3aHQ= X-Received: by 2002:a05:622a:346:: with SMTP id r6mr15827160qtw.78.1639044993488; Thu, 09 Dec 2021 02:16:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRJ/jy5gwTgSypAPgE1xPC61ttuND6x5A5qbkOiCsntHwUEjX6o68lu/SOhEC/Ll9Ki4cxXQ== X-Received: by 2002:a05:622a:346:: with SMTP id r6mr15827126qtw.78.1639044993273; Thu, 09 Dec 2021 02:16:33 -0800 (PST) Date: Thu, 9 Dec 2021 11:16:26 +0100 From: Stefano Garzarella To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , "Dr. David Alan Gilbert" , Julia Suvorova , "Michael S. Tsirkin" , Paolo Bonzini , Juan Quintela , xen-devel@lists.xenproject.org, Aarushi Mehta , Stefan Weil , Stefano Stabellini , Coiby Xu , "Richard W.M. Jones" , Kevin Wolf , Anthony Perard , Hanna Reitz , qemu-block@nongnu.org, Fam Zheng , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paul Durrant , Ronnie Sahlberg , Peter Lieven Subject: Re: [PATCH v3 0/6] aio-posix: split poll check from ready handler Message-ID: <20211209101626.t5fkmsnjxwjveb5i@steredhat> References: <20211207132336.36627-1-stefanha@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Tue, Dec 07, 2021 at 01:23:30PM +0000, Stefan Hajnoczi wrote: >v3: >- Fixed FUSE export aio_set_fd_handler() call that I missed and double-checked > for any other missing call sites using Coccinelle [Rich] >v2: >- Cleaned up unused return values in nvme and virtio-blk [Stefano] >- Documented try_poll_mode() ready_list argument [Stefano] >- Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers [Stefano] > >The first patch improves AioContext's adaptive polling execution time >measurement. This can result in better performance because the algorithm makes >better decisions about when to poll versus when to fall back to file descriptor >monitoring. > >The remaining patches unify the virtio-blk and virtio-scsi dataplane and >non-dataplane virtqueue handlers. This became possible because the dataplane >handler function now has the same function signature as the non-dataplane >handler function. Stefano Garzarella prompted me to make this refactoring. Great clean up! Thanks for doing this, everything LGTM: Reviewed-by: Stefano Garzarella From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2672EC433F5 for ; Thu, 9 Dec 2021 10:18:25 +0000 (UTC) Received: from localhost ([::1]:56722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvGVM-0001Wz-Ok for qemu-devel@archiver.kernel.org; Thu, 09 Dec 2021 05:18:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvGTg-0000UH-1R for qemu-devel@nongnu.org; Thu, 09 Dec 2021 05:16:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvGTc-00035o-KQ for qemu-devel@nongnu.org; Thu, 09 Dec 2021 05:16:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639044994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=skSdkMP3/Z5ledz3SKJURFKwF+2QK06u2MtL2wrAHEA=; b=eJ3PPnqGbgDhaOFwlkM/pWlsQIi+recOU/k/PNnRCXZzMyx/m2uDqlH2c4YmJC153IL2IV Osh0vpH9yIMFTkPN1Bobj65JcZFSRAKVMJRZseojpDEyUS+J2QuUaMWm/j/RA2z3upqyrX rU7B6ID90F2sIjtr8dQd5ubBGymX0xw= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-431-XIsIRlTTPuWEEYKW-4ZvAA-1; Thu, 09 Dec 2021 05:16:33 -0500 X-MC-Unique: XIsIRlTTPuWEEYKW-4ZvAA-1 Received: by mail-qk1-f198.google.com with SMTP id br9-20020a05620a460900b0046ad784c791so6372811qkb.4 for ; Thu, 09 Dec 2021 02:16:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=skSdkMP3/Z5ledz3SKJURFKwF+2QK06u2MtL2wrAHEA=; b=cBej3BGE1RTrnIrrGe4ImMSlj8rZnIJnISbpx7R84EIqTFepN8KntZZs6gCL28bQcr vOLy4xEx93187ILW1U21KvmHDjYL7GHam2FqnoFIFWA/kN1MB32txjCEP8U+1frBi9Z4 8wSfHD85t4yY2X4s8XWhESiJ9QYKg6gXyj7owZ1Iv7MvJ48TgRQwN0nHgeTqSP3ePNS4 +XM/A0kvHUKzIJz8RrCak15I3U7uaKPmcyUpmPmcCCgbclsfjV5CGMmCE7fOUpAtVK9h kFEFMN12+3uOiFoTFzx0KxxTubGaJY8nB1GX09W/zYFwWmYoAB7CKo702C+I6RjqUsoq XMuQ== X-Gm-Message-State: AOAM530yRQtB72m0Vk0bdBKJaOW42DavKtzYt34/W9Zyr7BEiOSQaIgG t6RGAS7V0/qbTNSIzcvBE3SwppUinTkdpezejFJJx99fWDx1bvy0Vr6YYJtv/PjlB+JZ7WAuam8 RSPmaxXfmLBEjg08= X-Received: by 2002:a05:622a:346:: with SMTP id r6mr15827165qtw.78.1639044993491; Thu, 09 Dec 2021 02:16:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRJ/jy5gwTgSypAPgE1xPC61ttuND6x5A5qbkOiCsntHwUEjX6o68lu/SOhEC/Ll9Ki4cxXQ== X-Received: by 2002:a05:622a:346:: with SMTP id r6mr15827126qtw.78.1639044993273; Thu, 09 Dec 2021 02:16:33 -0800 (PST) Received: from steredhat (host-87-21-203-138.retail.telecomitalia.it. [87.21.203.138]) by smtp.gmail.com with ESMTPSA id y18sm3753945qtx.19.2021.12.09.02.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 02:16:32 -0800 (PST) Date: Thu, 9 Dec 2021 11:16:26 +0100 From: Stefano Garzarella To: Stefan Hajnoczi Subject: Re: [PATCH v3 0/6] aio-posix: split poll check from ready handler Message-ID: <20211209101626.t5fkmsnjxwjveb5i@steredhat> References: <20211207132336.36627-1-stefanha@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=sgarzare@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.618, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Stefano Stabellini , qemu-block@nongnu.org, Juan Quintela , Paul Durrant , Anthony Perard , xen-devel@lists.xenproject.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Peter Lieven , Stefan Weil , Julia Suvorova , "Dr. David Alan Gilbert" , Ronnie Sahlberg , Aarushi Mehta , Kevin Wolf , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , "Richard W.M. Jones" , Coiby Xu , Hanna Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Dec 07, 2021 at 01:23:30PM +0000, Stefan Hajnoczi wrote: >v3: >- Fixed FUSE export aio_set_fd_handler() call that I missed and double-checked > for any other missing call sites using Coccinelle [Rich] >v2: >- Cleaned up unused return values in nvme and virtio-blk [Stefano] >- Documented try_poll_mode() ready_list argument [Stefano] >- Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers [Stefano] > >The first patch improves AioContext's adaptive polling execution time >measurement. This can result in better performance because the algorithm makes >better decisions about when to poll versus when to fall back to file descriptor >monitoring. > >The remaining patches unify the virtio-blk and virtio-scsi dataplane and >non-dataplane virtqueue handlers. This became possible because the dataplane >handler function now has the same function signature as the non-dataplane >handler function. Stefano Garzarella prompted me to make this refactoring. Great clean up! Thanks for doing this, everything LGTM: Reviewed-by: Stefano Garzarella