From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01D5C433EF for ; Thu, 9 Dec 2021 11:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236416AbhLILNN (ORCPT ); Thu, 9 Dec 2021 06:13:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235371AbhLILNM (ORCPT ); Thu, 9 Dec 2021 06:13:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01667C061746 for ; Thu, 9 Dec 2021 03:09:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC875B8243C for ; Thu, 9 Dec 2021 11:09:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8E3FC004DD; Thu, 9 Dec 2021 11:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639048176; bh=VP6MRp/SOq7XOhf3FZQo/PNQmsVcRMAIn1+Uf+bBfs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uo1FZGUEHBNoxenzO8hUgEHTwU9ArYp4ZEjisLJDdO55swq8JpFB7qUNaICQdqh6a 8S2bVDYrLtrS+t3qLYI4ut6IoVJAzUeaEDo+jIo1jgsIo/58Ocj+26BtQz1yOzHF43 jGfiO0rmu7O7lJdQH6q6zaQpjg2PT2kvf70C1GqzUzbovI8YDszICqGGacfH1ONfra fZhJm9/ZkEWiOAUM+WK3lqKPFFqh0iKiDJF11LVf/4tDsZ8JcLzXT6xX4Lk/WNrC+5 d+fSAbJkZdjNcPdu4R7V+ltg1COBunKbwn7W+vFtTrhLsHuU92cLfe+sIlQEwvcdxS ZvW/z6e/nPq7g== Date: Thu, 9 Dec 2021 11:09:31 +0000 From: Will Deacon To: Quentin Perret Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 04/15] KVM: arm64: Fixup hyp stage-1 refcount Message-ID: <20211209110930.GA1912@willie-the-truck> References: <20211201170411.1561936-1-qperret@google.com> <20211201170411.1561936-5-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211201170411.1561936-5-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 01, 2021 at 05:03:58PM +0000, Quentin Perret wrote: > In nVHE-protected mode, the hyp stage-1 page-table refcount is broken > due to the lack of refcount support in the early allocator. Fix-up the > refcount in the finalize walker, once the 'hyp_vmemmap' is up and running. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/nvhe/setup.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF55C433FE for ; Thu, 9 Dec 2021 11:09:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 36A144B0DB; Thu, 9 Dec 2021 06:09:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cAP7-8rkgREZ; Thu, 9 Dec 2021 06:09:41 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1C4874B0DD; Thu, 9 Dec 2021 06:09:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8BE5D4B0D0 for ; Thu, 9 Dec 2021 06:09:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UK3YRDVYtrMj for ; Thu, 9 Dec 2021 06:09:39 -0500 (EST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0F6304B0C0 for ; Thu, 9 Dec 2021 06:09:39 -0500 (EST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B05A1B8240D; Thu, 9 Dec 2021 11:09:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8E3FC004DD; Thu, 9 Dec 2021 11:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639048176; bh=VP6MRp/SOq7XOhf3FZQo/PNQmsVcRMAIn1+Uf+bBfs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uo1FZGUEHBNoxenzO8hUgEHTwU9ArYp4ZEjisLJDdO55swq8JpFB7qUNaICQdqh6a 8S2bVDYrLtrS+t3qLYI4ut6IoVJAzUeaEDo+jIo1jgsIo/58Ocj+26BtQz1yOzHF43 jGfiO0rmu7O7lJdQH6q6zaQpjg2PT2kvf70C1GqzUzbovI8YDszICqGGacfH1ONfra fZhJm9/ZkEWiOAUM+WK3lqKPFFqh0iKiDJF11LVf/4tDsZ8JcLzXT6xX4Lk/WNrC+5 d+fSAbJkZdjNcPdu4R7V+ltg1COBunKbwn7W+vFtTrhLsHuU92cLfe+sIlQEwvcdxS ZvW/z6e/nPq7g== Date: Thu, 9 Dec 2021 11:09:31 +0000 From: Will Deacon To: Quentin Perret Subject: Re: [PATCH v3 04/15] KVM: arm64: Fixup hyp stage-1 refcount Message-ID: <20211209110930.GA1912@willie-the-truck> References: <20211201170411.1561936-1-qperret@google.com> <20211201170411.1561936-5-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211201170411.1561936-5-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kernel-team@android.com, Marc Zyngier , linux-kernel@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Dec 01, 2021 at 05:03:58PM +0000, Quentin Perret wrote: > In nVHE-protected mode, the hyp stage-1 page-table refcount is broken > due to the lack of refcount support in the early allocator. Fix-up the > refcount in the finalize walker, once the 'hyp_vmemmap' is up and running. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/nvhe/setup.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA65CC433F5 for ; Thu, 9 Dec 2021 11:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kLjer3ZCK76KryKAwiieMP46U90sBMy0QwyomI7c5dc=; b=RJgeVrZmsAd4ge 20IFQB9HPIU7OYCptoDIPQD73icrhL/ND97mlnMqVjo4zqHaLj+F+aoTtcf7HWGqdldx59Rs29aXR XS8S8Q8igcNo4yixuDlbRmjgLqKgIcc9RQnJs1dpzORGl5CbV4sVxtAFH/rHDQFNj/LL803LKO/cV e/qt7lN3ZLjmnqWrYvbqN1H60rCj+vApmsyyAIIrrxrRfFEv/QehMTYlxaQf1LNriWtUso/MDEke3 luH0tDJHexzOrYNKAY2dGY2XG7HMoNWtkN5Evfrbt72Pdi5upa1HRQLECfzL50HEmZNJW12+0YStA o9E/venjmHyLbMhMts7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvHJ1-00FjFp-9X; Thu, 09 Dec 2021 11:09:43 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvHIx-00FjFF-0o for linux-arm-kernel@lists.infradead.org; Thu, 09 Dec 2021 11:09:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B05A1B8240D; Thu, 9 Dec 2021 11:09:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8E3FC004DD; Thu, 9 Dec 2021 11:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639048176; bh=VP6MRp/SOq7XOhf3FZQo/PNQmsVcRMAIn1+Uf+bBfs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uo1FZGUEHBNoxenzO8hUgEHTwU9ArYp4ZEjisLJDdO55swq8JpFB7qUNaICQdqh6a 8S2bVDYrLtrS+t3qLYI4ut6IoVJAzUeaEDo+jIo1jgsIo/58Ocj+26BtQz1yOzHF43 jGfiO0rmu7O7lJdQH6q6zaQpjg2PT2kvf70C1GqzUzbovI8YDszICqGGacfH1ONfra fZhJm9/ZkEWiOAUM+WK3lqKPFFqh0iKiDJF11LVf/4tDsZ8JcLzXT6xX4Lk/WNrC+5 d+fSAbJkZdjNcPdu4R7V+ltg1COBunKbwn7W+vFtTrhLsHuU92cLfe+sIlQEwvcdxS ZvW/z6e/nPq7g== Date: Thu, 9 Dec 2021 11:09:31 +0000 From: Will Deacon To: Quentin Perret Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 04/15] KVM: arm64: Fixup hyp stage-1 refcount Message-ID: <20211209110930.GA1912@willie-the-truck> References: <20211201170411.1561936-1-qperret@google.com> <20211201170411.1561936-5-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211201170411.1561936-5-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_030939_243265_00C47901 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 05:03:58PM +0000, Quentin Perret wrote: > In nVHE-protected mode, the hyp stage-1 page-table refcount is broken > due to the lack of refcount support in the early allocator. Fix-up the > refcount in the finalize walker, once the 'hyp_vmemmap' is up and running. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/nvhe/setup.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel