From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D418C433EF for ; Mon, 13 Dec 2021 09:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232562AbhLMJko (ORCPT ); Mon, 13 Dec 2021 04:40:44 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:52506 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234035AbhLMJjG (ORCPT ); Mon, 13 Dec 2021 04:39:06 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12780B80E29; Mon, 13 Dec 2021 09:39:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BF41C00446; Mon, 13 Dec 2021 09:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1639388343; bh=btabX2GD2Ag5VXAHMHJT7PSXZ4a7Zk5sLssBWWq2R84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fYfL5IIK5xAMtkY1BDEywpvOQvq4XKZ1n45N3YIGSbinUxLt0wCuhwoDie7XrhUXQ 6HGAXQvixq/uAqA8Up61jgxJgFCy1lOBms0P3mxA94b70Ni0FqRKh3/VRhQA6KfwwE BuB3b+8egfFIanpTnPejVvZ1pZjbUSlHpnuepvvY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jesse Brandeburg , Gurucharan G , Tony Nguyen Subject: [PATCH 4.19 17/74] ice: ignore dropped packets during init Date: Mon, 13 Dec 2021 10:29:48 +0100 Message-Id: <20211213092931.371682951@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211213092930.763200615@linuxfoundation.org> References: <20211213092930.763200615@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jesse Brandeburg commit 28dc1b86f8ea9fd6f4c9e0b363db73ecabf84e22 upstream. If the hardware is constantly receiving unicast or broadcast packets during driver load, the device previously counted many GLV_RDPC (VSI dropped packets) events during init. This causes confusing dropped packet statistics during driver load. The dropped packets counter incrementing does stop once the driver finishes loading. Avoid this problem by baselining our statistics at the end of driver open instead of the end of probe. Fixes: cdedef59deb0 ("ice: Configure VSIs for Tx/Rx") Signed-off-by: Jesse Brandeburg Tested-by: Gurucharan G Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/ice/ice_main.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -4404,6 +4404,9 @@ static int ice_up_complete(struct ice_vs netif_carrier_on(vsi->netdev); } + /* clear this now, and the first stats read will be used as baseline */ + vsi->stat_offsets_loaded = false; + ice_service_task_schedule(pf); return err;