From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5423C433FE for ; Mon, 13 Dec 2021 11:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233205AbhLMLG2 (ORCPT ); Mon, 13 Dec 2021 06:06:28 -0500 Received: from foss.arm.com ([217.140.110.172]:51752 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231629AbhLMLG0 (ORCPT ); Mon, 13 Dec 2021 06:06:26 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEC826D; Mon, 13 Dec 2021 03:06:25 -0800 (PST) Received: from bogus (unknown [10.57.33.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 656AE3F793; Mon, 13 Dec 2021 03:06:24 -0800 (PST) Date: Mon, 13 Dec 2021 11:06:21 +0000 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v7 02/16] firmware: arm_scmi: Set polling timeout to max_rx_timeout_ms Message-ID: <20211213110621.ipflrpex7ncympo3@bogus> References: <20211129191156.29322-1-cristian.marussi@arm.com> <20211129191156.29322-3-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211129191156.29322-3-cristian.marussi@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 29, 2021 at 07:11:42PM +0000, Cristian Marussi wrote: > Use transport specific transmission timeout (max_rx_timeout_ms) also for > polling transactions. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 3cf161f3bcc7..568562121f64 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -724,8 +724,6 @@ static void xfer_put(const struct scmi_protocol_handle *ph, > __scmi_xfer_put(&info->tx_minfo, xfer); > } > > -#define SCMI_MAX_POLL_TO_NS (100 * NSEC_PER_USEC) > - While there are no users of SCMI polling now in sched context, it was added and the choice of 100uS was that it was called in sched context. I will update this and merge patches 1-5 as they are ready to go. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1051BC433F5 for ; Mon, 13 Dec 2021 11:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+9757pLWmLkkHkyXjs/lxms3xsz8ZI3aK5HcgaJNm4A=; b=K4z/kDRQQUSeZS QNV2tOof9DoWXT9ukcR1mVrvG9/IRLuVvobYFq4sKgv2gBmDZs2zIUMSFyray5zFauEe6z3ShrMLt 152JaD/v7hQJ02BbGhOv8DoTrHeLOaLqnm3mM0uuKUL2G6+cp108MwNWBK7fMazZH47FSSn6Cu+Je w6xZiz+r8idJ93Lsk4M8sCmgFr8FVDwhGL+8kxo4ueQKwDQwn89FN2Y8x3ta77+bwynC4PCIXXYYZ dVrXk10nivhCwFtEWGIgcExhuywFKwAAEmh6PeoxchElt6QqnJEMy5T05LVKzQiBxnbSCV1hOTLFw t0DFDrp5hCN1JBc6cBPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwjA8-009Ar0-F2; Mon, 13 Dec 2021 11:06:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwjA5-009Apt-DM for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 11:06:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEC826D; Mon, 13 Dec 2021 03:06:25 -0800 (PST) Received: from bogus (unknown [10.57.33.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 656AE3F793; Mon, 13 Dec 2021 03:06:24 -0800 (PST) Date: Mon, 13 Dec 2021 11:06:21 +0000 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v7 02/16] firmware: arm_scmi: Set polling timeout to max_rx_timeout_ms Message-ID: <20211213110621.ipflrpex7ncympo3@bogus> References: <20211129191156.29322-1-cristian.marussi@arm.com> <20211129191156.29322-3-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129191156.29322-3-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_030629_536062_E935CC3E X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 29, 2021 at 07:11:42PM +0000, Cristian Marussi wrote: > Use transport specific transmission timeout (max_rx_timeout_ms) also for > polling transactions. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 3cf161f3bcc7..568562121f64 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -724,8 +724,6 @@ static void xfer_put(const struct scmi_protocol_handle *ph, > __scmi_xfer_put(&info->tx_minfo, xfer); > } > > -#define SCMI_MAX_POLL_TO_NS (100 * NSEC_PER_USEC) > - While there are no users of SCMI polling now in sched context, it was added and the choice of 100uS was that it was called in sched context. I will update this and merge patches 1-5 as they are ready to go. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel