Re: [PATCH v6 net-next 04/12] flow_offload: return EOPNOTSUPP for the unsupported mpls action type

From: Simon Horman <simon.horman@corigine.com>
To: Roi Dayan <roid@nvidia.com>
Cc: netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>, Oz Shlomo <ozsh@nvidia.com>,
	Vlad Buslov <vladbu@nvidia.com>,
	Baowen Zheng <baowen.zheng@corigine.com>,
	Louis Peens <louis.peens@corigine.com>,
	oss-drivers@corigine.com
Subject: Re: [PATCH v6 net-next 04/12] flow_offload: return EOPNOTSUPP for the unsupported mpls action type
Date: Mon, 13 Dec 2021 15:49:56 +0100	[thread overview]
Message-ID: <20211213144955.GA24044@corigine.com> (raw)
In-Reply-To: <6e56aa1e-25a2-9bb7-aee3-6a2954216b73@nvidia.com>

On Sun, Dec 12, 2021 at 02:41:53PM +0200, Roi Dayan wrote:
> 
> 
> On 2021-12-09 11:27 AM, Simon Horman wrote:
> > From: Baowen Zheng <baowen.zheng@corigine.com>
> > 
> > We need to return EOPNOTSUPP for the unsupported mpls action type when
> > setup the flow action.
> > 
> > In the original implement, we will return 0 for the unsupported mpls
> > action type, actually we do not setup it and the following actions
> > to the flow action entry.
> > 
> > Signed-off-by: Baowen Zheng <baowen.zheng@corigine.com>
> > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > ---
> >   net/sched/cls_api.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> > index d9d6ff0bf361..7a680cae0bae 100644
> > --- a/net/sched/cls_api.c
> > +++ b/net/sched/cls_api.c
> > @@ -3687,6 +3687,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,
> >   				entry->mpls_mangle.ttl = tcf_mpls_ttl(act);
> >   				break;
> >   			default:
> > +				err = -EOPNOTSUPP;
> >   				goto err_out_locked;
> >   			}
> >   		} else if (is_tcf_skbedit_ptype(act)) {
> 
> should we have this commit in net branch with a fixes line
> so it will be taken also to stable kernels?
> 
> 6749d5901698 net: sched: include mpls actions in hardware intermediate
> representation

Thanks Roi,

I think that is a good idea and I have submitted the patch accordingly.

https://lore.kernel.org/netdev/20211213144604.23888-1-simon.horman@corigine.com/

FWIIW, I believe the problem was introduced by:

cba370a93684 ("flow_offload: return EOPNOTSUPP for the unsupported mpls action type")