All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH 02/22] ASoC: codecs: es7241: Use dev_err_probe() helper
Date: Tue, 14 Dec 2021 11:08:23 +0900	[thread overview]
Message-ID: <20211214020843.2225831-3-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20211214020843.2225831-1-kuninori.morimoto.gx@renesas.com>


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Use the dev_err_probe() helper, instead of open-coding the same
operation.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/codecs/es7241.c | 28 +++++++++-------------------
 1 file changed, 9 insertions(+), 19 deletions(-)

diff --git a/sound/soc/codecs/es7241.c b/sound/soc/codecs/es7241.c
index 2344a0b03518..9f20bfb855b3 100644
--- a/sound/soc/codecs/es7241.c
+++ b/sound/soc/codecs/es7241.c
@@ -255,7 +255,6 @@ static int es7241_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct es7241_data *priv;
-	int err;
 
 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -271,28 +270,19 @@ static int es7241_probe(struct platform_device *pdev)
 	es7241_parse_fmt(dev, priv);
 
 	priv->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
-	if (IS_ERR(priv->reset)) {
-		err = PTR_ERR(priv->reset);
-		if (err != -EPROBE_DEFER)
-			dev_err(dev, "Failed to get 'reset' gpio: %d", err);
-		return err;
-	}
+	if (IS_ERR(priv->reset))
+		return dev_err_probe(dev, PTR_ERR(priv->reset),
+				     "Failed to get 'reset' gpio");
 
 	priv->m0 = devm_gpiod_get_optional(dev, "m0", GPIOD_OUT_LOW);
-	if (IS_ERR(priv->m0)) {
-		err = PTR_ERR(priv->m0);
-		if (err != -EPROBE_DEFER)
-			dev_err(dev, "Failed to get 'm0' gpio: %d", err);
-		return err;
-	}
+	if (IS_ERR(priv->m0))
+		return dev_err_probe(dev, PTR_ERR(priv->m0),
+				     "Failed to get 'm0' gpio");
 
 	priv->m1 = devm_gpiod_get_optional(dev, "m1", GPIOD_OUT_LOW);
-	if (IS_ERR(priv->m1)) {
-		err = PTR_ERR(priv->m1);
-		if (err != -EPROBE_DEFER)
-			dev_err(dev, "Failed to get 'm1' gpio: %d", err);
-		return err;
-	}
+	if (IS_ERR(priv->m1))
+		return dev_err_probe(dev, PTR_ERR(priv->m1),
+				     "Failed to get 'm1' gpio");
 
 	return devm_snd_soc_register_component(&pdev->dev,
 				      &es7241_component_driver,
-- 
2.25.1


  parent reply	other threads:[~2021-12-14  2:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14  2:08 [PATCH 00/22] ASoC: Use dev_err_probe() helper Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 01/22] ASoC: codecs: ak4118: " Kuninori Morimoto
2021-12-14  2:08 ` Kuninori Morimoto [this message]
2021-12-14  2:08 ` [PATCH 03/22] ASoC: codecs: max9759: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 04/22] ASoC: codecs: max9860: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 05/22] ASoC: codecs: pcm3168a: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 06/22] ASoC: codecs: sgtl5000: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 07/22] ASoC: codecs: simple-amplifier: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 08/22] ASoC: codecs: simple-mux: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 09/22] ASoC: codecs: ssm2305: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 10/22] ASoC: codecs: tlv320aic31xx: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 11/22] ASoC: ateml: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 12/22] ASoC: ti: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 13/22] ASoC: fsl: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 14/22] ASoC: generic: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 15/22] ASoC: img: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 16/22] ASoC: meson: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 17/22] ASoC: mxs: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 18/22] ASoC: qcom: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 19/22] ASoC: rockchip: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 20/22] ASoC: samsung: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 21/22] ASoC: stm: " Kuninori Morimoto
2021-12-14  2:08 ` [PATCH 22/22] ASoC: sunxi: " Kuninori Morimoto
2021-12-21  2:50 ` [PATCH 00/22] ASoC: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214020843.2225831-3-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.