From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF137C433EF for ; Tue, 14 Dec 2021 04:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhLNECX (ORCPT ); Mon, 13 Dec 2021 23:02:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230216AbhLNECV (ORCPT ); Mon, 13 Dec 2021 23:02:21 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866AAC061574; Mon, 13 Dec 2021 20:02:21 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id p18so12628643plf.13; Mon, 13 Dec 2021 20:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j1+djJMlZ7n2qxxv7yXym5jnIajGvYDCjOTZbw2nAd4=; b=deJIZPNPT8dLz6IgTJHEvbCmjPWUuIr+Pcof8ayGAsF4xseivB9Zb7+sVX5nbxr/Ml KwjpOPAn+XN/jKJPRUAQ8RMxvuEWUKu/sChDJWxIYLeMhwZsUN6T9OdE2COIsuTQS++A Va99kC/Z7ipjuN1jnmfh+1f0+IZOsVwCOjO/Qjy7CTf1KRd35lUtkgI7Uo9Wdffpo943 qRQ0MEuD5LDkgpsrs3vA4jvBWxCf/y+5vp3lii7+8iOTT74Ke5MebbuWLagEGUrj5pJf 6LbG97AfY7Dx4QyB24VWfa62z+myDSgjaSVbn9vO3soIwa5fLupVqaOagDcWstuTFmSq PCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j1+djJMlZ7n2qxxv7yXym5jnIajGvYDCjOTZbw2nAd4=; b=rK+VftgCAb6s77vci1Y2rqAi+sjTVAXKUwJaeL4HfYXvMdWXDqnFOKQi3J9uWvqGhc EiGVjQLdQysdnixBBT0sMNGoqdeGwX5cSz4AYuQWK6IU9mjOE+PCl4gkUbx2fmEHeVnL dRAgKz4/y5N1OM0AkWpqhZt2tApR1QlqAMCCOx7KC0LbRrP5k8uwiOXA0iB4/Fr48YFr O4sNP0P9hrLgLwsGZ3XZd+BKEh4Yqmsod9VaEXPS4hYO3F6rkoO8Ij43bF53njjfpPPR h7ZVDURycb1RNdEggi+Mso2G09+1UixSCR7y20AJbYj8MLJ1dGfAxUKgeGNHFu0v0Ul2 DY3Q== X-Gm-Message-State: AOAM530b1D2VM9fp9fLuW7MiOU4Z16OGDlOuWfRRenmvbnV/ARz33C8s KM1PA/m63p9tcDhPHaFU3M3hFKbZKg== X-Google-Smtp-Source: ABdhPJzDiWY9h/ohKq/TP2XkaHBMlbGlPmFMRgViUggytXflnex5k/qt1KbxtHRvD1NjQCcL2EZ+fA== X-Received: by 2002:a17:90b:2249:: with SMTP id hk9mr2845560pjb.245.1639454540817; Mon, 13 Dec 2021 20:02:20 -0800 (PST) Received: from piliu.users.ipa.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id v63sm11538777pgv.71.2021.12.13.20.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 20:02:20 -0800 (PST) From: Pingfan Liu To: devicetree@vger.kernel.org, linux-efi@vger.kernel.org Cc: Zhen Lei , Rob Herring , Pingfan Liu , Dave Kleikamp , John Donnelly , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 1/2] of: fdt: Aggregate the processing of "linux,usable-memory-range" Date: Tue, 14 Dec 2021 12:01:56 +0800 Message-Id: <20211214040157.27443-2-kernelfans@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211214040157.27443-1-kernelfans@gmail.com> References: <20211214040157.27443-1-kernelfans@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Zhen Lei Currently, we parse the "linux,usable-memory-range" property in early_init_dt_scan_chosen(), to obtain the specified memory range of the crash kernel. We then reserve the required memory after early_init_dt_scan_memory() has identified all available physical memory. Because the two pieces of code are separated far, the readability and maintainability are reduced. So bring them together. Suggested-by: Rob Herring Signed-off-by: Zhen Lei (change the prototype of early_init_dt_check_for_usable_mem_range(), in order to use it outside) Signed-off-by: Pingfan Liu Tested-by: Dave Kleikamp Acked-by: John Donnelly Reviewed-by: Rob Herring Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org To: devicetree@vger.kernel.org To: linux-efi@vger.kernel.org --- I keep the Signed-off-by, Tested-by, Acked-by and Reviewed-by, since I think that the prototype change is not significant. early_init_dt_check_for_usable_mem_range() only handle chosen node, and it is fine to isolate this info inside the function itself so later easier to be used outside. Sorry if you disagree, please let me know. drivers/of/fdt.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index bdca35284ceb..18a2df431bfd 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -965,18 +965,23 @@ static void __init early_init_dt_check_for_elfcorehdr(unsigned long node) elfcorehdr_addr, elfcorehdr_size); } -static phys_addr_t cap_mem_addr; -static phys_addr_t cap_mem_size; +static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND; /** * early_init_dt_check_for_usable_mem_range - Decode usable memory range * location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range(unsigned long node) +static void __init early_init_dt_check_for_usable_mem_range(void) { const __be32 *prop; int len; + phys_addr_t cap_mem_addr; + phys_addr_t cap_mem_size; + unsigned long node = chosen_node_offset; + + if ((long)node < 0) + return; pr_debug("Looking for usable-memory-range property... "); @@ -989,6 +994,8 @@ static void __init early_init_dt_check_for_usable_mem_range(unsigned long node) pr_debug("cap_mem_start=%pa cap_mem_size=%pa\n", &cap_mem_addr, &cap_mem_size); + + memblock_cap_memory_range(cap_mem_addr, cap_mem_size); } #ifdef CONFIG_SERIAL_EARLYCON @@ -1137,9 +1144,10 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname, (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0)) return 0; + chosen_node_offset = node; + early_init_dt_check_for_initrd(node); early_init_dt_check_for_elfcorehdr(node); - early_init_dt_check_for_usable_mem_range(node); /* Retrieve command line */ p = of_get_flat_dt_prop(node, "bootargs", &l); @@ -1275,7 +1283,7 @@ void __init early_init_dt_scan_nodes(void) of_scan_flat_dt(early_init_dt_scan_memory, NULL); /* Handle linux,usable-memory-range property */ - memblock_cap_memory_range(cap_mem_addr, cap_mem_size); + early_init_dt_check_for_usable_mem_range(); } bool __init early_init_dt_scan(void *params) -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9A9DC433F5 for ; Tue, 14 Dec 2021 04:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=npmQvnf3ZEkoUcOf3miqEnupOsoGxUyVgVWinHfxG50=; b=r6CxmBS/YDSXMe NUC3YGXEegFB5SJbJQwyZwOAu1x7JR4B+fu6/0JBg5Y0YxOIe50Km3y/g0Mfk3J1Q5qLq+NPianRJ VZ3zs6qCOJa9Y8ifd5JLlMnFFFN8RG125uq3/LACEhdyIGDr+vujbb/q7RwgVVU6WVyoMCfuNnAUc Hs0OAvcKBfrRY2IFSd+zexof3bTjaVuqPRC9CFBg+vSHE07dCwFJSHwOLl6U0JAbBfx4vOgdgmzop EV2M++4wosv+gOzoq9+xbsgJF7/xecTnVM2lykImK3guqG9UGg/riJq5CXaS4hqctMafs6kmHFSnq Dd7OTsRhoQYf5m+/yDOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwz1c-00CUrR-00; Tue, 14 Dec 2021 04:02:48 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwz1B-00CUio-NZ for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 04:02:23 +0000 Received: by mail-pl1-x62a.google.com with SMTP id b13so12677526plg.2 for ; Mon, 13 Dec 2021 20:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j1+djJMlZ7n2qxxv7yXym5jnIajGvYDCjOTZbw2nAd4=; b=deJIZPNPT8dLz6IgTJHEvbCmjPWUuIr+Pcof8ayGAsF4xseivB9Zb7+sVX5nbxr/Ml KwjpOPAn+XN/jKJPRUAQ8RMxvuEWUKu/sChDJWxIYLeMhwZsUN6T9OdE2COIsuTQS++A Va99kC/Z7ipjuN1jnmfh+1f0+IZOsVwCOjO/Qjy7CTf1KRd35lUtkgI7Uo9Wdffpo943 qRQ0MEuD5LDkgpsrs3vA4jvBWxCf/y+5vp3lii7+8iOTT74Ke5MebbuWLagEGUrj5pJf 6LbG97AfY7Dx4QyB24VWfa62z+myDSgjaSVbn9vO3soIwa5fLupVqaOagDcWstuTFmSq PCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j1+djJMlZ7n2qxxv7yXym5jnIajGvYDCjOTZbw2nAd4=; b=7yWuGSnTuLzMGQibgB9dmByJU/dE6wtXnxCmyEtQiy4j09IK/+JwGP+mAQpm9Y1Kwa 9OIHiN3FUa9GKV/AQWykgH0HSgU9XvyTBusOsMNEPuY0TXEF6R6mD7s3YzhvLXsmRlQv Vba91lvJNyhdh3x6Jz4Os8SQcNyYqjNAY9hc6OuuDc/Es4Zzd1zxeBQZIf1Tu1FEcp5V bmnE3ZKujN/7XW7PqtCkPObM1BzImRwfetWdFQGLmoju6bijzkt6tY/SfxX3ye+O3Gc/ fujrhuWS6tIKjEMSrsWr8icaYLeqJcxakZFFhgvdtPqyQK1x2g10Nyii1ZcdK7yxgmFR vYsA== X-Gm-Message-State: AOAM532UMIBdmZ4vBTA6uOovvO9NiLIQs9jwUyQEdJZ52mzIGPQ2XnVx p8bvh7fSj9kFHnXkHNVSlA== X-Google-Smtp-Source: ABdhPJzDiWY9h/ohKq/TP2XkaHBMlbGlPmFMRgViUggytXflnex5k/qt1KbxtHRvD1NjQCcL2EZ+fA== X-Received: by 2002:a17:90b:2249:: with SMTP id hk9mr2845560pjb.245.1639454540817; Mon, 13 Dec 2021 20:02:20 -0800 (PST) Received: from piliu.users.ipa.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id v63sm11538777pgv.71.2021.12.13.20.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 20:02:20 -0800 (PST) From: Pingfan Liu To: devicetree@vger.kernel.org, linux-efi@vger.kernel.org Cc: Zhen Lei , Rob Herring , Pingfan Liu , Dave Kleikamp , John Donnelly , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 1/2] of: fdt: Aggregate the processing of "linux, usable-memory-range" Date: Tue, 14 Dec 2021 12:01:56 +0800 Message-Id: <20211214040157.27443-2-kernelfans@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211214040157.27443-1-kernelfans@gmail.com> References: <20211214040157.27443-1-kernelfans@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_200221_836492_9ABB7D1A X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Zhen Lei Currently, we parse the "linux,usable-memory-range" property in early_init_dt_scan_chosen(), to obtain the specified memory range of the crash kernel. We then reserve the required memory after early_init_dt_scan_memory() has identified all available physical memory. Because the two pieces of code are separated far, the readability and maintainability are reduced. So bring them together. Suggested-by: Rob Herring Signed-off-by: Zhen Lei (change the prototype of early_init_dt_check_for_usable_mem_range(), in order to use it outside) Signed-off-by: Pingfan Liu Tested-by: Dave Kleikamp Acked-by: John Donnelly Reviewed-by: Rob Herring Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org To: devicetree@vger.kernel.org To: linux-efi@vger.kernel.org --- I keep the Signed-off-by, Tested-by, Acked-by and Reviewed-by, since I think that the prototype change is not significant. early_init_dt_check_for_usable_mem_range() only handle chosen node, and it is fine to isolate this info inside the function itself so later easier to be used outside. Sorry if you disagree, please let me know. drivers/of/fdt.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index bdca35284ceb..18a2df431bfd 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -965,18 +965,23 @@ static void __init early_init_dt_check_for_elfcorehdr(unsigned long node) elfcorehdr_addr, elfcorehdr_size); } -static phys_addr_t cap_mem_addr; -static phys_addr_t cap_mem_size; +static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND; /** * early_init_dt_check_for_usable_mem_range - Decode usable memory range * location from flat tree * @node: reference to node containing usable memory range location ('chosen') */ -static void __init early_init_dt_check_for_usable_mem_range(unsigned long node) +static void __init early_init_dt_check_for_usable_mem_range(void) { const __be32 *prop; int len; + phys_addr_t cap_mem_addr; + phys_addr_t cap_mem_size; + unsigned long node = chosen_node_offset; + + if ((long)node < 0) + return; pr_debug("Looking for usable-memory-range property... "); @@ -989,6 +994,8 @@ static void __init early_init_dt_check_for_usable_mem_range(unsigned long node) pr_debug("cap_mem_start=%pa cap_mem_size=%pa\n", &cap_mem_addr, &cap_mem_size); + + memblock_cap_memory_range(cap_mem_addr, cap_mem_size); } #ifdef CONFIG_SERIAL_EARLYCON @@ -1137,9 +1144,10 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname, (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0)) return 0; + chosen_node_offset = node; + early_init_dt_check_for_initrd(node); early_init_dt_check_for_elfcorehdr(node); - early_init_dt_check_for_usable_mem_range(node); /* Retrieve command line */ p = of_get_flat_dt_prop(node, "bootargs", &l); @@ -1275,7 +1283,7 @@ void __init early_init_dt_scan_nodes(void) of_scan_flat_dt(early_init_dt_scan_memory, NULL); /* Handle linux,usable-memory-range property */ - memblock_cap_memory_range(cap_mem_addr, cap_mem_size); + early_init_dt_check_for_usable_mem_range(); } bool __init early_init_dt_scan(void *params) -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel