From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 673C6C433EF for ; Tue, 14 Dec 2021 07:05:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 59E0882849; Tue, 14 Dec 2021 08:05:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="EKEgLr8/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1A6D82FD0; Tue, 14 Dec 2021 08:05:41 +0100 (CET) Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7810181761 for ; Tue, 14 Dec 2021 08:05:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1031.google.com with SMTP id n15-20020a17090a394f00b001b0f6d6468eso1343pjf.3 for ; Mon, 13 Dec 2021 23:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=4ZMhpr/0wkh5VD9f1Y1UcqMtLbDi9hOSVCH+TFBi5vY=; b=EKEgLr8/6NydyAamk8f3Um0h/rUulQ5doJbgPuqsvsZ62krnpdfOkkYOidHYFLfXMV iVvoi/37S0GB4AoRELS8klNcgfnyE0X3B8L5gJxrFEaBUYcJPuGL10mO0QFPyhzlDmoX mT+v6NcGqNDJ9ils+EfztHaitJEK4FdfEc/8P+zyKPKp+z5Zy09l7BaT2l7pERfCxQW0 qrmirDcnt+X6LsBptmBdTkjjdTDP2PTSjphxEA939q4hNHCJooJfsrY+hPYpplIjJBhC kdbhW3N3iXOBjNlnP18m37kvzxkFxy57b0Z7ZKJtlfwjfjIU68Cvq9Bljf+u5TbDtmtT dz/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=4ZMhpr/0wkh5VD9f1Y1UcqMtLbDi9hOSVCH+TFBi5vY=; b=TvNFN2U2GkcjdFLKgimvho94o2J9+BG3Pl6/etqukLq/uaufLAByliA4ZWRJZNd7F2 l7WprXiiYE78Z41qjrkCF7rJFZbt082JZVdlRlWSDqv7PpauNxszyvOnZXsyRvuE91TP cdznJLFuIEOo5DaEY7FMDEpomfCjFarVFYTQtjWloIxhRCQMKIF/1cD6TE+zn6wxC1he YlD0fk/Kxja1Lj2k33er5K7NHCXBInJ0Oeu5sRvycscav2qSWHd8N2WnYYs0V2RUQhRC N39M9LOFn1Z5PXm1/HaQsrYcVrko2K95p14XfhmcZBvuelbbrA5ySkNlaIZNAEWXaF2u Z+SQ== X-Gm-Message-State: AOAM5318gmt74EuKHA4CsuBuvtSQP7t8d13Gt1kHcg2IC3kxyGkCVHKE yjjB/wpwG0TAsMqPWh0GSFo98A== X-Google-Smtp-Source: ABdhPJwmPgsKc/hakPVYzeaI04FCw47iv3rx33toZVgnPIcT/j8JhiWDL7pEl5KRST/eotdIzUbWjg== X-Received: by 2002:a17:90b:4a43:: with SMTP id lb3mr3678173pjb.222.1639465536854; Mon, 13 Dec 2021 23:05:36 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:8d4a:ac59:26ea:d2bb]) by smtp.gmail.com with ESMTPSA id lr3sm1321037pjb.34.2021.12.13.23.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 23:05:36 -0800 (PST) Date: Tue, 14 Dec 2021 16:05:32 +0900 From: AKASHI Takahiro To: Simon Glass Cc: xypron.glpk@gmx.de, agraf@csgraf.de, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Subject: Re: [RFC v2 12/20] dm: add tag support Message-ID: <20211214070532.GB49357@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , xypron.glpk@gmx.de, agraf@csgraf.de, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-13-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Dec 13, 2021 at 05:51:45AM -0700, Simon Glass wrote: > Hi Takahiro, > > On Thu, 9 Dec 2021 at 23:58, AKASHI Takahiro wrote: > > > > With dm-tag feature, any U-Boot subsystem is allowed to associate > > arbitrary number of data with a particular udevice. This can been > > see as expanding "struct udevice" without modifying the definition. > > > > As a first user, UEFI subsystem makes use of tags to associate > > an efi_disk object with a block device. > > > > Signed-off-by: AKASHI Takahiro > > --- > > drivers/core/Makefile | 2 +- > > drivers/core/tag.c | 162 ++++++++++++++++++++++++++++++++++++++++++ > > include/dm/tag.h | 76 ++++++++++++++++++++ > > 3 files changed, 239 insertions(+), 1 deletion(-) > > create mode 100644 drivers/core/tag.c > > create mode 100644 include/dm/tag.h > > Needs comments and a test, but looks good. > > How does the list itself get inited? Isn't LIST_HEAD(dmtag_list) enough? -Takahiro Akashi > Regards, > Simon