From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3EA8C433FE for ; Tue, 14 Dec 2021 14:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234747AbhLNOBy (ORCPT ); Tue, 14 Dec 2021 09:01:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234696AbhLNOBw (ORCPT ); Tue, 14 Dec 2021 09:01:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4256BC061574; Tue, 14 Dec 2021 06:01:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBA7B614DA; Tue, 14 Dec 2021 14:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC22CC34601; Tue, 14 Dec 2021 14:01:49 +0000 (UTC) Date: Tue, 14 Dec 2021 09:01:48 -0500 From: Steven Rostedt To: Christophe Leroy Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Ingo Molnar , "Naveen N . Rao" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "live-patching@vger.kernel.org" , "linux-s390@vger.kernel.org" Subject: Re: [PATCH v1 0/5] Implement livepatch on PPC32 Message-ID: <20211214090148.264f4660@gandalf.local.home> In-Reply-To: References: <20211028093547.48c69dfe@gandalf.local.home> <6209682d-0caa-b779-8763-376a984d8ed8@csgroup.eu> <20211213121536.25e5488d@gandalf.local.home> <5511f43c-192a-622b-7c72-52e07f0032c2@csgroup.eu> <20211213123338.65eda5a0@gandalf.local.home> <20211213135410.12642d8f@gandalf.local.home> <8df90f94-9939-0178-b92b-6ae6ea81784c@csgroup.eu> <20211213144603.47d7c908@gandalf.local.home> <76ce2dd7-691e-df73-727c-110713c07cda@csgroup.eu> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Dec 2021 08:35:14 +0100 Christophe Leroy wrote: > > Will continue investigating. > > > > trace_selftest_startup_function_graph() calls register_ftrace_direct() > which returns -ENOSUPP because powerpc doesn't select > CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS. > > Should TEST_DIRECT_TRAMP depend on CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS ? Yes, that should be: #if defined(CONFIG_DYNAMIC_FTRACE) && \ defined(CONFIG_HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS) #define TEST_DIRECT_TRAMP noinline __noclone static void trace_direct_tramp(void) { } #endif And make it test it with or without the args. Thanks for finding this. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86C69C433EF for ; Tue, 14 Dec 2021 14:02:23 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JD0SF6bDSz308J for ; Wed, 15 Dec 2021 01:02:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=srs0=l0ty=q7=goodmis.org=rostedt@kernel.org; receiver=) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JD0Rq0gSzz2xvL for ; Wed, 15 Dec 2021 01:01:59 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE54A61505; Tue, 14 Dec 2021 14:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC22CC34601; Tue, 14 Dec 2021 14:01:49 +0000 (UTC) Date: Tue, 14 Dec 2021 09:01:48 -0500 From: Steven Rostedt To: Christophe Leroy Subject: Re: [PATCH v1 0/5] Implement livepatch on PPC32 Message-ID: <20211214090148.264f4660@gandalf.local.home> In-Reply-To: References: <20211028093547.48c69dfe@gandalf.local.home> <6209682d-0caa-b779-8763-376a984d8ed8@csgroup.eu> <20211213121536.25e5488d@gandalf.local.home> <5511f43c-192a-622b-7c72-52e07f0032c2@csgroup.eu> <20211213123338.65eda5a0@gandalf.local.home> <20211213135410.12642d8f@gandalf.local.home> <8df90f94-9939-0178-b92b-6ae6ea81784c@csgroup.eu> <20211213144603.47d7c908@gandalf.local.home> <76ce2dd7-691e-df73-727c-110713c07cda@csgroup.eu> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Joe Lawrence , "linux-s390@vger.kernel.org" , Jiri Kosina , "linux-kernel@vger.kernel.org" , Ingo Molnar , Josh Poimboeuf , "live-patching@vger.kernel.org" , "Naveen N . Rao" , Miroslav Benes , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 14 Dec 2021 08:35:14 +0100 Christophe Leroy wrote: > > Will continue investigating. > > > > trace_selftest_startup_function_graph() calls register_ftrace_direct() > which returns -ENOSUPP because powerpc doesn't select > CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS. > > Should TEST_DIRECT_TRAMP depend on CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS ? Yes, that should be: #if defined(CONFIG_DYNAMIC_FTRACE) && \ defined(CONFIG_HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS) #define TEST_DIRECT_TRAMP noinline __noclone static void trace_direct_tramp(void) { } #endif And make it test it with or without the args. Thanks for finding this. -- Steve