From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC69C433FE for ; Tue, 14 Dec 2021 11:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233625AbhLNLlr (ORCPT ); Tue, 14 Dec 2021 06:41:47 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:59997 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233645AbhLNLlr (ORCPT ); Tue, 14 Dec 2021 06:41:47 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id BBA38240009; Tue, 14 Dec 2021 11:41:41 +0000 (UTC) From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Mark Brown , Cc: Julien Su , Jaime Liao , Thomas Petazzoni , Boris Brezillon , Xiangsheng Hou , Miquel Raynal Subject: [PATCH v5 00/13] Pipelined ECC engines & Macronix support Date: Tue, 14 Dec 2021 12:41:27 +0100 Message-Id: <20211214114140.54629-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hello all, This is a second version of the second half of the "External ECC engines & Macronix support" series, focusing on the pipelined support. Cheers, Miquèl Changes in v5: * Moved a helper in the core as it seems that it will be useful for other ECC engines as well (Xiangsheng Hou for Mediatek will need it). * Changed the parameters of the spi_mem_generic_supports_op() function in order to take a structure as input instead of a list of arguments, which will be much easier to complement in the future if ever needed. Changes in v4: * The first half of the series has been left aside (all the binding changes + the external mode in the Macronix driver), now let's focus on the pipelined mode. * Added the ecc_en spi_mem_op structure parameter in a dedicated commit. * Introduced a new helper for supporting generically the supported ops. * Used this new helper in the macronix driver. * By default all the other drivers would refuse a spi_mem_op with ecc_en enabled. Changes in v3: * Added Mark's R-by. * Added a commit changing the initialization order between the dirmaps and the ECC engine so that the core might now if we are using a pipelined engine or not. * Stopped creating additional dirmaps with ECC if the engine is not a pipelined engine. * Solved the kernel test robot reports. In particular, I added a dependency on MTD_NAND_ECC to Macronix SPI controller driver. * Added a patch to clean the NAND controller yaml file before moving some bits to nand-chip.yaml. This addresses the comments made by Rob about the useless allOf's. * Used platform_get_irq_byname_optional() in order to avoid useless warnings when there is no IRQ. Changes in v2: * Fixed the bindings and added Rob's acks when relevant. * Added locking in the ECC engine driver. * Brought more changes in the core in order to bring the ECC information into the spi_mem_op structure with the idea of avoiding any races between parallel calls on the same engine. * Reorganized the ECC driver entirely in order to have a per-engine mxic structure plus a per-NAND context. This lead to a number of changes internally which cannot all be listed. Changes since the RFC: * Rebased on top of v5.15-rc1. * Fixed the dirmap configuration. * Added the various tags received. * Fixed the bindings as reported by the robots. * Fixed the return value of the helper counting bitflips. * Included a fix from Jaime Liao in the external pattern logic. * Added the yaml conversion of Macronix SPI controller description. * Added the yaml conversion of the SPI-NAND description. * Created a nand-chip.yaml file to share properties between SPI-NAND and raw NAND. Miquel Raynal (13): mtd: nand: ecc: Provide a helper to retrieve a pilelined engine device mtd: nand: mxic-ecc: Support SPI pipelined mode mtd: spinand: Delay a little bit the dirmap creation spi: spi-mem: Create a helper to gather all the supports_op checks spi: spi-mem: Export the spi_mem_generic_supports_op() helper spi: spi-mem: Add an ecc_en parameter to the spi_mem_op structure mtd: spinand: Create direct mapping descriptors for ECC operations spi: mxic: Fix the transmit path spi: mxic: Create a helper to configure the controller before an operation spi: mxic: Create a helper to ease the start of an operation spi: mxic: Add support for direct mapping spi: mxic: Use spi_mem_generic_supports_op() spi: mxic: Add support for pipelined ECC operations drivers/mtd/nand/ecc-mxic.c | 181 +++++++++++++++- drivers/mtd/nand/ecc.c | 31 +++ drivers/mtd/nand/spi/core.c | 51 ++++- drivers/spi/Kconfig | 2 +- drivers/spi/spi-mem.c | 40 +++- drivers/spi/spi-mxic.c | 337 ++++++++++++++++++++++++------ include/linux/mtd/nand-ecc-mxic.h | 49 +++++ include/linux/mtd/nand.h | 1 + include/linux/mtd/spinand.h | 2 + include/linux/spi/spi-mem.h | 25 +++ 10 files changed, 639 insertions(+), 80 deletions(-) create mode 100644 include/linux/mtd/nand-ecc-mxic.h -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54A7FC433F5 for ; Tue, 14 Dec 2021 11:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1Fk05jcpMM6DssUNoPeIDWMZy70x6JHW5TckBAJv6rM=; b=EBxXpKt2Qa5Ok7 FDIZWTjPnKpyoCecsG9/SwUJjzL/gR7Fhvx5NoYdjtZ9kL1iDv1GshCMvRn4YSwBBYU0tNQSQzWsa 5lAiCq0qGdGDy4+h9Cd/3oFtJywPGcaFTgBNlNltnxI69nE88FKdwJQ6qpBXswM1c+adfLUlWObsP sbvWRRFpvrohgb4+R3dYYURK0zPgcT8ZMrxT7jsRq/JvoMX73YhsuwGWAatSWRJ/tr1EqX50ZHAgq HDC8xvfVvOS87N+IpNUYL2j3MRflqfuQ6pnH4NRwS1utWyHfWuQ1BluaRMjiE5kqgKXHI0zs83mjI 7DTHHuzDWYVkFaNaB/cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx6CL-00Djmd-TH; Tue, 14 Dec 2021 11:42:21 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx6Bp-00DjVj-8U for linux-mtd@lists.infradead.org; Tue, 14 Dec 2021 11:41:51 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id BBA38240009; Tue, 14 Dec 2021 11:41:41 +0000 (UTC) From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Mark Brown , Cc: Julien Su , Jaime Liao , Thomas Petazzoni , Boris Brezillon , Xiangsheng Hou , Miquel Raynal Subject: [PATCH v5 00/13] Pipelined ECC engines & Macronix support Date: Tue, 14 Dec 2021 12:41:27 +0100 Message-Id: <20211214114140.54629-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_034149_605152_334BFCF7 X-CRM114-Status: GOOD ( 19.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gYWxsLAoKVGhpcyBpcyBhIHNlY29uZCB2ZXJzaW9uIG9mIHRoZSBzZWNvbmQgaGFsZiBv ZiB0aGUgIkV4dGVybmFsIEVDQyBlbmdpbmVzCiYgTWFjcm9uaXggc3VwcG9ydCIgc2VyaWVzLCBm b2N1c2luZyBvbiB0aGUgcGlwZWxpbmVkIHN1cHBvcnQuCgpDaGVlcnMsCk1pcXXDqGwKCkNoYW5n ZXMgaW4gdjU6CiogTW92ZWQgYSBoZWxwZXIgaW4gdGhlIGNvcmUgYXMgaXQgc2VlbXMgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCBmb3IKICBvdGhlciBFQ0MgZW5naW5lcyBhcyB3ZWxsIChYaWFuZ3No ZW5nIEhvdSBmb3IgTWVkaWF0ZWsgd2lsbCBuZWVkIGl0KS4KKiBDaGFuZ2VkIHRoZSBwYXJhbWV0 ZXJzIG9mIHRoZSBzcGlfbWVtX2dlbmVyaWNfc3VwcG9ydHNfb3AoKSBmdW5jdGlvbgogIGluIG9y ZGVyIHRvIHRha2UgYSBzdHJ1Y3R1cmUgYXMgaW5wdXQgaW5zdGVhZCBvZiBhIGxpc3Qgb2YgYXJn dW1lbnRzLAogIHdoaWNoIHdpbGwgYmUgbXVjaCBlYXNpZXIgdG8gY29tcGxlbWVudCBpbiB0aGUg ZnV0dXJlIGlmIGV2ZXIgbmVlZGVkLgoKQ2hhbmdlcyBpbiB2NDoKKiBUaGUgZmlyc3QgaGFsZiBv ZiB0aGUgc2VyaWVzIGhhcyBiZWVuIGxlZnQgYXNpZGUgKGFsbCB0aGUgYmluZGluZwogIGNoYW5n ZXMgKyB0aGUgZXh0ZXJuYWwgbW9kZSBpbiB0aGUgTWFjcm9uaXggZHJpdmVyKSwgbm93IGxldCdz IGZvY3VzCiAgb24gdGhlIHBpcGVsaW5lZCBtb2RlLgoqIEFkZGVkIHRoZSBlY2NfZW4gc3BpX21l bV9vcCBzdHJ1Y3R1cmUgcGFyYW1ldGVyIGluIGEgZGVkaWNhdGVkIGNvbW1pdC4KKiBJbnRyb2R1 Y2VkIGEgbmV3IGhlbHBlciBmb3Igc3VwcG9ydGluZyBnZW5lcmljYWxseSB0aGUgc3VwcG9ydGVk IG9wcy4KKiBVc2VkIHRoaXMgbmV3IGhlbHBlciBpbiB0aGUgbWFjcm9uaXggZHJpdmVyLgoqIEJ5 IGRlZmF1bHQgYWxsIHRoZSBvdGhlciBkcml2ZXJzIHdvdWxkIHJlZnVzZSBhIHNwaV9tZW1fb3Ag d2l0aCBlY2NfZW4KICBlbmFibGVkLgoKQ2hhbmdlcyBpbiB2MzoKKiBBZGRlZCBNYXJrJ3MgUi1i eS4KKiBBZGRlZCBhIGNvbW1pdCBjaGFuZ2luZyB0aGUgaW5pdGlhbGl6YXRpb24gb3JkZXIgYmV0 d2VlbiB0aGUgZGlybWFwcwogIGFuZCB0aGUgRUNDIGVuZ2luZSBzbyB0aGF0IHRoZSBjb3JlIG1p Z2h0IG5vdyBpZiB3ZSBhcmUgdXNpbmcgYQogIHBpcGVsaW5lZCBlbmdpbmUgb3Igbm90LgoqIFN0 b3BwZWQgY3JlYXRpbmcgYWRkaXRpb25hbCBkaXJtYXBzIHdpdGggRUNDIGlmIHRoZSBlbmdpbmUg aXMgbm90IGEKICBwaXBlbGluZWQgZW5naW5lLgoqIFNvbHZlZCB0aGUga2VybmVsIHRlc3Qgcm9i b3QgcmVwb3J0cy4gSW4gcGFydGljdWxhciwgSSBhZGRlZCBhCiAgZGVwZW5kZW5jeSBvbiBNVERf TkFORF9FQ0MgdG8gTWFjcm9uaXggU1BJIGNvbnRyb2xsZXIgZHJpdmVyLgoqIEFkZGVkIGEgcGF0 Y2ggdG8gY2xlYW4gdGhlIE5BTkQgY29udHJvbGxlciB5YW1sIGZpbGUgYmVmb3JlIG1vdmluZwog IHNvbWUgYml0cyB0byBuYW5kLWNoaXAueWFtbC4gVGhpcyBhZGRyZXNzZXMgdGhlIGNvbW1lbnRz IG1hZGUgYnkgUm9iCiAgYWJvdXQgdGhlIHVzZWxlc3MgYWxsT2Yncy4KKiBVc2VkIHBsYXRmb3Jt X2dldF9pcnFfYnluYW1lX29wdGlvbmFsKCkgaW4gb3JkZXIgdG8gYXZvaWQgdXNlbGVzcwogIHdh cm5pbmdzIHdoZW4gdGhlcmUgaXMgbm8gSVJRLgoKQ2hhbmdlcyBpbiB2MjoKKiBGaXhlZCB0aGUg YmluZGluZ3MgYW5kIGFkZGVkIFJvYidzIGFja3Mgd2hlbiByZWxldmFudC4KKiBBZGRlZCBsb2Nr aW5nIGluIHRoZSBFQ0MgZW5naW5lIGRyaXZlci4KKiBCcm91Z2h0IG1vcmUgY2hhbmdlcyBpbiB0 aGUgY29yZSBpbiBvcmRlciB0byBicmluZyB0aGUgRUNDIGluZm9ybWF0aW9uCiAgaW50byB0aGUg c3BpX21lbV9vcCBzdHJ1Y3R1cmUgd2l0aCB0aGUgaWRlYSBvZiBhdm9pZGluZyBhbnkgcmFjZXMK ICBiZXR3ZWVuIHBhcmFsbGVsIGNhbGxzIG9uIHRoZSBzYW1lIGVuZ2luZS4KKiBSZW9yZ2FuaXpl ZCB0aGUgRUNDIGRyaXZlciBlbnRpcmVseSBpbiBvcmRlciB0byBoYXZlIGEgcGVyLWVuZ2luZSBt eGljCiAgc3RydWN0dXJlIHBsdXMgYSBwZXItTkFORCBjb250ZXh0LiBUaGlzIGxlYWQgdG8gYSBu dW1iZXIgb2YgY2hhbmdlcwogIGludGVybmFsbHkgd2hpY2ggY2Fubm90IGFsbCBiZSBsaXN0ZWQu CgpDaGFuZ2VzIHNpbmNlIHRoZSBSRkM6CiogUmViYXNlZCBvbiB0b3Agb2YgdjUuMTUtcmMxLgoq IEZpeGVkIHRoZSBkaXJtYXAgY29uZmlndXJhdGlvbi4KKiBBZGRlZCB0aGUgdmFyaW91cyB0YWdz IHJlY2VpdmVkLgoqIEZpeGVkIHRoZSBiaW5kaW5ncyBhcyByZXBvcnRlZCBieSB0aGUgcm9ib3Rz LgoqIEZpeGVkIHRoZSByZXR1cm4gdmFsdWUgb2YgdGhlIGhlbHBlciBjb3VudGluZyBiaXRmbGlw cy4KKiBJbmNsdWRlZCBhIGZpeCBmcm9tIEphaW1lIExpYW8gaW4gdGhlIGV4dGVybmFsIHBhdHRl cm4gbG9naWMuCiogQWRkZWQgdGhlIHlhbWwgY29udmVyc2lvbiBvZiBNYWNyb25peCBTUEkgY29u dHJvbGxlciBkZXNjcmlwdGlvbi4KKiBBZGRlZCB0aGUgeWFtbCBjb252ZXJzaW9uIG9mIHRoZSBT UEktTkFORCBkZXNjcmlwdGlvbi4KKiBDcmVhdGVkIGEgbmFuZC1jaGlwLnlhbWwgZmlsZSB0byBz aGFyZSBwcm9wZXJ0aWVzIGJldHdlZW4gU1BJLU5BTkQgYW5kCiAgcmF3IE5BTkQuCgpNaXF1ZWwg UmF5bmFsICgxMyk6CiAgbXRkOiBuYW5kOiBlY2M6IFByb3ZpZGUgYSBoZWxwZXIgdG8gcmV0cmll dmUgYSBwaWxlbGluZWQgZW5naW5lIGRldmljZQogIG10ZDogbmFuZDogbXhpYy1lY2M6IFN1cHBv cnQgU1BJIHBpcGVsaW5lZCBtb2RlCiAgbXRkOiBzcGluYW5kOiBEZWxheSBhIGxpdHRsZSBiaXQg dGhlIGRpcm1hcCBjcmVhdGlvbgogIHNwaTogc3BpLW1lbTogQ3JlYXRlIGEgaGVscGVyIHRvIGdh dGhlciBhbGwgdGhlIHN1cHBvcnRzX29wIGNoZWNrcwogIHNwaTogc3BpLW1lbTogRXhwb3J0IHRo ZSBzcGlfbWVtX2dlbmVyaWNfc3VwcG9ydHNfb3AoKSBoZWxwZXIKICBzcGk6IHNwaS1tZW06IEFk ZCBhbiBlY2NfZW4gcGFyYW1ldGVyIHRvIHRoZSBzcGlfbWVtX29wIHN0cnVjdHVyZQogIG10ZDog c3BpbmFuZDogQ3JlYXRlIGRpcmVjdCBtYXBwaW5nIGRlc2NyaXB0b3JzIGZvciBFQ0Mgb3BlcmF0 aW9ucwogIHNwaTogbXhpYzogRml4IHRoZSB0cmFuc21pdCBwYXRoCiAgc3BpOiBteGljOiBDcmVh dGUgYSBoZWxwZXIgdG8gY29uZmlndXJlIHRoZSBjb250cm9sbGVyIGJlZm9yZSBhbgogICAgb3Bl cmF0aW9uCiAgc3BpOiBteGljOiBDcmVhdGUgYSBoZWxwZXIgdG8gZWFzZSB0aGUgc3RhcnQgb2Yg YW4gb3BlcmF0aW9uCiAgc3BpOiBteGljOiBBZGQgc3VwcG9ydCBmb3IgZGlyZWN0IG1hcHBpbmcK ICBzcGk6IG14aWM6IFVzZSBzcGlfbWVtX2dlbmVyaWNfc3VwcG9ydHNfb3AoKQogIHNwaTogbXhp YzogQWRkIHN1cHBvcnQgZm9yIHBpcGVsaW5lZCBFQ0Mgb3BlcmF0aW9ucwoKIGRyaXZlcnMvbXRk L25hbmQvZWNjLW14aWMuYyAgICAgICB8IDE4MSArKysrKysrKysrKysrKystCiBkcml2ZXJzL210 ZC9uYW5kL2VjYy5jICAgICAgICAgICAgfCAgMzEgKysrCiBkcml2ZXJzL210ZC9uYW5kL3NwaS9j b3JlLmMgICAgICAgfCAgNTEgKysrKy0KIGRyaXZlcnMvc3BpL0tjb25maWcgICAgICAgICAgICAg ICB8ICAgMiArLQogZHJpdmVycy9zcGkvc3BpLW1lbS5jICAgICAgICAgICAgIHwgIDQwICsrKy0K IGRyaXZlcnMvc3BpL3NwaS1teGljLmMgICAgICAgICAgICB8IDMzNyArKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0KIGluY2x1ZGUvbGludXgvbXRkL25hbmQtZWNjLW14aWMuaCB8ICA0OSAr KysrKwogaW5jbHVkZS9saW51eC9tdGQvbmFuZC5oICAgICAgICAgIHwgICAxICsKIGluY2x1ZGUv bGludXgvbXRkL3NwaW5hbmQuaCAgICAgICB8ICAgMiArCiBpbmNsdWRlL2xpbnV4L3NwaS9zcGkt bWVtLmggICAgICAgfCAgMjUgKysrCiAxMCBmaWxlcyBjaGFuZ2VkLCA2MzkgaW5zZXJ0aW9ucygr KSwgODAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9saW51eC9tdGQv bmFuZC1lY2MtbXhpYy5oCgotLSAKMi4yNy4wCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcg bGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10 ZC8K