From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B129C433F5 for ; Wed, 15 Dec 2021 11:01:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241898AbhLOLBc (ORCPT ); Wed, 15 Dec 2021 06:01:32 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:23495 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241890AbhLOLBb (ORCPT ); Wed, 15 Dec 2021 06:01:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639566091; x=1671102091; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FJoZ3/X+f//Ot1xushVx/AGt8XPLPpyGKxiMYuKplkY=; b=aT5OfyNJTw7npMjIQvp8t0BPM0LytgaNKqixVypMKjJZIGLqEBQycEXS EqCiic8dNP8O/29VhR542qnRGYRoerEQkyRCTEg7EnHQc/igKWE8g2Rq1 NksbYHZ6Ox7DyyPkJoJvj7OIt/vMzaze/QW92hSptnUMp81zUwf0uKcC8 5a5kccyWmToIxc3Oy6uvRmpT8It2KELUacUDd4dhAhNeGTmhSHBXTdo1X 5s/g3lYC4N4/ZadGynC5F3szNuZPHc3jpd5/EEl8MU2/az4OvEHnO1Zsz HKt1si4ywWUzJ9HfoAF6OzNPyXYRuuHvefyJ5jKyIVwDiydxjYPNDbns4 A==; IronPort-SDR: 24p0OL/8SfbTQ6kN8CmBXbEEVngV9Osvo3Uv1duiYezK5pv7arGf1cUL96S0edQE4+rGr3srVR 3OvYEQnhfi+pjwoEvD68U/xbR/E/IfoIYzhXbzSzVrJpl2IpoLrjXk28XA/Sme2R4rZXxf7kDj yZ+eij7TsRxr0HMwS/hgcZ3ItTD6jA2Cu8lRlETil4V31kVSBJnVn7pMpwqWemjrYHma1oHXCs olq4Zl8413xYqc7LkHWDz5KMWmf+srwLnRpsz4mmMsW92LaDNSnrTawdMutV/jSVbJdGDUKAjd zeB7zto0Te1izo6CYDef5WQm X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="142483350" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Dec 2021 04:01:26 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 15 Dec 2021 04:01:25 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 15 Dec 2021 04:01:23 -0700 From: Tudor Ambarus To: CC: , , , , , , Tudor Ambarus Subject: [PATCH v3 02/12] dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending Date: Wed, 15 Dec 2021 13:01:05 +0200 Message-ID: <20211215110115.191749-3-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211215110115.191749-1-tudor.ambarus@microchip.com> References: <20211215110115.191749-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Cyclic channels must too call issue_pending in order to start a transfer. Start the transfer in issue_pending regardless of the type of channel. This wrongly worked before, because in the past the transfer was started at tx_submit level when only a desc in the transfer list. Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Signed-off-by: Tudor Ambarus --- drivers/dma/at_xdmac.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4ff12b083136..c3d3e1270236 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1778,11 +1778,9 @@ static void at_xdmac_issue_pending(struct dma_chan *chan) dev_dbg(chan2dev(&atchan->chan), "%s\n", __func__); - if (!at_xdmac_chan_is_cyclic(atchan)) { - spin_lock_irqsave(&atchan->lock, flags); - at_xdmac_advance_work(atchan); - spin_unlock_irqrestore(&atchan->lock, flags); - } + spin_lock_irqsave(&atchan->lock, flags); + at_xdmac_advance_work(atchan); + spin_unlock_irqrestore(&atchan->lock, flags); return; } -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37CF5C433EF for ; Wed, 15 Dec 2021 11:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cotavFvka6kfdYwtfgTRWsc2vjv/nXMQb+pj7KDh4dY=; b=u13ingshmYz1ND OhGKsO3c1bxIOqt4Nm/uaWkkFRKVcHEvx/rrFNhFSf2Hb7s4LblfD/Yg+Uk+vQ1tu4Y2jZyh0r09y NkDlXqnFwalw+ngGVlF9dtl8hNzRtDl5V1hkcwTY71hRyf2kKXHKVMH0YHq2n4iFU7/woEA4Hq4a6 jK0TGSkFF3hwTAVVIqrc+n+KdWksr04mOZWjoFiJcWkX/W/cJfdMezD60ITZb4OwXG/KiLK/7BS0d WCDTy3VoVcXRDZVCxcliU8dRg1dkWa3M0SxsnL8x1TDc6JJYtpSU2ABrmI9KhGJ3iIUTA5+Dl2pM7 wHR+rtfBe0BEC7kqWp7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxS71-000Ogd-2D; Wed, 15 Dec 2021 11:06:19 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxS2N-000MDb-Si for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 11:01:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639566092; x=1671102092; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FJoZ3/X+f//Ot1xushVx/AGt8XPLPpyGKxiMYuKplkY=; b=VQvUHOx5hKGPjbiHvkG1SztRm5PX9BGpgexUKmzEpheSDJSd5hNkl9Nc VUlPlpOwxHXBIHhXGeAKlT67QT2mH9JzQvuL/24frhAtZBq4gumxNIdhb 1OiKU5AEC66VnzOpYOWE3nj856DWlVbYMhUGWFsgQd23HbP+x1z1ntyck yzgtspGRxaohpC+3TcJPmf5ddQAww5LgAix/th4PMYpdXqDzkb7K44tSe uuuGXkW8KnArOf+mlRrimx8nuY4CYuG4pdz+0HXZfFVSF7RFRSwJby6VY K2pzFkCIUsjVTQk9CruUEKC1CD5cq+xWH6wQEZTCylmyrjiuo1N6l6rPR A==; IronPort-SDR: 24p0OL/8SfbTQ6kN8CmBXbEEVngV9Osvo3Uv1duiYezK5pv7arGf1cUL96S0edQE4+rGr3srVR 3OvYEQnhfi+pjwoEvD68U/xbR/E/IfoIYzhXbzSzVrJpl2IpoLrjXk28XA/Sme2R4rZXxf7kDj yZ+eij7TsRxr0HMwS/hgcZ3ItTD6jA2Cu8lRlETil4V31kVSBJnVn7pMpwqWemjrYHma1oHXCs olq4Zl8413xYqc7LkHWDz5KMWmf+srwLnRpsz4mmMsW92LaDNSnrTawdMutV/jSVbJdGDUKAjd zeB7zto0Te1izo6CYDef5WQm X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="142483350" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Dec 2021 04:01:26 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 15 Dec 2021 04:01:25 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 15 Dec 2021 04:01:23 -0700 From: Tudor Ambarus To: Subject: [PATCH v3 02/12] dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending Date: Wed, 15 Dec 2021 13:01:05 +0200 Message-ID: <20211215110115.191749-3-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211215110115.191749-1-tudor.ambarus@microchip.com> References: <20211215110115.191749-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_030132_063491_417B22FF X-CRM114-Status: UNSURE ( 8.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , mripard@kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Cyclic channels must too call issue_pending in order to start a transfer. Start the transfer in issue_pending regardless of the type of channel. This wrongly worked before, because in the past the transfer was started at tx_submit level when only a desc in the transfer list. Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Signed-off-by: Tudor Ambarus --- drivers/dma/at_xdmac.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4ff12b083136..c3d3e1270236 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1778,11 +1778,9 @@ static void at_xdmac_issue_pending(struct dma_chan *chan) dev_dbg(chan2dev(&atchan->chan), "%s\n", __func__); - if (!at_xdmac_chan_is_cyclic(atchan)) { - spin_lock_irqsave(&atchan->lock, flags); - at_xdmac_advance_work(atchan); - spin_unlock_irqrestore(&atchan->lock, flags); - } + spin_lock_irqsave(&atchan->lock, flags); + at_xdmac_advance_work(atchan); + spin_unlock_irqrestore(&atchan->lock, flags); return; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel