From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============9203657444224405259==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Fri, 17 Dec 2021 12:00:04 +0800 Message-ID: <20211217040004.GA515@7d09c1521fa9> List-Id: To: kbuild@lists.01.org --===============9203657444224405259== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Wolfgang Grandegger CC: "Marc Kleine-Budde" CC: Jakub Kicinski CC: Vincent Mailhol CC: linux-can(a)vger.kernel.org CC: netdev(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/net/can/spi/hi311x.c:759:7-27: WARNING: Threaded IRQ with no primar= y handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: a52a8e9eaf4a12dd58953fc622bb2bc08fd1d32c commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 8 hours ago :::::: commit date: 8 months ago Please take the patch only if it's a positive warning. Thanks! hi311x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/spi/hi311x.c +++ b/drivers/net/can/spi/hi311x.c @@ -757,7 +757,7 @@ static int hi3110_open(struct net_device priv->tx_len =3D 0; = ret =3D request_threaded_irq(spi->irq, NULL, hi3110_can_ist, - flags, DEVICE_NAME, priv); + flags | IRQF_ONESHOT, DEVICE_NAME, priv); if (ret) { dev_err(&spi->dev, "failed to acquire irq %d\n", spi->irq); goto out_close; --===============9203657444224405259==--