From: Yaqin Pan <akingchen@vivo.com>
To: robh@kernel.org
Cc: akingchen@vivo.com, balbi@kernel.org, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, kernel@vivo.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
s.shtylyov@omp.ru
Subject: Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split_quirk property in dwc3
Date: Fri, 17 Dec 2021 22:47:09 +0800 [thread overview]
Message-ID: <20211217144709.7194-1-akingchen@vivo.com> (raw)
In-Reply-To: <YbufNsBtiIzbm+9k@robh.at.kernel.org>
>> >> Add snps,dis_split_quirk property for dwc3 controller
>> >>
>> >> Signed-off-by: Yaqin Pan <akingchen@vivo.com>
>> >> ---
>> >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
>> >> 1 file changed, 6 insertions(+)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> >> index 41416fbd92aa..e9615ca8f447 100644
>> >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> >> @@ -226,6 +226,12 @@ properties:
>> >> avoid -EPROTO errors with usbhid on some devices (Hikey 970).
>> >> type: boolean
>> >> + snps,dis_split_quirk:
>
>I'm tired of the never ending DWC3 quirks. Imply this from the
>compatible unless it varies by board.
Yes, this is a DWC3 controller compatible issue.
>
>Also, don't use '_' in DT names.
Sure, i will change "snps,dis_split_quirk" to "snps,dis-split-quirk".
>
>> >> + description:
>> >> + When set, change the way host controller schedules transations for a Control transfer.
>> >
>> > Transactions.
>> >
>> >> + Needed to avoid emurate some devices fail.
>> >
>> > Avoid failing to enumerating some devices?
Yes. Avoid failing to enumerate some devices.
>>
>> Sorry. enumarate. :-)
> Or enumerate
prev parent reply other threads:[~2021-12-17 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 13:03 [PATCH 0/2] usb: dwc3: Add a quirk to set GUCTL.SPRSCTRLTRANSEN bit Yaqin Pan
2021-12-15 13:03 ` [PATCH 1/2] " Yaqin Pan
2021-12-15 13:03 ` [PATCH 2/2] dt-bindings: usb: document snps,dis_split_quirk property in dwc3 Yaqin Pan
2021-12-16 8:26 ` Sergey Shtylyov
2021-12-16 15:59 ` Sergey Shtylyov
2021-12-16 20:19 ` Rob Herring
2021-12-17 14:45 ` Yaqin Pan
2022-01-05 16:47 ` Rob Herring
2021-12-17 14:47 ` Yaqin Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217144709.7194-1-akingchen@vivo.com \
--to=akingchen@vivo.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.