All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>,
	Christian Melki <christian.melki@t2data.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Bin Meng <bmeng.cn@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Simon Glass <sjg@chromium.org>, Alexander Graf <agraf@csgraf.de>
Subject: [PATCH v7 07/24] efi: Add comments to struct efi_priv
Date: Sat, 18 Dec 2021 11:28:33 -0700	[thread overview]
Message-ID: <20211218182850.1121923-7-sjg@chromium.org> (raw)
In-Reply-To: <20211218182850.1121923-1-sjg@chromium.org>

This structure is uncommented. Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v3)

Changes in v3:
- Drop comments that confuse sphinx
- Move device_path path change to its own patch

 include/efi.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/include/efi.h b/include/efi.h
index 77e599c256e..6622a733e6e 100644
--- a/include/efi.h
+++ b/include/efi.h
@@ -400,14 +400,37 @@ static inline struct efi_mem_desc *efi_get_next_mem_desc(
 	return (struct efi_mem_desc *)((ulong)desc + map->desc_size);
 }
 
+/**
+ * struct efi_priv - Information about the environment provided by EFI
+ *
+ * @parent_image: image passed into the EFI app or stub
+ * @sys_table: Pointer to system table
+ * @boot: Pointer to boot-services table
+ * @run: Pointer to runtime-services table
+ *
+ * @use_pool_for_malloc: true if all allocation should go through the EFI 'pool'
+ *	methods allocate_pool() and free_pool(); false to use 'pages' methods
+ *	allocate_pages() and free_pages()
+ * @ram_base: Base address of RAM (size CONFIG_EFI_RAM_SIZE)
+ * @image_data_type: Type of the loaded image (e.g. EFI_LOADER_CODE)
+ *
+ * @info: Header of the info list, holding info collected by the stub and passed
+ *	to U-Boot
+ * @info_size: Size of the info list, in bytes from @info
+ * @next_hdr: Pointer to where to put the next header when adding to the list
+ */
 struct efi_priv {
 	efi_handle_t parent_image;
 	struct efi_system_table *sys_table;
 	struct efi_boot_services *boot;
 	struct efi_runtime_services *run;
+
+	/* app: */
 	bool use_pool_for_malloc;
 	unsigned long ram_base;
 	unsigned int image_data_type;
+
+	/* stub: */
 	struct efi_info_hdr *info;
 	unsigned int info_size;
 	void *next_hdr;
-- 
2.34.1.173.g76aa8bc2d0-goog


  parent reply	other threads:[~2021-12-18 18:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18 18:28 [PATCH v7 00/24] efi: Improvements to U-Boot running on top of UEFI Simon Glass
2021-12-18 18:28 ` [PATCH v7 01/24] efi: Locate all block devices in the app Simon Glass
2021-12-20 10:51   ` Heinrich Schuchardt
2021-12-18 18:28 ` [PATCH v7 02/24] efi: serial: Support arrow keys Simon Glass
2021-12-18 18:28 ` [PATCH v7 03/24] x86: Allow booting a kernel from the EFI app Simon Glass
2021-12-18 18:28 ` [PATCH v7 04/24] x86: Don't process the kernel command line unless enabled Simon Glass
2021-12-21  7:32   ` Heinrich Schuchardt
2021-12-29 13:36     ` Simon Glass
2021-12-29 13:45       ` Tom Rini
2021-12-30  6:03         ` Simon Glass
2021-12-18 18:28 ` [PATCH v7 05/24] x86: efi: Add room for the binman definition in the dtb Simon Glass
2021-12-18 18:28 ` [PATCH v7 06/24] efi: Drop device_path from struct efi_priv Simon Glass
2021-12-18 18:28 ` Simon Glass [this message]
2021-12-18 18:28 ` [PATCH v7 08/24] efi: Fix ll_boot_init() operation with the app Simon Glass
2021-12-21  8:20   ` Heinrich Schuchardt
2021-12-18 18:28 ` [PATCH v7 09/24] efi: Add a few comments to the stub Simon Glass
2021-12-21  8:23   ` Heinrich Schuchardt
2021-12-18 18:28 ` [PATCH v7 10/24] efi: Share struct efi_priv between the app and stub code Simon Glass
2021-12-18 18:28 ` [PATCH v7 11/24] efi: Move exit_boot_services into a function Simon Glass
2021-12-18 18:28 ` [PATCH v7 12/24] efi: Check for failure when initing the app Simon Glass
2021-12-18 18:28 ` [PATCH v7 13/24] efi: Mention that efi_info_get() is only used in the stub Simon Glass
2021-12-18 18:28 ` [PATCH v7 14/24] efi: Show when allocated pages are used Simon Glass
2021-12-18 18:28 ` [PATCH v7 15/24] efi: Allow easy selection of serial-only operation Simon Glass
2021-12-18 18:28 ` [PATCH v7 16/24] x86: efi: Update efi_get_next_mem_desc() to avoid needing a map Simon Glass
2021-12-18 18:28 ` [PATCH v7 17/24] efi: Support the efi command in the app Simon Glass
2021-12-18 18:28 ` [PATCH v7 18/24] x86: efi: Show the system-table revision Simon Glass
2021-12-18 18:28 ` [PATCH v7 19/24] x86: efi: Don't set up global_data again with EFI Simon Glass
2021-12-18 18:28 ` [PATCH v7 21/24] x86: efi: Round out the link script for 64-bit EFI Simon Glass
2021-12-18 18:28 ` [PATCH v7 22/24] x86: efi: Don't use the 64-bit link script for the EFI app Simon Glass
2021-12-18 18:28 ` [PATCH v7 23/24] x86: efi: Set the correct link flags for the 64-bit " Simon Glass
2021-12-18 18:28 ` [PATCH v7 24/24] efi: Build the 64-bit app properly Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211218182850.1121923-7-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=agraf@csgraf.de \
    --cc=bmeng.cn@gmail.com \
    --cc=christian.melki@t2data.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.