From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12B79C433EF for ; Mon, 20 Dec 2021 05:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234127AbhLTFnj (ORCPT ); Mon, 20 Dec 2021 00:43:39 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:55193 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbhLTFni (ORCPT ); Mon, 20 Dec 2021 00:43:38 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0V.5MXam_1639979015; Received: from localhost(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0V.5MXam_1639979015) by smtp.aliyun-inc.com(127.0.0.1); Mon, 20 Dec 2021 13:43:36 +0800 From: Xianting Tian To: kraxel@redhat.com, sumit.semwal@linaro.org, christian.koenig@amd.com Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Xianting Tian Subject: [PATCH] udmabuf: put dmabuf in case of get fd failed Date: Mon, 20 Dec 2021 13:43:33 +0800 Message-Id: <20211220054333.3041893-1-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It needs call dma_buf_put() to put dmabuf in case of getting fd failed. Signed-off-by: Xianting Tian --- drivers/dma-buf/udmabuf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c57a609db..d77f96995 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -274,8 +274,11 @@ static long udmabuf_create(struct miscdevice *device, flags = 0; if (head->flags & UDMABUF_FLAGS_CLOEXEC) flags |= O_CLOEXEC; - return dma_buf_fd(buf, flags); + ret = dma_buf_fd(buf, flags); + if (ret < 0) { + dma_buf_put(buf); + return ret; err: while (pgbuf > 0) put_page(ubuf->pages[--pgbuf]); -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E909C433F5 for ; Mon, 20 Dec 2021 08:57:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C6F211329C; Mon, 20 Dec 2021 08:57:57 +0000 (UTC) X-Greylist: delayed 302 seconds by postgrey-1.36 at gabe; Mon, 20 Dec 2021 05:48:42 UTC Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC3F710E458 for ; Mon, 20 Dec 2021 05:48:42 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04426; MF=xianting.tian@linux.alibaba.com; NM=1; PH=DS; RN=8; SR=0; TI=SMTPD_---0V.5MXam_1639979015; Received: from localhost(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0V.5MXam_1639979015) by smtp.aliyun-inc.com(127.0.0.1); Mon, 20 Dec 2021 13:43:36 +0800 From: Xianting Tian To: kraxel@redhat.com, sumit.semwal@linaro.org, christian.koenig@amd.com Subject: [PATCH] udmabuf: put dmabuf in case of get fd failed Date: Mon, 20 Dec 2021 13:43:33 +0800 Message-Id: <20211220054333.3041893-1-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Mon, 20 Dec 2021 08:57:56 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linaro-mm-sig@lists.linaro.org, Xianting Tian , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It needs call dma_buf_put() to put dmabuf in case of getting fd failed. Signed-off-by: Xianting Tian --- drivers/dma-buf/udmabuf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c57a609db..d77f96995 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -274,8 +274,11 @@ static long udmabuf_create(struct miscdevice *device, flags = 0; if (head->flags & UDMABUF_FLAGS_CLOEXEC) flags |= O_CLOEXEC; - return dma_buf_fd(buf, flags); + ret = dma_buf_fd(buf, flags); + if (ret < 0) { + dma_buf_put(buf); + return ret; err: while (pgbuf > 0) put_page(ubuf->pages[--pgbuf]); -- 2.17.1