All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Antony Antony <antony.antony@secunet.com>
Cc: Eyal Birger <eyal.birger@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 ipsec-next 2/2] xfrm: state and policy should fail if XFRMA_IF_ID 0
Date: Mon, 20 Dec 2021 09:36:01 +0100	[thread overview]
Message-ID: <20211220083601.GO427717@gauss3.secunet.de> (raw)
In-Reply-To: <750d7eeedf4767485fa616a245e1f1cf0881cbfe.1639304726.git.antony.antony@secunet.com>

On Sun, Dec 12, 2021 at 11:35:00AM +0100, Antony Antony wrote:
> xfrm ineterface does not allow xfrm if_id = 0
> fail to create or update xfrm state and policy.
> 
> With this commit:
>  ip xfrm policy add src 192.0.2.1 dst 192.0.2.2 dir out if_id 0
>  RTNETLINK answers: Invalid argument
> 
>  ip xfrm state add src 192.0.2.1 dst 192.0.2.2 proto esp spi 1 \
>             reqid 1 mode tunnel aead 'rfc4106(gcm(aes))' \
>             0x1111111111111111111111111111111111111111 96 if_id 0
>  RTNETLINK answers: Invalid argument
> 
> v1->v2 change:
>  - add Fixes: tag
> 
> Fixes: 9f8550e4bd9d ("xfrm: fix disable_xfrm sysctl when used on xfrm interfaces")
> Signed-off-by: Antony Antony <antony.antony@secunet.com>

Also applied to the ipsec tree, thanks a lot!

      reply	other threads:[~2021-12-20  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 15:35 [PATCH 1/2] xfrm: interface with if_id 0 should return error Antony Antony
2021-12-10 17:22 ` Eyal Birger
2021-12-12 10:33   ` Antony Antony
2021-12-12 10:34 ` [PATCH v2 ipsec-next " Antony Antony
2021-12-20  8:35   ` Steffen Klassert
2021-12-12 10:35 ` [PATCH v2 ipsec-next 2/2] xfrm: state and policy should fail if XFRMA_IF_ID 0 Antony Antony
2021-12-20  8:36   ` Steffen Klassert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211220083601.GO427717@gauss3.secunet.de \
    --to=steffen.klassert@secunet.com \
    --cc=antony.antony@secunet.com \
    --cc=davem@davemloft.net \
    --cc=eyal.birger@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.