All of
 help / color / mirror / Atom feed
From: Johannes Berg <>
Cc: Johannes Berg <>,,
Subject: [PATCH net] mac80211: fix locking in ieee80211_start_ap error path
Date: Mon, 20 Dec 2021 10:22:40 +0100	[thread overview]
Message-ID: <> (raw)

From: Johannes Berg <>

We need to hold the local->mtx to release the channel context,
as even encoded by the lockdep_assert_held() there. Fix it.

Fixes: 295b02c4be74 ("mac80211: Add FILS discovery support")
Signed-off-by: Johannes Berg <>
Jakub/Dave, could you please apply this directly? I have no
other things pending for net at the moment. Thanks!
 net/mac80211/cfg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index bd3d3195097f..2d0dd69f9753 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1264,7 +1264,10 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
 	return 0;
+	mutex_lock(&local->mtx);
+	mutex_unlock(&local->mtx);
 	return err;

             reply	other threads:[~2021-12-20  9:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  9:22 Johannes Berg [this message]
2021-12-20 11:40 ` [PATCH net] mac80211: fix locking in ieee80211_start_ap error path patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.