From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mzRGo-0008E1-Gp
	for mharc-grub-devel@gnu.org; Mon, 20 Dec 2021 17:36:38 -0500
Received: from eggs.gnu.org ([209.51.188.92]:41302)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1mzRGk-00085U-Iv
 for grub-devel@gnu.org; Mon, 20 Dec 2021 17:36:35 -0500
Received: from dibed.net-space.pl ([84.10.22.86]:55651)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1mzRGj-0003ZD-0P
 for grub-devel@gnu.org; Mon, 20 Dec 2021 17:36:34 -0500
Received: from router-fw.i.net-space.pl ([192.168.52.1]:60136 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S2100469AbhLTWg2 (ORCPT <rfc822;grub-devel@gnu.org>);
 Mon, 20 Dec 2021 23:36:28 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Mon, 20 Dec 2021 23:36:26 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org, Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>,
 Patrick Steinhardt <ps@pks.im>,
 James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v5 8/9] cryptodisk: Move global variables into
 grub_cryptomount_args struct
Message-ID: <20211220223626.aorh2prf3svd4u65@tomti.i.net-space.pl>
References: <cover.1639069499.git.development@efficientek.com>
 <33385f215866af1105dd9e6723e1c7bf03ee9a07.1639069499.git.development@efficientek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33385f215866af1105dd9e6723e1c7bf03ee9a07.1639069499.git.development@efficientek.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl;
 helo=dibed.net-space.pl
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Dec 2021 22:36:35 -0000

On Thu, Dec 09, 2021 at 11:14:57AM -0600, Glenn Washburn wrote:
> Note that cargs.search_uuid does not need to be initialized in various parts
> of the cryptomount argument parsing, just once when cargs is declared with a
> struct initializer. The previous code used a global variable which would
> retain the value across cryptomount invocations.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel