From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF63173 for ; Mon, 20 Dec 2021 18:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640024120; x=1671560120; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xn3SfHAVBBxgPNY/hfMHHIDWLipvyx6cHeleLt7x/qI=; b=mWHLqqcb33wXqp1uArWrCe/8RGQ/DUQiE+pNnGIOIqSxeSOMhUZaM5Mg bO6je565QjYyw7wy5n0rwUcDVvxGISrIay6tmDXVj+AGGB2j35szQ6DlK EqB6QMb/7abPyFcGVOSh8+HSOlCBPX8VGw8BfmKSWyekeGDuCtkndHwFJ LhhmCTs2zXMFV1keWzA4V/LpYStSyVYcTnKM9HEBbRG+QzZk7vLvq3SdY anZ5VidgXThUB7OJCstJFooYt8pXDpqAyAPq5uCPKb8i8zPJPkXLWmRRp nh2xWRwZt4so8+G04H4W4sTGKEq+IQAwzyBA4ZNbBtbWyBldIbXrwOEBq g==; X-IronPort-AV: E=McAfee;i="6200,9189,10203"; a="240051217" X-IronPort-AV: E=Sophos;i="5.88,221,1635231600"; d="scan'208";a="240051217" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2021 10:15:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,221,1635231600"; d="scan'208";a="684370606" Received: from lkp-server02.sh.intel.com (HELO 9f38c0981d9f) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 20 Dec 2021 10:15:15 -0800 Received: from kbuild by 9f38c0981d9f with local (Exim 4.92) (envelope-from ) id 1mzNBr-00085W-6H; Mon, 20 Dec 2021 18:15:15 +0000 Date: Tue, 21 Dec 2021 02:14:14 +0800 From: kernel test robot To: Wander Lairson Costa , linux-kernel@vger.kernel.org, Jens Axboe , Steven Rostedt , Ingo Molnar , linux-block@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Thomas Gleixner , Sebastian Andrzej Siewior , Wander Lairson Costa Subject: Re: [PATCH v4 1/1] blktrace: switch trace spinlock to a raw spinlock Message-ID: <202112210258.y6u1AZpZ-lkp@intel.com> References: <20211220130357.8790-2-wander@redhat.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211220130357.8790-2-wander@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Wander, Thank you for the patch! Yet something to improve: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on linux/master linus/master v5.16-rc6 next-20211220] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Wander-Lairson-Costa/blktrace-switch-trace-spinlock-to-a-raw-spinlock/20211220-210538 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: hexagon-randconfig-r045-20211220 (https://download.01.org/0day-ci/archive/20211221/202112210258.y6u1AZpZ-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 555eacf75f21cd1dfc6363d73ad187b730349543) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b270731108ecba0d77a6db93d057290406c51a20 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Wander-Lairson-Costa/blktrace-switch-trace-spinlock-to-a-raw-spinlock/20211220-210538 git checkout b270731108ecba0d77a6db93d057290406c51a20 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/ kernel/trace/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/trace/blktrace.c:148:63: warning: parameter 'blkcg' set but not used [-Wunused-but-set-parameter] void __trace_note_message(struct blk_trace *bt, struct blkcg *blkcg, ^ >> kernel/trace/blktrace.c:1611:17: error: incompatible pointer types passing 'raw_spinlock_t *' (aka 'struct raw_spinlock *') to parameter of type 'spinlock_t *' (aka 'struct spinlock *') [-Werror,-Wincompatible-pointer-types] spin_lock_irq(&running_trace_lock); ^~~~~~~~~~~~~~~~~~~ include/linux/spinlock.h:372:55: note: passing argument to parameter 'lock' here static __always_inline void spin_lock_irq(spinlock_t *lock) ^ kernel/trace/blktrace.c:1613:19: error: incompatible pointer types passing 'raw_spinlock_t *' (aka 'struct raw_spinlock *') to parameter of type 'spinlock_t *' (aka 'struct spinlock *') [-Werror,-Wincompatible-pointer-types] spin_unlock_irq(&running_trace_lock); ^~~~~~~~~~~~~~~~~~~ include/linux/spinlock.h:397:57: note: passing argument to parameter 'lock' here static __always_inline void spin_unlock_irq(spinlock_t *lock) ^ 1 warning and 2 errors generated. vim +1611 kernel/trace/blktrace.c c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1599 c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1600 static int blk_trace_remove_queue(struct request_queue *q) c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1601 { c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1602 struct blk_trace *bt; c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1603 c3dbe541ef7775 kernel/trace/blktrace.c Jan Kara 2020-06-05 1604 bt = rcu_replace_pointer(q->blk_trace, NULL, 85e0cbbb8a7953 kernel/trace/blktrace.c Luis Chamberlain 2020-06-19 1605 lockdep_is_held(&q->debugfs_mutex)); c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1606 if (bt == NULL) c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1607 return -EINVAL; c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1608 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1609 if (bt->trace_state == Blktrace_running) { 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1610 bt->trace_state = Blktrace_stopped; 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 @1611 spin_lock_irq(&running_trace_lock); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1612 list_del_init(&bt->running_list); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1613 spin_unlock_irq(&running_trace_lock); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1614 relay_flush(bt->rchan); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1615 } 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1616 a6da0024ffc19e kernel/trace/blktrace.c Jens Axboe 2017-11-05 1617 put_probe_ref(); c780e86dd48ef6 kernel/trace/blktrace.c Jan Kara 2020-02-06 1618 synchronize_rcu(); ad5dd5493a55e4 kernel/trace/blktrace.c Li Zefan 2009-03-27 1619 blk_trace_free(bt); c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1620 return 0; c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1621 } c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1622 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5131242725531562078==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 1/1] blktrace: switch trace spinlock to a raw spinlock Date: Tue, 21 Dec 2021 02:14:14 +0800 Message-ID: <202112210258.y6u1AZpZ-lkp@intel.com> In-Reply-To: <20211220130357.8790-2-wander@redhat.com> List-Id: --===============5131242725531562078== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Wander, Thank you for the patch! Yet something to improve: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on linux/master linus/master v5.16-rc6 next-20211220] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Wander-Lairson-Costa/blktr= ace-switch-trace-spinlock-to-a-raw-spinlock/20211220-210538 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.g= it for-next config: hexagon-randconfig-r045-20211220 (https://download.01.org/0day-ci/a= rchive/20211221/202112210258.y6u1AZpZ-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 555eac= f75f21cd1dfc6363d73ad187b730349543) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b270731108ecba0d77a6db93d= 057290406c51a20 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Wander-Lairson-Costa/blktrace-swit= ch-trace-spinlock-to-a-raw-spinlock/20211220-210538 git checkout b270731108ecba0d77a6db93d057290406c51a20 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Dhexagon SHELL=3D/bin/bash drivers/gpu/drm/ kernel/tr= ace/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/trace/blktrace.c:148:63: warning: parameter 'blkcg' set but not u= sed [-Wunused-but-set-parameter] void __trace_note_message(struct blk_trace *bt, struct blkcg *blkcg, ^ >> kernel/trace/blktrace.c:1611:17: error: incompatible pointer types passi= ng 'raw_spinlock_t *' (aka 'struct raw_spinlock *') to parameter of type 's= pinlock_t *' (aka 'struct spinlock *') [-Werror,-Wincompatible-pointer-type= s] spin_lock_irq(&running_trace_lock); ^~~~~~~~~~~~~~~~~~~ include/linux/spinlock.h:372:55: note: passing argument to parameter 'lo= ck' here static __always_inline void spin_lock_irq(spinlock_t *lock) ^ kernel/trace/blktrace.c:1613:19: error: incompatible pointer types passi= ng 'raw_spinlock_t *' (aka 'struct raw_spinlock *') to parameter of type 's= pinlock_t *' (aka 'struct spinlock *') [-Werror,-Wincompatible-pointer-type= s] spin_unlock_irq(&running_trace_lock); ^~~~~~~~~~~~~~~~~~~ include/linux/spinlock.h:397:57: note: passing argument to parameter 'lo= ck' here static __always_inline void spin_unlock_irq(spinlock_t *lock) ^ 1 warning and 2 errors generated. vim +1611 kernel/trace/blktrace.c c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1599 = c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1600 static int blk_trace_remove_queue(struct request_queue *q) c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1601 { c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1602 struct blk_trace *bt; c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1603 = c3dbe541ef7775 kernel/trace/blktrace.c Jan Kara 2020-06-05 = 1604 bt =3D rcu_replace_pointer(q->blk_trace, NULL, 85e0cbbb8a7953 kernel/trace/blktrace.c Luis Chamberlain 2020-06-19 = 1605 lockdep_is_held(&q->debugfs_mutex)); c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1606 if (bt =3D=3D NULL) c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1607 return -EINVAL; c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1608 = 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1609 if (bt->trace_state =3D=3D Blktrace_running) { 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1610 bt->trace_state =3D Blktrace_stopped; 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = @1611 spin_lock_irq(&running_trace_lock); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1612 list_del_init(&bt->running_list); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1613 spin_unlock_irq(&running_trace_lock); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1614 relay_flush(bt->rchan); 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1615 } 5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 = 1616 = a6da0024ffc19e kernel/trace/blktrace.c Jens Axboe 2017-11-05 = 1617 put_probe_ref(); c780e86dd48ef6 kernel/trace/blktrace.c Jan Kara 2020-02-06 = 1618 synchronize_rcu(); ad5dd5493a55e4 kernel/trace/blktrace.c Li Zefan 2009-03-27 = 1619 blk_trace_free(bt); c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1620 return 0; c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1621 } c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 = 1622 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5131242725531562078==--