Re: [PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC

From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Stefan Agner <stefan@agner.ch>,
	Sascha Hauer <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC
Date: Tue, 21 Dec 2021 07:56:57 +0100	[thread overview]
Message-ID: <20211221075657.2a6eba77@ipc1.ka-ro> (raw)
In-Reply-To: <CAOMZO5DKALxOHHMWWuHA8ciOSm-9z9WB=Mooz2Vom9La7=1Esw@mail.gmail.com>

Fabio Estevam <festevam@gmail.com> wrote:

> [Adding Lothar on Cc]
> 
> On Mon, Dec 20, 2021 at 10:43 AM Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The "mxim" vendor prefix does not exit, though it looks like it might
> > have been a typo'ed "maxim". Still, no compatible string exists that
> > matches "maxim,ds1339". The closest is the "dallas,ds1339" and since
> > this node is named "rtc" that's probably the one that was intended.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  arch/arm/boot/dts/imx28-tx28.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > index 164254c28f8e..a1fd508ee425 100644
> > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > @@ -356,7 +356,7 @@ touchscreen: tsc2007@48 {
> >         };
> >
> >         ds1339: rtc@68 {
> > -               compatible = "mxim,ds1339";
> > +               compatible = "dallas,ds1339";  
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Lothar Waßmann <LW@KARO-electronics.de>

-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel