From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1390FC433EF for ; Tue, 21 Dec 2021 20:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234020AbhLUUXm (ORCPT ); Tue, 21 Dec 2021 15:23:42 -0500 Received: from foss.arm.com ([217.140.110.172]:60078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbhLUUXl (ORCPT ); Tue, 21 Dec 2021 15:23:41 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA8A2ED1; Tue, 21 Dec 2021 12:23:40 -0800 (PST) Received: from bogus (unknown [10.57.36.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 185D33F718; Tue, 21 Dec 2021 12:23:38 -0800 (PST) Date: Tue, 21 Dec 2021 20:23:36 +0000 From: Sudeep Holla To: Pratyush Yadav Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, Sudeep Holla , vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v8 01/11] firmware: arm_scmi: Add configurable polling mode for transports Message-ID: <20211221202336.ebkpfoernygotepp@bogus> References: <20211220195646.44498-1-cristian.marussi@arm.com> <20211220195646.44498-2-cristian.marussi@arm.com> <20211221193852.pmb4nu43zzu6trqt@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211221193852.pmb4nu43zzu6trqt@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 22, 2021 at 01:08:54AM +0530, Pratyush Yadav wrote: > Hi, > > On 20/12/21 07:56PM, Cristian Marussi wrote: > > SCMI communications along TX channels can optionally be provided of a > > completion interrupt; when such interrupt is not available, command > > transactions should rely on polling, where the SCMI core takes care to > > repeatedly evaluate the transport-specific .poll_done() function, if > > available, to determine if and when a request was fully completed or > > timed out. > > > > Such mechanism is already present and working on a single transfer base: > > SCMI protocols can indeed enable hdr.poll_completion on specific commands > > ahead of each transfer and cause that transaction to be handled with > > polling. > > > > Introduce a couple of flags to be able to enforce such polling behaviour > > globally at will: > > > > - scmi_desc.force_polling: to statically switch the whole transport to > > polling mode. > > > > - scmi_chan_info.no_completion_irq: to switch a single channel dynamically > > to polling mode if, at runtime, is determined that no completion > > interrupt was available for such channel. > > > > Signed-off-by: Cristian Marussi > > This patch breaks linux-next build for me with LLVM. > > drivers/firmware/arm_scmi/driver.c:869:6: error: variable 'i_' is uninitialized when used within its own initialization [-Werror,-Wuninitialized] > if (IS_POLLING_ENABLED(cinfo, info)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/firmware/arm_scmi/driver.c:59:33: note: expanded from macro 'IS_POLLING_ENABLED' > IS_TRANSPORT_POLLING_CAPABLE(i_)); \ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > drivers/firmware/arm_scmi/driver.c:45:19: note: expanded from macro 'IS_TRANSPORT_POLLING_CAPABLE' > typeof(__i) i_ = __i; \ > ~~ ^~~ > 1 error generated. > Thanks for the report. The bot complained last night and I have pushed the update though not in time for linux-next today, must make it to tomorrow's cut. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7A2DC433EF for ; Tue, 21 Dec 2021 20:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9GHiiGzxv2ktX8lewLUA+AXefrCxmvI22J4zKHo7/Mc=; b=O/+mlZjrNYp32m RsKW2uGyeY3mLW5vuxfBEff0oaZVwRLtE3wM494CHhLsBSYjG8guHCzk74VV9atTiuU4kC/EnBD+c pJrqjIGhNy/wwX/Z1OgS0iXEhFEzc9WjG9dtj8vVtPlNShfiWnU47x3/sgMflccEfeXZLcmLyQZXd izvKbi1FxykpXX7RtB4scm1nMHE1v9LzScnTgC6Izf2r+fNzbOexBq6FJn8oRNqoFV277ofBBSG96 D0vYLYyXVvKByzh6/8juSsqcDqJswYCwyG5qhfmtKttQqjWL8RoNclXHLqDUBMuolLg2of2QZWd26 fbLy5foxIwmovhTcQnmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzlfn-008NhV-VK; Tue, 21 Dec 2021 20:23:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzlfk-008Ng9-5T for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 20:23:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA8A2ED1; Tue, 21 Dec 2021 12:23:40 -0800 (PST) Received: from bogus (unknown [10.57.36.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 185D33F718; Tue, 21 Dec 2021 12:23:38 -0800 (PST) Date: Tue, 21 Dec 2021 20:23:36 +0000 From: Sudeep Holla To: Pratyush Yadav Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, Sudeep Holla , vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v8 01/11] firmware: arm_scmi: Add configurable polling mode for transports Message-ID: <20211221202336.ebkpfoernygotepp@bogus> References: <20211220195646.44498-1-cristian.marussi@arm.com> <20211220195646.44498-2-cristian.marussi@arm.com> <20211221193852.pmb4nu43zzu6trqt@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211221193852.pmb4nu43zzu6trqt@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_122344_302607_6E2CF1F7 X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 22, 2021 at 01:08:54AM +0530, Pratyush Yadav wrote: > Hi, > > On 20/12/21 07:56PM, Cristian Marussi wrote: > > SCMI communications along TX channels can optionally be provided of a > > completion interrupt; when such interrupt is not available, command > > transactions should rely on polling, where the SCMI core takes care to > > repeatedly evaluate the transport-specific .poll_done() function, if > > available, to determine if and when a request was fully completed or > > timed out. > > > > Such mechanism is already present and working on a single transfer base: > > SCMI protocols can indeed enable hdr.poll_completion on specific commands > > ahead of each transfer and cause that transaction to be handled with > > polling. > > > > Introduce a couple of flags to be able to enforce such polling behaviour > > globally at will: > > > > - scmi_desc.force_polling: to statically switch the whole transport to > > polling mode. > > > > - scmi_chan_info.no_completion_irq: to switch a single channel dynamically > > to polling mode if, at runtime, is determined that no completion > > interrupt was available for such channel. > > > > Signed-off-by: Cristian Marussi > > This patch breaks linux-next build for me with LLVM. > > drivers/firmware/arm_scmi/driver.c:869:6: error: variable 'i_' is uninitialized when used within its own initialization [-Werror,-Wuninitialized] > if (IS_POLLING_ENABLED(cinfo, info)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/firmware/arm_scmi/driver.c:59:33: note: expanded from macro 'IS_POLLING_ENABLED' > IS_TRANSPORT_POLLING_CAPABLE(i_)); \ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > drivers/firmware/arm_scmi/driver.c:45:19: note: expanded from macro 'IS_TRANSPORT_POLLING_CAPABLE' > typeof(__i) i_ = __i; \ > ~~ ^~~ > 1 error generated. > Thanks for the report. The bot complained last night and I have pushed the update though not in time for linux-next today, must make it to tomorrow's cut. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel