From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D34C433FE for ; Tue, 21 Dec 2021 23:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237354AbhLUXbh (ORCPT ); Tue, 21 Dec 2021 18:31:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236245AbhLUXbh (ORCPT ); Tue, 21 Dec 2021 18:31:37 -0500 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [IPv6:2001:4b7a:2000:18::171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D505EC06173F for ; Tue, 21 Dec 2021 15:31:36 -0800 (PST) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 646FD3F64B; Wed, 22 Dec 2021 00:31:32 +0100 (CET) Date: Wed, 22 Dec 2021 00:31:31 +0100 From: Marijn Suijten To: Lee Jones Cc: Daniel Thompson , phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: <20211221233131.rwjjojuawgffr2gf@SoMainline.org> Mail-Followup-To: Marijn Suijten , Lee Jones , Daniel Thompson , phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211116120213.n7qxqfi62lrxhyl7@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-11-16 15:42:15, Lee Jones wrote: > On Tue, 16 Nov 2021, Daniel Thompson wrote: > > > Hi Lee > > > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > > This patchset fixes WLED's handling of enabled-strings: besides some > > > cleanup it is now actually possible to specify a non-contiguous array of > > > enabled strings (not necessarily starting at zero) and the values from > > > DT are now validated to prevent possible unexpected out-of-bounds > > > register and array element accesses. > > > Off-by-one mistakes in the maximum number of strings, also causing > > > out-of-bounds access, have been addressed as well. > > > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > > the set should now have my R-b: attached to them. > > I can see that. Nothing for you to worry about. > > I'll apply these when I conduct my next sweep, thanks. Thanks for that Lee! Has the next sweep already passed by? Seems everyone is preparing for the 5.17 merge window but these patches haven't yet landed on the backlight tree [1]. I'd appreciate it if we can make them appear in the 5.17 window :) [1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/ Thanks! - Marijn > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B97D9C433F5 for ; Tue, 21 Dec 2021 23:31:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF36310E365; Tue, 21 Dec 2021 23:31:36 +0000 (UTC) Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [5.144.164.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB90210E365 for ; Tue, 21 Dec 2021 23:31:35 +0000 (UTC) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 646FD3F64B; Wed, 22 Dec 2021 00:31:32 +0100 (CET) Date: Wed, 22 Dec 2021 00:31:31 +0100 From: Marijn Suijten To: Lee Jones Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: <20211221233131.rwjjojuawgffr2gf@SoMainline.org> Mail-Followup-To: Marijn Suijten , Lee Jones , Daniel Thompson , phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211116120213.n7qxqfi62lrxhyl7@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Daniel Thompson , Kiran Gunda , Pavel Dubrova , Jami Kettunen , Jingoo Han , linux-arm-msm@vger.kernel.org, Bryan Wu , Konrad Dybcio , linux-kernel@vger.kernel.org, Rob Herring , Bjorn Andersson , Andy Gross , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, linux-fbdev@vger.kernel.org, AngeloGioacchino Del Regno , phone-devel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-11-16 15:42:15, Lee Jones wrote: > On Tue, 16 Nov 2021, Daniel Thompson wrote: > > > Hi Lee > > > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > > This patchset fixes WLED's handling of enabled-strings: besides some > > > cleanup it is now actually possible to specify a non-contiguous array of > > > enabled strings (not necessarily starting at zero) and the values from > > > DT are now validated to prevent possible unexpected out-of-bounds > > > register and array element accesses. > > > Off-by-one mistakes in the maximum number of strings, also causing > > > out-of-bounds access, have been addressed as well. > > > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > > the set should now have my R-b: attached to them. > > I can see that. Nothing for you to worry about. > > I'll apply these when I conduct my next sweep, thanks. Thanks for that Lee! Has the next sweep already passed by? Seems everyone is preparing for the 5.17 merge window but these patches haven't yet landed on the backlight tree [1]. I'd appreciate it if we can make them appear in the 5.17 window :) [1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/ Thanks! - Marijn > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog