From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"Chen, Mike Ximing" <mike.ximing.chen@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH v12 00/17] dlb: introduce DLB device driver
Date: Wed, 22 Dec 2021 09:01:01 +0100 [thread overview]
Message-ID: <20211222080101.GA21077@lst.de> (raw)
In-Reply-To: <CAPcyv4hoo=qBLC9d_VYHwCErE5ngsONgQPa45-K4c-GVfFJhsw@mail.gmail.com>
On Tue, Dec 21, 2021 at 10:44:11AM -0800, Dan Williams wrote:
> are likely FAQs with using configfs. Specifically the observation that
> configfs, like sysfs, lacks an "atomically update multiple attributes"
> capability. To my knowledge that's just the expected tradeoff with
> pseudo-fs based configuration and it is up to userspace to coordinate
> multiple configuration writers.
Yes. For the SCSI and nvme targets we do a required attributes must
be set before something can be enabled, but that might not work
everywhere.
> The other question is the use of anon_inode_getfd(). To me that
> mechanism is reserved for syscall and ioctl based architectures, and
It is.
> in this case it was only being used as a mechanism to get an automatic
> teardown action at process exit. Again, my inclination is that configs
> requires userspace to clean up anything it created. If "tear down on
> last close" behavior is needed that would either need to come from a
> userspace daemon to watch clients, or another character device that
> clients could open to represent the active users of the configuration.
> My preference is for the former.
This really sounds like configfs is the wrong interface. But I'd have
to find time to see what dlb actually is before commenting on what might
be a better interface.
next prev parent reply other threads:[~2021-12-22 8:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 6:50 [RFC PATCH v12 00/17] dlb: introduce DLB device driver Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver Mike Ximing Chen
2021-12-21 7:00 ` Joe Perches
2021-12-21 23:22 ` Chen, Mike Ximing
2021-12-22 2:02 ` Joe Perches
2021-12-21 7:12 ` Greg KH
2021-12-21 8:57 ` Greg KH
2021-12-21 14:25 ` Chen, Mike Ximing
2021-12-21 14:42 ` Chen, Mike Ximing
2021-12-21 15:02 ` Greg KH
2021-12-21 14:05 ` Chen, Mike Ximing
2021-12-21 9:53 ` Andrew Lunn
2021-12-21 20:56 ` Chen, Mike Ximing
2021-12-21 21:39 ` Andrew Lunn
2021-12-21 23:05 ` Chen, Mike Ximing
2021-12-22 21:26 ` Andrew Lunn
2021-12-23 5:15 ` Chen, Mike Ximing
2021-12-23 10:22 ` Andrew Lunn
2021-12-27 0:40 ` Chen, Mike Ximing
[not found] ` <20211222194746.3480dea8@hermes.local>
2021-12-23 5:39 ` Dan Williams
2021-12-21 6:50 ` [RFC PATCH v12 02/17] dlb: initialize DLB device Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 03/17] dlb: add resource and device initialization Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 04/17] dlb: add configfs interface and scheduling domain directory Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 05/17] dlb: add scheduling domain configuration Mike Ximing Chen
2021-12-21 12:18 ` kernel test robot
2021-12-21 6:50 ` [RFC PATCH v12 06/17] dlb: add domain software reset Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 07/17] dlb: add low-level register reset operations Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 08/17] dlb: add runtime power-management support Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 09/17] dlb: add queue create, reset, get-depth configfs interface Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 10/17] dlb: add register operations for queue management Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 11/17] dlb: add configfs interface to configure ports Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 12/17] dlb: add register operations for port management Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 13/17] dlb: add port mmap support Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 14/17] dlb: add start domain configfs attribute Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 15/17] dlb: add queue map, unmap, and pending unmap Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 16/17] dlb: add static queue map register operations Mike Ximing Chen
2021-12-21 6:50 ` [RFC PATCH v12 17/17] dlb: add basic sysfs interfaces Mike Ximing Chen
2021-12-21 7:20 ` Joe Perches
2021-12-21 23:18 ` Chen, Mike Ximing
2021-12-21 8:56 ` Greg KH
2021-12-21 14:07 ` Chen, Mike Ximing
2021-12-21 23:34 ` Stephen Hemminger
2021-12-22 4:21 ` Chen, Mike Ximing
2021-12-21 7:09 ` [RFC PATCH v12 00/17] dlb: introduce DLB device driver Greg KH
2021-12-21 14:03 ` Chen, Mike Ximing
2021-12-21 14:31 ` Greg KH
2021-12-21 18:44 ` Dan Williams
2021-12-21 19:57 ` Andrew Lunn
2021-12-22 8:01 ` Christoph Hellwig [this message]
2021-12-21 9:40 ` Andrew Lunn
2021-12-22 4:37 ` Chen, Mike Ximing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222080101.GA21077@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.ximing.chen@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.