From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32F50C433F5 for ; Wed, 22 Dec 2021 12:52:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 695E58303A; Wed, 22 Dec 2021 13:52:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CEFaRtNi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C2AF8302A; Wed, 22 Dec 2021 13:52:31 +0100 (CET) Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F58E8303A for ; Wed, 22 Dec 2021 13:52:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-il1-x12e.google.com with SMTP id e8so1669792ilm.13 for ; Wed, 22 Dec 2021 04:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dn1TnNcl1uCE2wBFEvkzJ/qa7hoNp088u6oPCTQEqWc=; b=CEFaRtNiic01d8BhHtDdUoHHU+GvgjnkPt/hMJL3XDIFJqnrd1ARmNqDbNyDyQlsjS mLo8A5YJBjlzYBAo9LsOc9FFsYl+9Jg6sVZRlltgE/BQhs97L6IJc9P0ZJ7D1TOTJP0k S4b34W7qDrN8sqRnnqYZq2Y2CVGlxFykXXygEh9zIXUYK1xwLmzBquQUu3CijdFtRFZf o5Gh+NVI/bnZZ2PUYOO10SFiuazLMBXcV27YlBXy6VZJgxU244wYzsPYxImackH0g8Gm q8JEoG/fvet6rBaUHuQI3eQ4LHhPl03ntvv2sDX9VJtl2VpAjTR9PxduPnJiVeCTu3ei U/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dn1TnNcl1uCE2wBFEvkzJ/qa7hoNp088u6oPCTQEqWc=; b=RMuRL/DwxIF2z5KsXBGKwXJijlulmPyjmNgZ9LgtSq0heWNENt8UXt4uTa0I1hEwx7 soXRlw3sY8/tirIyuSWzIbX1wGOT6fDQqWVmgmVpaibyuiXsRWkBevBIt3zzzgbWx20C RVtArsj7qcUgYG+Gb2mZZw54hOyljROuVbQ+Z/1iq9FBZnAtkWkYf0TxN8Osamn/EZYw 0yuCOHeZxCMBHeVwpSUpOwgNh1Jc/PRMVOeLDLVHLdjqo7x9ItML7ws7jtsCdG+ATMTT lbaiia2U2PGkQ9MekzjesPEUlThxw0MoFDgIri49GPBkwJFF+jQH5WvXXlJ4lQpdDzGT D8TA== X-Gm-Message-State: AOAM532cUh4Jzcv6gOne4kZ6iZomCC2jwm9aaUlxa1cuOml8lGiyI9BW F5UnQ/SvoBNTPI9wPEw+VGNHaSo712qilw== X-Google-Smtp-Source: ABdhPJzXr55NS5y7kHdMFf/aKBsqFUcaiEmyg2WOfZ55z2t4yq3wb4iLEeBSXq1rChFuCmxfp/cj0A== X-Received: by 2002:a92:6712:: with SMTP id b18mr1239535ilc.109.1640177546196; Wed, 22 Dec 2021 04:52:26 -0800 (PST) Received: from aford-IdeaCentre-A730.lan ([2601:448:8400:9e8:1a9c:8b48:18a7:5add]) by smtp.gmail.com with ESMTPSA id 18sm1005009iln.83.2021.12.22.04.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 04:52:25 -0800 (PST) From: Adam Ford To: u-boot@lists.denx.de Cc: marex@denx.de, festevam@denx.de, Adam Ford Subject: [PATCH] usb: ehci-mx6: Enable OTG detection on imx8mm and imx8mn Date: Wed, 22 Dec 2021 06:52:13 -0600 Message-Id: <20211222125213.124677-1-aford173@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The imx8mm and imx8mn appear compatible with imx7d-usb flags in the OTG driver. If the dr_mode is defined as host or peripheral, the device appears to operate correctly, however the auto host/peripheral detection results in an error. Simply adding checks in ehci_usb_phy_mode for 8mm and 8mn in ehci_usb_phy_mode is not enough, because ehci_usb_of_to_plat is run before the clock is enabled which results in a hang. Enable the USB clock in ehci_usb_of_to_plat and add checks in ehci_usb_phy_mode for 8mm and 8mn to enable auto detection of the OTG mode on i.MX8M Mini and Nano. Signed-off-by: Adam Ford diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c index 1bd6147c76..fa0798171b 100644 --- a/drivers/usb/host/ehci-mx6.c +++ b/drivers/usb/host/ehci-mx6.c @@ -543,7 +543,7 @@ static int ehci_usb_phy_mode(struct udevice *dev) plat->init_type = USB_INIT_DEVICE; else plat->init_type = USB_INIT_HOST; - } else if (is_mx7()) { + } else if (is_mx7() || is_imx8mm() || is_imx8mn()) { phy_status = (void __iomem *)(addr + USBNC_PHY_STATUS_OFFSET); val = readl(phy_status); @@ -561,11 +561,30 @@ static int ehci_usb_phy_mode(struct udevice *dev) static int ehci_usb_of_to_plat(struct udevice *dev) { +#if CONFIG_IS_ENABLED(CLK) + int ret = 0; + struct ehci_mx6_priv_data *priv = dev_get_priv(dev); + + ret = clk_get_by_index(dev, 0, &priv->clk); + if (ret < 0) + return ret; + + ret = clk_enable(&priv->clk); + if (ret) + return ret; +#endif + struct usb_plat *plat = dev_get_plat(dev); enum usb_dr_mode dr_mode; dr_mode = usb_get_dr_mode(dev_ofnode(dev)); +#if CONFIG_IS_ENABLED(CLK) + ret = clk_disable(&priv->clk); + if (ret) + return ret; +#endif + switch (dr_mode) { case USB_DR_MODE_HOST: plat->init_type = USB_INIT_HOST; -- 2.32.0