From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE70EC433EF for ; Wed, 22 Dec 2021 16:47:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 11CE683094; Wed, 22 Dec 2021 17:46:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="A3KS0bWF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F20528310B; Wed, 22 Dec 2021 17:46:56 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE6B78304D for ; Wed, 22 Dec 2021 17:46:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id a9so2797083qvd.12 for ; Wed, 22 Dec 2021 08:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xy5O3mHcgnyYjdDoWvDQFiEj8NNv8zZXV3X/ocmySms=; b=A3KS0bWFtJKPV0hu8I/wwRZbEK5epJP5Y2Yp9CwhzrgZMH041Hu0+Sr4nPyfJkZPEe kkSLcbl4gL27Y3hTqDedK869EMfkXQ3/uieDNuULwhXpkrTxSbYuvt0K3aYXGRsf+c4q lmz3ln+iGZYvvzruiRUFqz+Y8/JnIhRxQaFHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xy5O3mHcgnyYjdDoWvDQFiEj8NNv8zZXV3X/ocmySms=; b=MsoOA3iJ6Lot/8zHid80ceboI9jv7m5Mrs8pRxDwCJEaUGoxd1WEuqU0bvIacd3XAd hJjvSoHTb78O1bmib7N6d/qo15V+Xjh97qcFb7mgYW2YF8KWF2QxhtXX8cdX1FKSW6pI QHxbIs1WLgJEw/LqJfSj5np0ZDYSnavjFG4wyPcmutOZCA1916jRV4EGi1RGxEiBJGp9 MoZSg7KolJhxhKvxOCBOBVTng0ZIYea/N1Y0WyMsIntGzp/1fVSHfVVjBtnvVaHdbGpr fiRNY7Rg904wwvwJ0KGmRWBpL7xNnBVMUduy6iFAvJ/F69+sCsvWQv0lLE7VrAMF1E3y nIWA== X-Gm-Message-State: AOAM533OKFIfYQu0eJwKkdR0OfnpOEAkX2PrSPTPUL6awP6nOw+RP/VG p+UIKCBGhEzeJw6FS2UeNRGybQ== X-Google-Smtp-Source: ABdhPJzJPJp491Ebj7f8Dm0g32YQmGxRUDoGsiPrwvHEVLRvqS0qclnNroicT7Ml6LidnkKL3q8mQw== X-Received: by 2002:a05:6214:1c84:: with SMTP id ib4mr3238584qvb.76.1640191612372; Wed, 22 Dec 2021 08:46:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-d9c0-d76f-ebfe-a14d.res6.spectrum.com. [2603:6081:7b01:cbda:d9c0:d76f:ebfe:a14d]) by smtp.gmail.com with ESMTPSA id bj32sm2111739qkb.75.2021.12.22.08.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 08:46:51 -0800 (PST) Date: Wed, 22 Dec 2021 11:46:49 -0500 From: Tom Rini To: Lukasz Majewski Cc: u-boot@lists.denx.de, Stefano Babic Subject: Re: [PATCH v1 1/3] arm: xea: Modify board code to generate single binary u-boot Message-ID: <20211222164649.GO2773246@bill-the-cat> References: <20211222124904.2475-1-lukma@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="27KoNqt0fmcl1zj/" Content-Disposition: inline In-Reply-To: <20211222124904.2475-1-lukma@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --27KoNqt0fmcl1zj/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 22, 2021 at 01:49:02PM +0100, Lukasz Majewski wrote: > This change provides the possibility to build XEA (imx287 based) board > U-Boot as a single binary (without support for CONFIG_SPL_FRAMEWORK). >=20 > The generated u-boot.sb can be used in the factory environment to for > example perform initial setup or HW testing. >=20 > It can be used with 'uuu' utility > (SDPS: boot -f /srv/tftp/xea/u-boot.sb) >=20 > The board_init_ll() is used in arch/arm/cpu/arm926ejs/mxs/start.S, which > is utilized when CONFIG_SPL_FRAMEWORK is disabled. >=20 > However, when it is enabled the arch/arm/cpu/arm926ejs/start.S is used, > which requires the lowlevel_init() function. >=20 > Signed-off-by: Lukasz Majewski > --- >=20 > board/liebherr/xea/spl_xea.c | 8 ++++++++ > board/liebherr/xea/xea.c | 3 ++- > 2 files changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/board/liebherr/xea/spl_xea.c b/board/liebherr/xea/spl_xea.c > index 192f68fca5f..5ee561b8b78 100644 > --- a/board/liebherr/xea/spl_xea.c > +++ b/board/liebherr/xea/spl_xea.c > @@ -290,6 +290,13 @@ u32 mxs_dram_vals[] =3D { > 0x00000000, 0xffffffff > }; > =20 > +/* #ifndef CONFIG_SPL_FRAMEWORK */ > +#if !CONFIG_IS_ENABLED(FRAMEWORK) > +void board_init_ll(const u32 arg, const uint32_t *resptr) > +{ > + mxs_common_spl_init(arg, resptr, iomux_setup, ARRAY_SIZE(iomux_setup)); > +} > +#else > void lowlevel_init(void) > { > struct mxs_pinctrl_regs *pinctrl_regs =3D > @@ -301,3 +308,4 @@ void lowlevel_init(void) > =20 > mxs_common_spl_init(0, NULL, iomux_setup, ARRAY_SIZE(iomux_setup)); > } > +#endif > diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c > index cd11b0ada77..685e2e26a18 100644 > --- a/board/liebherr/xea/xea.c > +++ b/board/liebherr/xea/xea.c > @@ -58,7 +58,8 @@ static void init_clocks(void) > mxs_set_sspclk(MXC_SSPCLK3, 96000, 0); > } > =20 > -#ifdef CONFIG_SPL_BUILD > +/* #if CONFIG_SPL_BUILD && CONFIG_SPL_FRAMEWORK */ > +#if CONFIG_IS_ENABLED(BUILD) && CONFIG_IS_ENABLED(FRAMEWORK) > void board_init_f(ulong arg) > { > init_clocks(); I know checkpatch.pl has a warning, but maybe the text needs to be tweaked there slightly? Using CONFIG_IS_ENABLED here is less readable / clear than CONFIG_SPL_BUILD (which is special) and CONFIG_SPL_FRAMEWORK (there's no CONFIG_FRAMEWORK and this board isn't going to use TPL). --=20 Tom --27KoNqt0fmcl1zj/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHDVnYACgkQFHw5/5Y0 tyxLewwAttSubiYzYV4L1s9M3DoZWJjPut2YKD1XR5vEE14lhxaL+yjjWMA/+FYB jU/4a28HZMPztOLdHE6cojvGKmWR38zAhPag2cxhk8A0LjnpQukAdoDKnuHp4Lnr 5Fu+61MmE6oQy+N3T5TmWN46tsnORBWgCZ2x+F+j4bLOwYl60jzGOfrkvtJVND8N /CETqd237KjVvxhdneuYoR1EalEbEmwpCIualE6rjmvIk+ItwY+cJXHgB4lQg4qY x/eDUPNeiPwgXhDhdc7esSt0GgaAvJRki8dtm79H2l6wv0BIjAoEF5bLe8mLGfqm IpDmpm7fmwro7UiUPU5IElW1i1wvdSzu7urtKqILOI81RzG5ehAvr0MGp4zihftD PzwL8tBMssnxb2glpKDraPNzWDK+vF1wu9LMmZw42pfJcYTyjql+5axXuPFDPJqZ aCgCf55CZ2JizwGq+MhF8pePttyLDcRwfCM+yMKj7EF/C4gI8DLqwuU5RHHKr/Bn znlsKBuR =p0f+ -----END PGP SIGNATURE----- --27KoNqt0fmcl1zj/--