From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5347843025168502181==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 3/4] net/mlx5e: Use auxiliary_device driver data helpers Date: Wed, 22 Dec 2021 17:56:35 +0800 Message-ID: <202112221705.OaQ9zc1H-lkp@intel.com> In-Reply-To: <20211221235852.323752-4-david.e.box@linux.intel.com> List-Id: --===============5347843025168502181== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi "David, I love your patch! Perhaps something to improve: [auto build test WARNING on rdma/for-next] [also build test WARNING on staging/staging-testing linus/master v5.16-rc6 = next-20211221] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-E-Box/driver_core-Au= xiliary-drvdata-helper-cleanup/20211222-080023 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-n= ext config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211222/= 202112221705.OaQ9zc1H-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1b4157338957cb848baaecc20= e2cd01271bb1324 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-E-Box/driver_core-Auxiliary-= drvdata-helper-cleanup/20211222-080023 git checkout 1b4157338957cb848baaecc20e2cd01271bb1324 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash drivers/infiniband/hw/irdma/ dr= ivers/infiniband/hw/mlx5/ drivers/net/ethernet/mellanox/mlx5/core/ drivers/= vdpa/mlx5/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_re= sume': drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5392:35: error: implic= it declaration of function 'auxiliary_get_drvdata' [-Werror=3Dimplicit-func= tion-declaration] 5392 | struct mlx5e_priv *priv =3D auxiliary_get_drvdata(adev); | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5392:35: warning: init= ialization of 'struct mlx5e_priv *' from 'int' makes pointer from integer w= ithout a cast [-Wint-conversion] drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_su= spend': drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5415:35: warning: init= ialization of 'struct mlx5e_priv *' from 'int' makes pointer from integer w= ithout a cast [-Wint-conversion] 5415 | struct mlx5e_priv *priv =3D auxiliary_get_drvdata(adev); | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_pr= obe': drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5459:9: error: implici= t declaration of function 'auxiliary_set_drvdata' [-Werror=3Dimplicit-funct= ion-declaration] 5459 | auxiliary_set_drvdata(adev, priv); | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_re= move': drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5507:35: warning: init= ialization of 'struct mlx5e_priv *' from 'int' makes pointer from integer w= ithout a cast [-Wint-conversion] 5507 | struct mlx5e_priv *priv =3D auxiliary_get_drvdata(adev); | ^~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +5392 drivers/net/ethernet/mellanox/mlx5/core/en_main.c 5388 = 5389 static int mlx5e_resume(struct auxiliary_device *adev) 5390 { 5391 struct mlx5_adev *edev =3D container_of(adev, struct mlx5_adev, ade= v); > 5392 struct mlx5e_priv *priv =3D auxiliary_get_drvdata(adev); 5393 struct net_device *netdev =3D priv->netdev; 5394 struct mlx5_core_dev *mdev =3D edev->mdev; 5395 int err; 5396 = 5397 if (netif_device_present(netdev)) 5398 return 0; 5399 = 5400 err =3D mlx5e_create_mdev_resources(mdev); 5401 if (err) 5402 return err; 5403 = 5404 err =3D mlx5e_attach_netdev(priv); 5405 if (err) { 5406 mlx5e_destroy_mdev_resources(mdev); 5407 return err; 5408 } 5409 = 5410 return 0; 5411 } 5412 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5347843025168502181==--