All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] gpio: regmap: Switch to use fwnode instead of of_node
@ 2021-12-23 12:16 Andy Shevchenko
  2021-12-23 12:32 ` Michael Walle
  2021-12-23 16:14 ` Bartosz Golaszewski
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-12-23 12:16 UTC (permalink / raw)
  To: Bartosz Golaszewski, Michael Walle, Andy Shevchenko, linux-gpio,
	linux-kernel
  Cc: Linus Walleij, Bartosz Golaszewski

GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-regmap.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
index 69c219742083..6383136cbe59 100644
--- a/drivers/gpio/gpio-regmap.c
+++ b/drivers/gpio/gpio-regmap.c
@@ -244,16 +244,12 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
 
 	chip = &gpio->gpio_chip;
 	chip->parent = config->parent;
+	chip->fwnode = config->fwnode;
 	chip->base = -1;
 	chip->ngpio = config->ngpio;
 	chip->names = config->names;
 	chip->label = config->label ?: dev_name(config->parent);
 
-#if defined(CONFIG_OF_GPIO)
-	/* gpiolib will use of_node of the parent if chip->of_node is NULL */
-	chip->of_node = to_of_node(config->fwnode);
-#endif /* CONFIG_OF_GPIO */
-
 	/*
 	 * If our regmap is fast_io we should probably set can_sleep to false.
 	 * Right now, the regmap doesn't save this property, nor is there any
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] gpio: regmap: Switch to use fwnode instead of of_node
  2021-12-23 12:16 [PATCH v1 1/1] gpio: regmap: Switch to use fwnode instead of of_node Andy Shevchenko
@ 2021-12-23 12:32 ` Michael Walle
  2021-12-23 16:14 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2021-12-23 12:32 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, Linus Walleij,
	Bartosz Golaszewski

Am 2021-12-23 13:16, schrieb Andy Shevchenko:
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Michael Walle <michael@walle.cc>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] gpio: regmap: Switch to use fwnode instead of of_node
  2021-12-23 12:16 [PATCH v1 1/1] gpio: regmap: Switch to use fwnode instead of of_node Andy Shevchenko
  2021-12-23 12:32 ` Michael Walle
@ 2021-12-23 16:14 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2021-12-23 16:14 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Bartosz Golaszewski, Michael Walle, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List, Linus Walleij

On Thu, Dec 23, 2021 at 1:16 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpio-regmap.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
> index 69c219742083..6383136cbe59 100644
> --- a/drivers/gpio/gpio-regmap.c
> +++ b/drivers/gpio/gpio-regmap.c
> @@ -244,16 +244,12 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
>
>         chip = &gpio->gpio_chip;
>         chip->parent = config->parent;
> +       chip->fwnode = config->fwnode;
>         chip->base = -1;
>         chip->ngpio = config->ngpio;
>         chip->names = config->names;
>         chip->label = config->label ?: dev_name(config->parent);
>
> -#if defined(CONFIG_OF_GPIO)
> -       /* gpiolib will use of_node of the parent if chip->of_node is NULL */
> -       chip->of_node = to_of_node(config->fwnode);
> -#endif /* CONFIG_OF_GPIO */
> -
>         /*
>          * If our regmap is fast_io we should probably set can_sleep to false.
>          * Right now, the regmap doesn't save this property, nor is there any
> --
> 2.34.1
>

Applied, thanks!

Bart

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-23 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 12:16 [PATCH v1 1/1] gpio: regmap: Switch to use fwnode instead of of_node Andy Shevchenko
2021-12-23 12:32 ` Michael Walle
2021-12-23 16:14 ` Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.