From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B136FC4332F for ; Thu, 23 Dec 2021 12:53:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E877583492; Thu, 23 Dec 2021 13:53:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QK8gvvXS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8198983492; Thu, 23 Dec 2021 13:53:12 +0100 (CET) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 52D3D83112 for ; Thu, 23 Dec 2021 13:53:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id r6so5045612qvr.13 for ; Thu, 23 Dec 2021 04:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f4fTCAKOQCsDM6DpuUcTQ6yGXunITbVQT++UG14PaE8=; b=QK8gvvXSOjbLVaPwVLYDwBvasDeOkcw6YIS33FSc9tiEXX50WmeY+mwWqZuFPJik4p xeA4whvbOL2WaOOVGpBNx+RVD+L/P/cpJV6sbK7yU4Vx8xyoZ2vwbaA/S/3BSLVlC4Cb LxQa2xtYY69pRmIsqCHI8uteTtPifJbCPlNtE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f4fTCAKOQCsDM6DpuUcTQ6yGXunITbVQT++UG14PaE8=; b=kxgi6o6S7KQaUxlPrbQbVWI+ghXTLPspGSt+NE/qu0aM7lNQG8MAI/e6HV3BMhoOM6 IrJIbu2WcBIUhYYEjAzv58oug564FMmwMuli4/GE4hOAD1DU+6oxeiVDb/DsuJd2s9nA dUjBxOkpoDI1kdLQ7FCqIURGAnqXd8zaGtRbIlKFZn6KdA1bKvinJxT1d5qBOB6cRuQU GetDF5rW7c8jisYBZ3rlaiT3JN2vfT1gwqrVNSruKOkpgkl7xJ3PH7b22Lu49KpQ3ZJV kToVY3eNiz8RxYeeieLZtWQs2yYP4xUNvAnLBiqQ7vQxyhwFOLlUNi5eGuYXm3FO1SLY ce+g== X-Gm-Message-State: AOAM5320ktFdiODLZy1kFw1MBGLsZUKXkEkfydGHvL+k3jIvrr0Wy2wy h3zet4MTcRmE1co3LwgZDz/sfsIONRKT6w== X-Google-Smtp-Source: ABdhPJzm99c4SYemtMYYtJMcvW9o7zDVhGEpD+yX3+XdOxwbMAXPR7VYkrLCyyFFvcfZuu9qRqxoew== X-Received: by 2002:a05:6214:23c8:: with SMTP id hr8mr1446975qvb.79.1640263986981; Thu, 23 Dec 2021 04:53:06 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-a949-8b61-367e-1b77.res6.spectrum.com. [2603:6081:7b01:cbda:a949:8b61:367e:1b77]) by smtp.gmail.com with ESMTPSA id w14sm4492425qkp.54.2021.12.23.04.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 04:53:06 -0800 (PST) Date: Thu, 23 Dec 2021 07:53:04 -0500 From: Tom Rini To: Lukasz Majewski Cc: u-boot@lists.denx.de, Stefano Babic Subject: Re: [PATCH v1 1/3] arm: xea: Modify board code to generate single binary u-boot Message-ID: <20211223125304.GQ2773246@bill-the-cat> References: <20211222124904.2475-1-lukma@denx.de> <20211222164649.GO2773246@bill-the-cat> <20211223094213.6fdc4f02@ktm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5joxkA65nhhP20dL" Content-Disposition: inline In-Reply-To: <20211223094213.6fdc4f02@ktm> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --5joxkA65nhhP20dL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 23, 2021 at 09:42:13AM +0100, Lukasz Majewski wrote: > Hi Tom, >=20 > > On Wed, Dec 22, 2021 at 01:49:02PM +0100, Lukasz Majewski wrote: > >=20 > > > This change provides the possibility to build XEA (imx287 based) > > > board U-Boot as a single binary (without support for > > > CONFIG_SPL_FRAMEWORK). > > >=20 > > > The generated u-boot.sb can be used in the factory environment to > > > for example perform initial setup or HW testing. > > >=20 > > > It can be used with 'uuu' utility > > > (SDPS: boot -f /srv/tftp/xea/u-boot.sb) > > >=20 > > > The board_init_ll() is used in arch/arm/cpu/arm926ejs/mxs/start.S, > > > which is utilized when CONFIG_SPL_FRAMEWORK is disabled. > > >=20 > > > However, when it is enabled the arch/arm/cpu/arm926ejs/start.S is > > > used, which requires the lowlevel_init() function. > > >=20 > > > Signed-off-by: Lukasz Majewski > > > --- > > >=20 > > > board/liebherr/xea/spl_xea.c | 8 ++++++++ > > > board/liebherr/xea/xea.c | 3 ++- > > > 2 files changed, 10 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/board/liebherr/xea/spl_xea.c > > > b/board/liebherr/xea/spl_xea.c index 192f68fca5f..5ee561b8b78 100644 > > > --- a/board/liebherr/xea/spl_xea.c > > > +++ b/board/liebherr/xea/spl_xea.c > > > @@ -290,6 +290,13 @@ u32 mxs_dram_vals[] =3D { > > > 0x00000000, 0xffffffff > > > }; > > > =20 > > > +/* #ifndef CONFIG_SPL_FRAMEWORK */ > > > +#if !CONFIG_IS_ENABLED(FRAMEWORK) > > > +void board_init_ll(const u32 arg, const uint32_t *resptr) > > > +{ > > > + mxs_common_spl_init(arg, resptr, iomux_setup, > > > ARRAY_SIZE(iomux_setup)); +} > > > +#else > > > void lowlevel_init(void) > > > { > > > struct mxs_pinctrl_regs *pinctrl_regs =3D > > > @@ -301,3 +308,4 @@ void lowlevel_init(void) > > > =20 > > > mxs_common_spl_init(0, NULL, iomux_setup, > > > ARRAY_SIZE(iomux_setup)); } > > > +#endif > > > diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c > > > index cd11b0ada77..685e2e26a18 100644 > > > --- a/board/liebherr/xea/xea.c > > > +++ b/board/liebherr/xea/xea.c > > > @@ -58,7 +58,8 @@ static void init_clocks(void) > > > mxs_set_sspclk(MXC_SSPCLK3, 96000, 0); > > > } > > > =20 > > > -#ifdef CONFIG_SPL_BUILD > > > +/* #if CONFIG_SPL_BUILD && CONFIG_SPL_FRAMEWORK */ > > > +#if CONFIG_IS_ENABLED(BUILD) && CONFIG_IS_ENABLED(FRAMEWORK) > > > void board_init_f(ulong arg) > > > { > > > init_clocks(); =20 > >=20 > > I know checkpatch.pl has a warning, but maybe the text needs to be > > tweaked there slightly? =20 >=20 > Yes, exactly - this was done to silence the checkpatch.pl error. >=20 > > Using CONFIG_IS_ENABLED here is less > > readable / clear than CONFIG_SPL_BUILD (which is special) and > > CONFIG_SPL_FRAMEWORK (there's no CONFIG_FRAMEWORK and this board > > isn't going to use TPL). > >=20 >=20 > If you prefer I can just add the preprocessor code from the above > comment. It's a warning not an error, please just use #ifdef here instead, thanks. --=20 Tom --5joxkA65nhhP20dL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHEcS0ACgkQFHw5/5Y0 tyyz6QwAjGaEEwXDqWCMc/89OgzFjYqTKNelARHEjQ6XwtiRn+sM8hspPlXwfa3R Ezw0NPQ1B36/A8s09LEb3MHs9pzQ/++WwipaQKmDyy0nyrJtRwGhDlbPUHfG2pLB 7BjXLDvIVGwJuWe7u/Fh9ZU72pBXC4LiKTelXLMZOfvHZqr2M9eIOm1Psq0MflD7 PLu+GxwtH+WPHw+PdxpT71N1YyXDds6awjhyAhZMkbhJ2ai2ZrMSZxKS2VRsznn/ ApJ9ql2hyuAPxgMetJL9/Ap244MT19STS6z32GK42IszV0oRELOc5Z3h91KaHsK+ dnJL5xGmHWpIif/4DsqT9UpfR19d7jC6D0c2VLptfk2NKSll5RWuJk91tdJ4fE4u 4PYXTFl6IGHn7xeCvV4LVo8tOb9BJCxqJabrsO34vZJVRsrHMjBM8v1eSYzBIFA9 jrzOoZw8GuSWjL5BKQvaYGWJGsvtxKu08aY5R2ueIec5t4SX9+XerM2cDdppke7j g9goCHVi =MImn -----END PGP SIGNATURE----- --5joxkA65nhhP20dL--