From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8DE9C433F5 for ; Thu, 23 Dec 2021 17:13:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244356AbhLWRNu (ORCPT ); Thu, 23 Dec 2021 12:13:50 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:53342 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244347AbhLWRNu (ORCPT ); Thu, 23 Dec 2021 12:13:50 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id F15A8210FE; Thu, 23 Dec 2021 17:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1640279628; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TK8w/l2QmkKbweJf4VP5hkqJcVEfLR6+7DArEF8svg0=; b=N3/Mg4U+xanWLS7bAaYDZP3g6btzRSuYvsvFl8fzz3i/KoD0mzhP2WkozLnYEXg7pAYEcL 7aZqzXk5T/hOrNJpK83n2KFLjdJYNcdM6OyxH6/i40b0Rrmcwyo8mJ1Sed6xjKpip4/MmU 30TjoOc1SpPAloZxkLpf6Q8a8FnMLa8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1640279628; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TK8w/l2QmkKbweJf4VP5hkqJcVEfLR6+7DArEF8svg0=; b=fZsVIT/8nYiFKohB3PYI+Tz1zhjd13tVgKSwUm+zfPngwa8hyJelVLscYzOYaxhslRz9Z4 HQOjiTluRe2hvyAQ== Received: from quack2.suse.cz (jack.udp.ovpn1.nue.suse.de [10.163.28.18]) by relay2.suse.de (Postfix) with ESMTP id DC225A3B81; Thu, 23 Dec 2021 17:13:48 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id CA0051E1328; Thu, 23 Dec 2021 18:13:45 +0100 (CET) Date: Thu, 23 Dec 2021 18:13:45 +0100 From: Jan Kara To: "yukuai (C)" Cc: Jan Kara , Michal =?iso-8859-1?Q?Koutn=FD?= , Paolo Valente , linux-block@vger.kernel.org, fvogt@suse.de, cgroups@vger.kernel.org Subject: Re: Use after free with BFQ and cgroups Message-ID: <20211223171345.GE19129@quack2.suse.cz> References: <20211125172809.GC19572@quack2.suse.cz> <20211126144724.GA31093@blackbody.suse.cz> <20211129171115.GC29512@quack2.suse.cz> <20211222152103.GF685@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu 23-12-21 09:02:55, yukuai (C) wrote: > 在 2021/12/22 23:21, Jan Kara 写道: > > On Thu 09-12-21 10:23:33, yukuai (C) wrote: > > > We confirmed this by our reproducer through a simple patch: > > > stop merging bfq_queues if their parents are different. > > > > Can you please share your reproducer? I have prepared some patches which > > I'd like to verify before posting... Thanks! > > Hi, > > Here is the reproducer, usually the problem will come up within an > hour. Thanks! For some reason the reproducer does not trigger the KASAN warning for me (with or without my patches). But anyway, I'll post my fixes and we'll see what do people think, also I'd be grateful if you can test them in your environment. Thanks. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: Use after free with BFQ and cgroups Date: Thu, 23 Dec 2021 18:13:45 +0100 Message-ID: <20211223171345.GE19129@quack2.suse.cz> References: <20211125172809.GC19572@quack2.suse.cz> <20211126144724.GA31093@blackbody.suse.cz> <20211129171115.GC29512@quack2.suse.cz> <20211222152103.GF685@quack2.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1640279628; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TK8w/l2QmkKbweJf4VP5hkqJcVEfLR6+7DArEF8svg0=; b=N3/Mg4U+xanWLS7bAaYDZP3g6btzRSuYvsvFl8fzz3i/KoD0mzhP2WkozLnYEXg7pAYEcL 7aZqzXk5T/hOrNJpK83n2KFLjdJYNcdM6OyxH6/i40b0Rrmcwyo8mJ1Sed6xjKpip4/MmU 30TjoOc1SpPAloZxkLpf6Q8a8FnMLa8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1640279628; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TK8w/l2QmkKbweJf4VP5hkqJcVEfLR6+7DArEF8svg0=; b=fZsVIT/8nYiFKohB3PYI+Tz1zhjd13tVgKSwUm+zfPngwa8hyJelVLscYzOYaxhslRz9Z4 HQOjiTluRe2hvyAQ== Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="utf-8" To: "yukuai (C)" Cc: Jan Kara , Michal =?iso-8859-1?Q?Koutn=FD?= , Paolo Valente , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fvogt-l3A5Bk7waGM@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu 23-12-21 09:02:55, yukuai (C) wrote: > 在 2021/12/22 23:21, Jan Kara 写道: > > On Thu 09-12-21 10:23:33, yukuai (C) wrote: > > > We confirmed this by our reproducer through a simple patch: > > > stop merging bfq_queues if their parents are different. > > > > Can you please share your reproducer? I have prepared some patches which > > I'd like to verify before posting... Thanks! > > Hi, > > Here is the reproducer, usually the problem will come up within an > hour. Thanks! For some reason the reproducer does not trigger the KASAN warning for me (with or without my patches). But anyway, I'll post my fixes and we'll see what do people think, also I'd be grateful if you can test them in your environment. Thanks. Honza -- Jan Kara SUSE Labs, CR