From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B933C433EF for ; Fri, 24 Dec 2021 19:38:07 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D5BB40691; Fri, 24 Dec 2021 20:38:06 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id EFBA94013F for ; Fri, 24 Dec 2021 20:38:04 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id 196so8386480pfw.10 for ; Fri, 24 Dec 2021 11:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r11wLefWNph7dIti8O49m7Vq19jwxd703kPC3SIyV5g=; b=LZ0MTTvigVa4alOwZjRzFFgf7oFrgpc62ZmK8FPdqGb14Gf9yHHPDfrNwkhT4zn4xz s++B1A8pPtGR453O0E5V0KB526XIFFs68Q2PQUCnOvuNKnDt82lfGCC17A+C8fEwWycv cfK1iGwYRPh6q6KV4desgNGij+KJme0eMb/yM5RBNGHb4b54t5j9KVUorvvPxAYt3xO+ ViMff4r6KYWMxt8z2hSZYUnnCJMUSmmbxHSI6ieHos/bwPPPW0fdewyfETOrbKCV99Yr SKMIFZ6B7i+0KGaJ4nlmUEW/jO74gUAXJeI8+Qd9p5gGr8hSpLBDf7XUT6LJsGtCV5R2 dh+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r11wLefWNph7dIti8O49m7Vq19jwxd703kPC3SIyV5g=; b=g8FK0A6R+yE4wtjOwbo+I8vicB0N4Kb9o+8C0lr0M1XhTJO16If/MSBDknH7G+uNDe 7mv1BH6jjfvS7Xj+u3XXnQeV7PRhwhR5d1bXLNDl8LrXWJI9bh1ul35pXV0g62ppbhP4 T6kcjlMhvtVQiKQ6DVcD0sxUqjj/pkvKCvfgLs+8COuSdV/U2Iq6AYxTJtuYgpcu/zBC a+TjmdL6SIUoL3ub0dAXEXPSX65WBlxKMKsZ45bzm+o6GGmlFcO9da/XuAcTs1CNw7Ed ClIGKOXRqNAea0a5Lf0k2Tz5vzVkgOIvK26DwbYaZM/J39TqP/XtpiuuDEZBbTJbv9vA HJcA== X-Gm-Message-State: AOAM530qlFUs2JZ/D8wFLNujGWytfst8khMDbivT1bHbiycGic5JQveL xkh+BI6E73xk4gF6X0yhKQWkIg== X-Google-Smtp-Source: ABdhPJwLuO1ayJccb45zi5lCurRL1YoOdbEkU7h9BDpZhrZHG9qryoJySVvxuseI57TqXb3OhfJatw== X-Received: by 2002:a63:8b42:: with SMTP id j63mr7378665pge.24.1640374683905; Fri, 24 Dec 2021 11:38:03 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 22sm9981794pfv.173.2021.12.24.11.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Dec 2021 11:38:03 -0800 (PST) Date: Fri, 24 Dec 2021 11:38:01 -0800 From: Stephen Hemminger To: Feifei Wang Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella , dev@dpdk.org, nd@arm.com, Honnappa Nagarahalli , Ruifeng Wang Subject: Re: [RFC PATCH v1 2/4] ethdev: add API for direct re-arm mode Message-ID: <20211224113801.7a03cb63@hermes.local> In-Reply-To: <20211224164613.32569-3-feifei.wang2@arm.com> References: <20211224164613.32569-1-feifei.wang2@arm.com> <20211224164613.32569-3-feifei.wang2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 25 Dec 2021 00:46:10 +0800 Feifei Wang wrote: > +rte_eth_direct_rxrearm_map(uint16_t rx_port_id, uint16_t rx_queue_id, > + uint16_t tx_port_id, uint16_t tx_queue_id) > +{ > + struct rte_eth_dev *dev; > + > + dev = &rte_eth_devices[rx_port_id]; > + (*dev->dev_ops->rx_queue_direct_rearm_enable)(dev, rx_queue_id); > + (*dev->dev_ops->rx_queue_direct_rearm_map)(dev, rx_queue_id, > + tx_port_id, tx_queue_id); > + Indirect calls are expensive, maybe better to combine these?