[PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Lukas Bulwahn]

The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
effective.

Remove these dead function prototypes.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 include/linux/mfd/dbx500-prcmu.h | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/include/linux/mfd/dbx500-prcmu.h b/include/linux/mfd/dbx500-prcmu.h
index cbf9d7619493..2a255362b5ac 100644
--- a/include/linux/mfd/dbx500-prcmu.h
+++ b/include/linux/mfd/dbx500-prcmu.h
@@ -556,22 +556,6 @@ static inline void prcmu_clear(unsigned int reg, u32 bits)
 #define PRCMU_QOS_ARM_OPP 3
 #define PRCMU_QOS_DEFAULT_VALUE -1
 
-#ifdef CONFIG_DBX500_PRCMU_QOS_POWER
-
-unsigned long prcmu_qos_get_cpufreq_opp_delay(void);
-void prcmu_qos_set_cpufreq_opp_delay(unsigned long);
-void prcmu_qos_force_opp(int, s32);
-int prcmu_qos_requirement(int pm_qos_class);
-int prcmu_qos_add_requirement(int pm_qos_class, char *name, s32 value);
-int prcmu_qos_update_requirement(int pm_qos_class, char *name, s32 new_value);
-void prcmu_qos_remove_requirement(int pm_qos_class, char *name);
-int prcmu_qos_add_notifier(int prcmu_qos_class,
-			   struct notifier_block *notifier);
-int prcmu_qos_remove_notifier(int prcmu_qos_class,
-			      struct notifier_block *notifier);
-
-#else
-
 static inline unsigned long prcmu_qos_get_cpufreq_opp_delay(void)
 {
 	return 0;
@@ -613,6 +597,4 @@ static inline int prcmu_qos_remove_notifier(int prcmu_qos_class,
 	return 0;
 }
 
-#endif
-
 #endif /* __MACH_PRCMU_H */
-- 
2.17.1

[PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Lukas Bulwahn]

The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
effective.

Remove these dead function prototypes.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 include/linux/mfd/dbx500-prcmu.h | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/include/linux/mfd/dbx500-prcmu.h b/include/linux/mfd/dbx500-prcmu.h
index cbf9d7619493..2a255362b5ac 100644
--- a/include/linux/mfd/dbx500-prcmu.h
+++ b/include/linux/mfd/dbx500-prcmu.h
@@ -556,22 +556,6 @@ static inline void prcmu_clear(unsigned int reg, u32 bits)
 #define PRCMU_QOS_ARM_OPP 3
 #define PRCMU_QOS_DEFAULT_VALUE -1
 
-#ifdef CONFIG_DBX500_PRCMU_QOS_POWER
-
-unsigned long prcmu_qos_get_cpufreq_opp_delay(void);
-void prcmu_qos_set_cpufreq_opp_delay(unsigned long);
-void prcmu_qos_force_opp(int, s32);
-int prcmu_qos_requirement(int pm_qos_class);
-int prcmu_qos_add_requirement(int pm_qos_class, char *name, s32 value);
-int prcmu_qos_update_requirement(int pm_qos_class, char *name, s32 new_value);
-void prcmu_qos_remove_requirement(int pm_qos_class, char *name);
-int prcmu_qos_add_notifier(int prcmu_qos_class,
-			   struct notifier_block *notifier);
-int prcmu_qos_remove_notifier(int prcmu_qos_class,
-			      struct notifier_block *notifier);
-
-#else
-
 static inline unsigned long prcmu_qos_get_cpufreq_opp_delay(void)
 {
 	return 0;
@@ -613,6 +597,4 @@ static inline int prcmu_qos_remove_notifier(int prcmu_qos_class,
 	return 0;
 }
 
-#endif
-
 #endif /* __MACH_PRCMU_H */
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Linus Walleij]

On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
>
> Remove these dead function prototypes.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

BTW: Lukas are you using this platform or just general winter cleaning?

Yours,
Linus Walleij

Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Linus Walleij]

On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
>
> Remove these dead function prototypes.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

BTW: Lukas are you using this platform or just general winter cleaning?

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Lukas Bulwahn]

On Tue, Dec 28, 2021 at 1:48 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> > The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> > repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
> > effective.
> >
> > Remove these dead function prototypes.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> BTW: Lukas are you using this platform or just general winter cleaning?
>

I am not using this platform, but just doing some janitorial work with
the checkkconfigsymbols.py script, which Randy Dunlap has pointed out
to me. This "general winter cleaning" really started as a "summer
break clean-up" and just took longer... I am also writing a blog post
summarizing the results of these whole kernel clean-up activities and
I will share it with you once it is published.

Lukas

> Yours,
> Linus Walleij

Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Lukas Bulwahn]

On Tue, Dec 28, 2021 at 1:48 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> > The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> > repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
> > effective.
> >
> > Remove these dead function prototypes.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> BTW: Lukas are you using this platform or just general winter cleaning?
>

I am not using this platform, but just doing some janitorial work with
the checkkconfigsymbols.py script, which Randy Dunlap has pointed out
to me. This "general winter cleaning" really started as a "summer
break clean-up" and just took longer... I am also writing a blog post
summarizing the results of these whole kernel clean-up activities and
I will share it with you once it is published.

Lukas

> Yours,
> Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Lee Jones]

On Mon, 27 Dec 2021, Lukas Bulwahn wrote:

> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
> 
> Remove these dead function prototypes.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  include/linux/mfd/dbx500-prcmu.h | 18 ------------------
>  1 file changed, 18 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config

[Lee Jones]

On Mon, 27 Dec 2021, Lukas Bulwahn wrote:

> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in  ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
> 
> Remove these dead function prototypes.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  include/linux/mfd/dbx500-prcmu.h | 18 ------------------
>  1 file changed, 18 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel