Hi Mika, About latest patches series adding CL0s in thunderbolt/next.git 1. Attached fix for CL0s enabled check - w/o it, the CL0s enabling fails 2. Maybe it is better not to mention "Intel limitation..." about the first-hop router since I am not sure this is correct. Attached patch w/ my proposal. 3. Don't we prefer to stay with the name: "tb_switch_titan_ridge_pcie_l1_enable" ? so that it is clear that the function is Titan Ridge specific? If so, sending patch for this Thanks, Gil On Wed, Dec 22, 2021 at 04:18:42PM +0200, Mika Westerberg wrote: > Hi Gil, > > On Fri, Dec 17, 2021 at 03:16:37AM +0200, Gil Fine wrote: > > v1 can be found here: > > > > https://lore.kernel.org/linux-usb/20211125143821.16558-1-gil.fine@intel.com/ > > > > Changes from v1: > > > > * Fixed comment from Yehezkel > > * Fixed comments from Mika > > * Fixed commit messages > > * Fixed time-posting procedure to follow the USB4 Connection Manager Guide 1.0 > > (this resolves the time posting issue after resume from suspend-to-disk) > > * Fixed TMU config in bidirectional mode - disable unidirectional > > * Fixed TMU config in bidirectional mode - set HiFi rate for downstream router > > > > Gil Fine (7): > > thunderbolt: Add TMU unidirectional mode > > thunderbolt: Add CL0s support for USB4 > > thunderbolt: Move usb4_switch_wait_for_bit() to switch.c > > thunderbolt: Enable TMU for Titan Ridge device > > thunderbolt: Rename Intel VSC capability > > thunderbolt: Enable CL0s for Titan Ridge device > > thunderbolt: Add kernel param for CLx disabling > > I did some minor tweaks and applied to thunderbolt.git/next, thanks! > Please check that it still works for you. -- Thanks, Gil --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.