From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75210C433EF for ; Mon, 27 Dec 2021 15:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237779AbhL0Pci (ORCPT ); Mon, 27 Dec 2021 10:32:38 -0500 Received: from mga06.intel.com ([134.134.136.31]:31158 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238015AbhL0Pce (ORCPT ); Mon, 27 Dec 2021 10:32:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640619154; x=1672155154; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0ftgT5rz4My36TxPcpmhbqQvJm2D6myU8LmuRkWvQ4k=; b=l9HwYedXxh17oewzcthf6hmiuxufojNoEXZvwBkSz0uywoQdMXnSDe69 uwZH00uVxZoFDXKvKdi8m4HBfdUNVFcCvawSwmVhuaqbKV+FK5gqAuDHZ pcwX7BOwn+4xHKWQttHerkRwi7F/+R8Up0DnvrrFx3uHgnFl72rNqYrv2 3NFBKmpVrCwiMs1NWrwaA0JMbfdeSvzRDfgskWEXbZIgKKac8P9xQN4dT sgk0MjG1lI63I4haYi4GmKqlEglJ4dzuOksQnJgoKH6N10AJex99deZRM dYC91SdJbiF13hXlUdP3mm8jG+K5Y3oCnI60NSNc++SiDTAA2TWg3u0/K Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10209"; a="301979530" X-IronPort-AV: E=Sophos;i="5.88,239,1635231600"; d="scan'208";a="301979530" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2021 07:32:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,239,1635231600"; d="scan'208";a="618475900" Received: from lkp-server01.sh.intel.com (HELO e357b3ef1427) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 27 Dec 2021 07:32:27 -0800 Received: from kbuild by e357b3ef1427 with local (Exim 4.92) (envelope-from ) id 1n1rz8-0006UP-SR; Mon, 27 Dec 2021 15:32:26 +0000 Date: Mon, 27 Dec 2021 23:32:21 +0800 From: kernel test robot To: Jeffle Xu , dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> References: <20211227125444.21187-20-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Jeffle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dhowells-fs/fscache-next] [cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5.16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742 base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-next config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/202112272340.1ho7sEjG-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d8233681da387fe388cfda git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742 git checkout 54c300b4598e3f2836d8233681da387fe388cfda # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash fs/cachefiles/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles_demand_read' [-Wmissing-prototypes] 564 | int cachefiles_demand_read(struct netfs_cache_resources *cres, | ^~~~~~~~~~~~~~~~~~~~~~ In function 'cachefiles_alloc_req', inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8: >> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals destination size [-Wstringop-truncation] 557 | strncpy(req_in->path, object->d_name, sizeof(req_in->path)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/strncpy +557 fs/cachefiles/io.c 541 542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles_object *object, 543 loff_t start_pos, 544 size_t len) 545 { 546 struct cachefiles_req *req; 547 struct cachefiles_req_in *req_in; 548 549 req = kzalloc(sizeof(*req), GFP_KERNEL); 550 if (!req) 551 return NULL; 552 553 req_in = &req->req_in; 554 555 req_in->off = start_pos; 556 req_in->len = len; > 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path)); 558 559 init_completion(&req->done); 560 561 return req; 562 } 563 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 901B2C433FE for ; Mon, 27 Dec 2021 15:33:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JN1sk5sbYz2ypV for ; Tue, 28 Dec 2021 02:33:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jyE+PCcL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=lkp@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jyE+PCcL; dkim-atps=neutral Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JN1sb49Hsz2xtp for ; Tue, 28 Dec 2021 02:33:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640619219; x=1672155219; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0ftgT5rz4My36TxPcpmhbqQvJm2D6myU8LmuRkWvQ4k=; b=jyE+PCcLeKTa1J8eUePn5A9/B9b6c7wLcNgZUrPdnkCsScXtGggrS7gZ a2/FSuxBYUugdjL0g2RFWcqAiPSxvPBopgaxgQJnrPDuH5P+KKy2mRkQJ w56Tyw1Z+ogcHbT4qXv1hZB9HwJY25oVNoIKDSoBWoE0hHk/bBCXaVKpc 7dNcRwwwm3ItclPi2rsHkiCc7UYQ+S69AqvGrHm/vg2QDUJwEXF2eKyJd KlEkQPD568euqJsNfDauIUewHJnWV4AVKRIowkL1vSuY+Pu6Dzhb7+e2A +PhEkbdHBCyXx/0y6FK0dDB1l+OK57LhRq5xiv6AwfOac93CWYOUlbeog A==; X-IronPort-AV: E=McAfee;i="6200,9189,10209"; a="221224510" X-IronPort-AV: E=Sophos;i="5.88,239,1635231600"; d="scan'208";a="221224510" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2021 07:32:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,239,1635231600"; d="scan'208";a="618475900" Received: from lkp-server01.sh.intel.com (HELO e357b3ef1427) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 27 Dec 2021 07:32:27 -0800 Received: from kbuild by e357b3ef1427 with local (Exim 4.92) (envelope-from ) id 1n1rz8-0006UP-SR; Mon, 27 Dec 2021 15:32:26 +0000 Date: Mon, 27 Dec 2021 23:32:21 +0800 From: kernel test robot To: Jeffle Xu , dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> References: <20211227125444.21187-20-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, tao.peng@linux.alibaba.com, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, linux-fsdevel@vger.kernel.org, gerry@linux.alibaba.com Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Hi Jeffle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dhowells-fs/fscache-next] [cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5.16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742 base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-next config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/202112272340.1ho7sEjG-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d8233681da387fe388cfda git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742 git checkout 54c300b4598e3f2836d8233681da387fe388cfda # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash fs/cachefiles/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles_demand_read' [-Wmissing-prototypes] 564 | int cachefiles_demand_read(struct netfs_cache_resources *cres, | ^~~~~~~~~~~~~~~~~~~~~~ In function 'cachefiles_alloc_req', inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8: >> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals destination size [-Wstringop-truncation] 557 | strncpy(req_in->path, object->d_name, sizeof(req_in->path)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/strncpy +557 fs/cachefiles/io.c 541 542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles_object *object, 543 loff_t start_pos, 544 size_t len) 545 { 546 struct cachefiles_req *req; 547 struct cachefiles_req_in *req_in; 548 549 req = kzalloc(sizeof(*req), GFP_KERNEL); 550 if (!req) 551 return NULL; 552 553 req_in = &req->req_in; 554 555 req_in->off = start_pos; 556 req_in->len = len; > 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path)); 558 559 init_completion(&req->done); 560 561 return req; 562 } 563 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2580605190819062054==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read Date: Mon, 27 Dec 2021 23:32:21 +0800 Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com> List-Id: --===============2580605190819062054== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jeffle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dhowells-fs/fscache-next] [cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5= .16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fs= cache-based-demand-read-semantics/20211227-205742 base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.g= it fscache-next config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/20= 2112272340.1ho7sEjG-lkp(a)intel.com/config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d823368= 1da387fe388cfda git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-ba= sed-demand-read-semantics/20211227-205742 git checkout 54c300b4598e3f2836d8233681da387fe388cfda # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dcsky SHELL=3D/bin/bash fs/cachefiles/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles= _demand_read' [-Wmissing-prototypes] 564 | int cachefiles_demand_read(struct netfs_cache_resources *cres, | ^~~~~~~~~~~~~~~~~~~~~~ In function 'cachefiles_alloc_req', inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8: >> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals = destination size [-Wstringop-truncation] 557 | strncpy(req_in->path, object->d_name, sizeof(req_in->pat= h)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ vim +/strncpy +557 fs/cachefiles/io.c 541 = 542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles= _object *object, 543 loff_t start_pos, 544 size_t len) 545 { 546 struct cachefiles_req *req; 547 struct cachefiles_req_in *req_in; 548 = 549 req =3D kzalloc(sizeof(*req), GFP_KERNEL); 550 if (!req) 551 return NULL; 552 = 553 req_in =3D &req->req_in; 554 = 555 req_in->off =3D start_pos; 556 req_in->len =3D len; > 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path)); 558 = 559 init_completion(&req->done); 560 = 561 return req; 562 } 563 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2580605190819062054==--