From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3702FC433EF for ; Tue, 28 Dec 2021 13:11:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5CB278384D; Tue, 28 Dec 2021 14:11:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MgtG1gto"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 129CD8385A; Tue, 28 Dec 2021 14:11:24 +0100 (CET) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92A5082FB4 for ; Tue, 28 Dec 2021 14:11:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id fq10so16345292qvb.10 for ; Tue, 28 Dec 2021 05:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HFIeAOpByBff9Z7cRmKsKZacEwKB0YVxSeGumA8QSfk=; b=MgtG1gtoquuecyBP1Fqis5Xwmm8PZd3zAyQ6fSL9zKtR7NECuuCeH7OKses5xHQXcM pvSiKim2H8dtg5BmzvO73Q2dknfwOUrxj0zl5C+G4T2Gx/2B16BkhEm/qC7st0gLACw9 ZyR/e+CylmxVn5qoAB5oc6ozIQRzIDSlzPDFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HFIeAOpByBff9Z7cRmKsKZacEwKB0YVxSeGumA8QSfk=; b=KAouBmmzszmGaz/lleXYVUpAbJ+ZMzpTmr3DNkBhcLOIqO9BjakD7n+6It1jV9uTCH v3rJVDjGh9LkhyTd84hSL4Cw6SVc/HZlRryYc5khVHEBcuECuZhIHncPD1BPFoMY8IwS 0gAf8i+UVlGiWf/X20UK6UXuBwFfEoc5ZzEw4/VUhQ2s4z1nexfe+jE1hcouL8mG+7bD N9jUiwUBTc7a3nqxqqUAuXkcTUTc0u37cbEUesAOmCf3PZGSVgXOoyoS5GcZZFzJFbAP 82gpOlol2MHO7qgwyLhWUQlrnCNNfcM9m5JU/UEPU90o7sTQxPieRHGdJQKco5XJQ2at M9HA== X-Gm-Message-State: AOAM533jxe1BRbbhJEZKGY4gsd5XNZGxUz40mkcmCiIZbO1puuHSebaC feiYdZ32oQ2zwBs6L1EjfPsnSA== X-Google-Smtp-Source: ABdhPJwcToMMA5aGSaQoChn3OQDNjLrdUDU3t100jkr+Sx8CLSt4VQ0GFPTqOWnmoobwym/muK3KeQ== X-Received: by 2002:a05:6214:c65:: with SMTP id t5mr18971654qvj.111.1640697078505; Tue, 28 Dec 2021 05:11:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-28e1-62ad-aeb7-bfd0.res6.spectrum.com. [2603:6081:7b01:cbda:28e1:62ad:aeb7:bfd0]) by smtp.gmail.com with ESMTPSA id s7sm15864298qta.31.2021.12.28.05.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 05:11:17 -0800 (PST) Date: Tue, 28 Dec 2021 08:11:15 -0500 From: Tom Rini To: Simon Glass Cc: Troy Kisky , Fabio Estevam , U-Boot Mailing List Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Message-ID: <20211228131115.GZ2773246@bill-the-cat> References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FWNnc7UvJRgHBXIN" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --FWNnc7UvJRgHBXIN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: > Hi Troy, >=20 > On Fri, 17 Dec 2021 at 16:02, Troy Kisky = wrote: > > > > This series intends to let board specific files live in the boards > > directory. The last patch moves files for nitrogen6x. > > I have tested it with buildman > > > > ./tools/buildman/buildman boundary -b denx_master > > > > But it is likely the more scripts then just tools/genboardscfg.py would > > need to be updated. > > > > Troy Kisky (5): > > kconfig: allow defconfigs to live in board directory > > dts: allow dts files in board directory > > scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to live > > in board directory > > genboardcfg: allow defconfigs in board directory > > nitrogen6x: move board specific files to nitrogen6x directory > > > > arch/arm/dts/Makefile | 3 -- > > board/boundary/nitrogen6x/MAINTAINERS | 13 ------- > > board/boundary/nitrogen6x/Makefile | 13 +++++++ > > .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 > > .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 > > .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 > > .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 > > .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 > > .../nitrogen6x}/mx6qsabrelite_defconfig | 0 > > .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 > > .../nitrogen6x}/nitrogen6dl_defconfig | 0 > > .../nitrogen6x}/nitrogen6q2g_defconfig | 0 > > .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 > > .../nitrogen6x}/nitrogen6s1g_defconfig | 0 > > .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 > > .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- > > dts/Makefile | 11 +++++- > > scripts/Makefile.autoconf | 9 ++++- > > scripts/Makefile.lib | 1 + > > scripts/kconfig/Makefile | 9 ++++- > > tools/genboardscfg.py | 37 ++++++++++++++++++- > > 21 files changed, 75 insertions(+), 23 deletions(-) > > rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6dl-nitrogen6x= =2Edts (100%) > > rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-nitrogen6x.= dts (100%) > > rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-sabrelite.d= ts (100%) > > rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-nitrogen6= x.dtsi (100%) > > rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-sabrelite= =2Edtsi (100%) > > rename {configs =3D> board/boundary/nitrogen6x}/mx6qsabrelite_defconfi= g (100%) > > rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl2g_defconfi= g (100%) > > rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl_defconfig = (100%) > > rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q2g_defconfig= (100%) > > rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q_defconfig (= 100%) > > rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s1g_defconfig= (100%) > > rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s_defconfig (= 100%) > > rename {include/configs =3D> board/boundary/nitrogen6x}/nitrogen6x.h (= 98%) I'm not about the goal. >=20 > Can you please add a few notes about the motivation for this change? Sorry for the delayed reply here. I'm also not entirely sure this is a good idea. Moving the defconfig files? Maybe. It does make checking all configs a bit more tricky, but indeed the configs directory is unwieldy. Moving the dts files? Those should be a direct cp from the kernel, so that makes things less clear to me. Especially since it will need other common files that will still be elsewhere. --=20 Tom --FWNnc7UvJRgHBXIN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHLDPAACgkQFHw5/5Y0 tyw4dQv/ZX8SPwUiUmVGZ/nugs2jTsf4bckYLy88mA7/+emBO26oyQViH+Or8f4i N+cSx10yyNUlxWZysVXTGJyRZTBx4zTbf5pAgo+eU67M+MVM4Egk+O9oYVo/RtIq uegKF6gowhCkvx1uBFQk35lDF9gPBHdDxCBAw54wKYyzfmlir2bgC04PmRstlS7c LBgG63ziQ79+pPT5MjGIHM0pYD3tgEpTeBExZxCAuRrHl6Cwfoc7seuVOU8tlvHO 1izgdGlwUcAtyar6bOCjRhVys+RiG/Zvu4aokEiK7tSpW7/pKA+UM7/HA7O803Wg kTDEYu1aHQIQVRgGjG64gvJEGDJcfN+fZl5/OnMnoBjB959m4ku7NK+SuMydYCnU QAGFkpx3B5BJHnptzuVA7do2jeJ77f+mloroO13vVqebYI2sGYYDVWjgLiJAKqxi HBn4Lles9Iz6aGDXufzPLkIC1aTY/sGj4pfcWEyHHAPj+5R4ANTFtdmXXYvvu6u7 jauVIc3A =Aqsv -----END PGP SIGNATURE----- --FWNnc7UvJRgHBXIN--