From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6A2C433F5 for ; Tue, 28 Dec 2021 16:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235869AbhL1Q4g (ORCPT ); Tue, 28 Dec 2021 11:56:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231370AbhL1Q4f (ORCPT ); Tue, 28 Dec 2021 11:56:35 -0500 Received: from haggis.mythic-beasts.com (haggis.mythic-beasts.com [IPv6:2a00:1098:0:86:1000:0:2:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01215C061574; Tue, 28 Dec 2021 08:56:34 -0800 (PST) Received: from [81.101.6.87] (port=39590 helo=jic23-huawei) by haggis.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1n2FlV-0004u6-5t; Tue, 28 Dec 2021 16:55:57 +0000 Date: Tue, 28 Dec 2021 17:01:25 +0000 From: Jonathan Cameron To: Niklas Schnelle Cc: Geert Uytterhoeven , Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Lars-Peter Clausen , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich Subject: Re: [RFC 12/32] iio: adc: Kconfig: add HAS_IOPORT dependencies Message-ID: <20211228170031.12dac755@jic23-huawei> In-Reply-To: References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-13-schnelle@linux.ibm.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BlackCat-Spam-Score: 19 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Dec 2021 13:50:20 +0100 Niklas Schnelle wrote: > On Tue, 2021-12-28 at 11:32 +0100, Geert Uytterhoeven wrote: > > Hi Niklas, > > > > On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle wrote: > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > > not being declared. We thus need to add HAS_IOPORT as dependency for > > > those drivers using them. > > > > > > Co-developed-by: Arnd Bergmann > > > Signed-off-by: Arnd Bergmann > > > Signed-off-by: Niklas Schnelle As a side note, whilst it doesn't always happen and I regularly forget to fix it up whilst applying, it's really helpful to make sure the driver name is somewhere in the patch title. e.g. iio: adc: ad7606: add HAS_IOPORT dependencies. > > > > Thanks for your patch! > > > > > --- a/drivers/iio/adc/Kconfig > > > +++ b/drivers/iio/adc/Kconfig > > > @@ -119,7 +119,7 @@ config AD7606 > > > > > > config AD7606_IFACE_PARALLEL > > > tristate "Analog Devices AD7606 ADC driver with parallel interface support" > > > - depends on HAS_IOMEM > > > + depends on HAS_IOPORT > > > > While this driver uses ins[bw](), this seems unrelated to legacy > > I/O space, as the driver maps a MMIO region. Probably different > > accessors should be used instead. > > You're right on first glance it looks like a misuse of the ins[bw]() > accessors. I do wonder how that even works, if PCI_IOBASE is 0 it would > result in readsw()/readsb() with presumably the correct address but no > idea how this interacts witth x86's special I/O instructions. > > > > > Note that this driver has no in-tree users. Same for the SPI variant, > > but at least that one has modern json-schema DT bindings ;-) > > Can't find any mention in the MAINTAINERS file either. It falls under the Analog devices catch all. We don't list them all individually because there are a lot of them and it would just be noise in many case. Added Michael to CC. You already have Lars. ANALOG DEVICES INC IIO DRIVERS M: Lars-Peter Clausen M: Michael Hennerich S: Supported W: http://wiki.analog.com/ W: http://ez.analog.com/community/linux-device-drivers F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523 F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350 F: Documentation/devicetree/bindings/iio/*/adi,* F: Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml F: drivers/iio/*/ad* F: drivers/iio/adc/ltc249* F: drivers/iio/amplifiers/hmc425a.c F: drivers/staging/iio/*/ad* X: drivers/iio/*/adjd* https://wiki.analog.com/resources/tools-software/linux-drivers/iio-adc/ad7606 includes some details. I'll leave it to the Lars or Michael to confirm what is going on here. Jonathan > > > > > > select AD7606 > > > help > > > Say yes here to build parallel interface support for Analog Devices: > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4610C433F5 for ; Tue, 28 Dec 2021 16:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xoy4zUuHK5h3juGbTmszkWUA8sy7e8DyM+5Yz4+CP6U=; b=3oQe3UyLE02P6E HbTCYG9BOOvJNjqohIYgzbYA0/tjeHl2EBVfMa9VI6lJc1h0PI5Th95RA31Tgpt4ejBIPKoaOZVAB G/GkUzuNyG4n+wgHr/o+yJJHE3p4f2pdRgYlglOjCOE9JwyAMpODPSuAgnsgZZTvtwE3Vudfgf0Rg J4ksTBn5tIBuP3/NM69M8DRKdfMEX6G1HPdJ/e8qJgH5tbUMZgTbvRt3XnXn13mCLfM8qdxISUVQ4 tG4ndjC7ZkdCPa/9eWj9T0BlBqDxM1rSi+JhlzxeEWMHNLRGxmzUyBqeMs4bRaqwfjctF7MDQkio0 wPn2aKzD14Lwxco8bdVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2Fm7-001aJk-C3; Tue, 28 Dec 2021 16:56:35 +0000 Received: from haggis.mythic-beasts.com ([2a00:1098:0:86:1000:0:2:1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2Fm4-001aJE-Cp for linux-riscv@lists.infradead.org; Tue, 28 Dec 2021 16:56:34 +0000 Received: from [81.101.6.87] (port=39590 helo=jic23-huawei) by haggis.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1n2FlV-0004u6-5t; Tue, 28 Dec 2021 16:55:57 +0000 Date: Tue, 28 Dec 2021 17:01:25 +0000 From: Jonathan Cameron To: Niklas Schnelle Cc: Geert Uytterhoeven , Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Lars-Peter Clausen , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich Subject: Re: [RFC 12/32] iio: adc: Kconfig: add HAS_IOPORT dependencies Message-ID: <20211228170031.12dac755@jic23-huawei> In-Reply-To: References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-13-schnelle@linux.ibm.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BlackCat-Spam-Score: 19 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_085632_479076_314CC990 X-CRM114-Status: GOOD ( 33.54 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, 28 Dec 2021 13:50:20 +0100 Niklas Schnelle wrote: > On Tue, 2021-12-28 at 11:32 +0100, Geert Uytterhoeven wrote: > > Hi Niklas, > > > > On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle wrote: > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > > not being declared. We thus need to add HAS_IOPORT as dependency for > > > those drivers using them. > > > > > > Co-developed-by: Arnd Bergmann > > > Signed-off-by: Arnd Bergmann > > > Signed-off-by: Niklas Schnelle As a side note, whilst it doesn't always happen and I regularly forget to fix it up whilst applying, it's really helpful to make sure the driver name is somewhere in the patch title. e.g. iio: adc: ad7606: add HAS_IOPORT dependencies. > > > > Thanks for your patch! > > > > > --- a/drivers/iio/adc/Kconfig > > > +++ b/drivers/iio/adc/Kconfig > > > @@ -119,7 +119,7 @@ config AD7606 > > > > > > config AD7606_IFACE_PARALLEL > > > tristate "Analog Devices AD7606 ADC driver with parallel interface support" > > > - depends on HAS_IOMEM > > > + depends on HAS_IOPORT > > > > While this driver uses ins[bw](), this seems unrelated to legacy > > I/O space, as the driver maps a MMIO region. Probably different > > accessors should be used instead. > > You're right on first glance it looks like a misuse of the ins[bw]() > accessors. I do wonder how that even works, if PCI_IOBASE is 0 it would > result in readsw()/readsb() with presumably the correct address but no > idea how this interacts witth x86's special I/O instructions. > > > > > Note that this driver has no in-tree users. Same for the SPI variant, > > but at least that one has modern json-schema DT bindings ;-) > > Can't find any mention in the MAINTAINERS file either. It falls under the Analog devices catch all. We don't list them all individually because there are a lot of them and it would just be noise in many case. Added Michael to CC. You already have Lars. ANALOG DEVICES INC IIO DRIVERS M: Lars-Peter Clausen M: Michael Hennerich S: Supported W: http://wiki.analog.com/ W: http://ez.analog.com/community/linux-device-drivers F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523 F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350 F: Documentation/devicetree/bindings/iio/*/adi,* F: Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml F: drivers/iio/*/ad* F: drivers/iio/adc/ltc249* F: drivers/iio/amplifiers/hmc425a.c F: drivers/staging/iio/*/ad* X: drivers/iio/*/adjd* https://wiki.analog.com/resources/tools-software/linux-drivers/iio-adc/ad7606 includes some details. I'll leave it to the Lars or Michael to confirm what is going on here. Jonathan > > > > > > select AD7606 > > > help > > > Say yes here to build parallel interface support for Analog Devices: > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv