From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46A8C433EF for ; Tue, 28 Dec 2021 18:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237000AbhL1STm convert rfc822-to-8bit (ORCPT ); Tue, 28 Dec 2021 13:19:42 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:57882 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233595AbhL1STm (ORCPT ); Tue, 28 Dec 2021 13:19:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E68A612E8; Tue, 28 Dec 2021 18:19:41 +0000 (UTC) Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPSA id 7F351C36AE9; Tue, 28 Dec 2021 18:19:36 +0000 (UTC) Date: Tue, 28 Dec 2021 18:25:21 +0000 From: Jonathan Cameron To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: William Breathitt Gray , Lars-Peter Clausen , kernel@pengutronix.de, Jonathan Cameron , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Benjamin Gaignard , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 20/23] counter: stm32-timer-cnt: Convert to new counter registration Message-ID: <20211228182521.1774dc79@jic23-huawei> In-Reply-To: <20211227094526.698714-21-u.kleine-koenig@pengutronix.de> References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de> <20211227094526.698714-21-u.kleine-koenig@pengutronix.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Dec 2021 10:45:23 +0100 Uwe Kleine-König wrote: > This fixes device lifetime issues where it was possible to free a live > struct device. > > Fixes: ad29937e206f ("counter: Add STM32 Timer quadrature encoder") > Signed-off-by: Uwe Kleine-König Reviewed-by: Jonathan Cameron Same basic form as all the others so easy to review (hopefully :) Jonathan > --- > drivers/counter/stm32-timer-cnt.c | 30 ++++++++++++++++++------------ > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c > index 4b05b198a8d8..5779ae7c73cf 100644 > --- a/drivers/counter/stm32-timer-cnt.c > +++ b/drivers/counter/stm32-timer-cnt.c > @@ -29,7 +29,6 @@ struct stm32_timer_regs { > }; > > struct stm32_timer_cnt { > - struct counter_device counter; > struct regmap *regmap; > struct clk *clk; > u32 max_arr; > @@ -317,31 +316,38 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev) > struct stm32_timers *ddata = dev_get_drvdata(pdev->dev.parent); > struct device *dev = &pdev->dev; > struct stm32_timer_cnt *priv; > + struct counter_device *counter; > + int ret; > > if (IS_ERR_OR_NULL(ddata)) > return -EINVAL; > > - priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > - if (!priv) > + counter = devm_counter_alloc(dev, sizeof(*priv)); > + if (!counter) > return -ENOMEM; > > + priv = counter_priv(counter); > + > priv->regmap = ddata->regmap; > priv->clk = ddata->clk; > priv->max_arr = ddata->max_arr; > > - priv->counter.name = dev_name(dev); > - priv->counter.parent = dev; > - priv->counter.ops = &stm32_timer_cnt_ops; > - priv->counter.counts = &stm32_counts; > - priv->counter.num_counts = 1; > - priv->counter.signals = stm32_signals; > - priv->counter.num_signals = ARRAY_SIZE(stm32_signals); > - priv->counter.priv = priv; > + counter->name = dev_name(dev); > + counter->parent = dev; > + counter->ops = &stm32_timer_cnt_ops; > + counter->counts = &stm32_counts; > + counter->num_counts = 1; > + counter->signals = stm32_signals; > + counter->num_signals = ARRAY_SIZE(stm32_signals); > > platform_set_drvdata(pdev, priv); > > /* Register Counter device */ > - return devm_counter_register(dev, &priv->counter); > + ret = devm_counter_add(dev, counter); > + if (ret < 0) > + dev_err_probe(dev, ret, "Failed to add counter\n"); > + > + return ret; > } > > static int __maybe_unused stm32_timer_cnt_suspend(struct device *dev) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB674C433EF for ; Tue, 28 Dec 2021 18:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xR/gX5EVNDGCAdfgsbaAcs0iuY3ho1j4N4EMSOVeYIY=; b=yPDnBlOjGUVkaL E4E+ObUQOsw4BD8eJGJ+Fcvs/lzSkVUDFHi07PyeLfdJzI/mKhO7NOzfZ2RKlZ2XjvugPjjiI53Xi YQharzsIyaXduBkeRGPwJ/tfMNUFsPrSzmFwz5zBLR2H5Mz/3uoQMNoyPk5FFk/B44xAwmOxqhpX5 dQj+NKeZ1DoHVxc6YCJcf0o7B9qC/1i6Xi0s7HG/x+c0cDcig4/XTvkHay919fqQQtfTHsu6P34Dm ErL/Ya9f9eJjfqeBVqsahU8FeAMBjP7jKDNQ2jUESg88xVzjaGwy4nCAHozKqqSQ4NdnA7AbaNU5O IloyBpOZCho2+BiSR9YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2H4d-001iMa-Sf; Tue, 28 Dec 2021 18:19:48 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2H4Z-001iLr-UO for linux-arm-kernel@lists.infradead.org; Tue, 28 Dec 2021 18:19:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 58829B816DD; Tue, 28 Dec 2021 18:19:42 +0000 (UTC) Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPSA id 7F351C36AE9; Tue, 28 Dec 2021 18:19:36 +0000 (UTC) Date: Tue, 28 Dec 2021 18:25:21 +0000 From: Jonathan Cameron To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: William Breathitt Gray , Lars-Peter Clausen , kernel@pengutronix.de, Jonathan Cameron , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Benjamin Gaignard , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 20/23] counter: stm32-timer-cnt: Convert to new counter registration Message-ID: <20211228182521.1774dc79@jic23-huawei> In-Reply-To: <20211227094526.698714-21-u.kleine-koenig@pengutronix.de> References: <20211227094526.698714-1-u.kleine-koenig@pengutronix.de> <20211227094526.698714-21-u.kleine-koenig@pengutronix.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_101944_283280_231B11E9 X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNyBEZWMgMjAyMSAxMDo0NToyMyArMDEwMApVd2UgS2xlaW5lLUvDtm5pZyAgICAg ICAgIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgoKPiBUaGlzIGZpeGVz IGRldmljZSBsaWZldGltZSBpc3N1ZXMgd2hlcmUgaXQgd2FzIHBvc3NpYmxlIHRvIGZyZWUgYSBs aXZlCj4gc3RydWN0IGRldmljZS4KPiAKPiBGaXhlczogYWQyOTkzN2UyMDZmICgiY291bnRlcjog QWRkIFNUTTMyIFRpbWVyIHF1YWRyYXR1cmUgZW5jb2RlciIpCj4gU2lnbmVkLW9mZi1ieTogVXdl IEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KUmV2aWV3ZWQt Ynk6IEpvbmF0aGFuIENhbWVyb24gPEpvbmF0aGFuLkNhbWVyb25AaHVhd2VpLmNvbT4KClNhbWUg YmFzaWMgZm9ybSBhcyBhbGwgdGhlIG90aGVycyBzbyBlYXN5IHRvIHJldmlldyAoaG9wZWZ1bGx5 IDopCgpKb25hdGhhbgoKPiAtLS0KPiAgZHJpdmVycy9jb3VudGVyL3N0bTMyLXRpbWVyLWNudC5j IHwgMzAgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAx OCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9jb3VudGVyL3N0bTMyLXRpbWVyLWNudC5jIGIvZHJpdmVycy9jb3VudGVyL3N0bTMyLXRpbWVy LWNudC5jCj4gaW5kZXggNGIwNWIxOThhOGQ4Li41Nzc5YWU3YzczY2YgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9jb3VudGVyL3N0bTMyLXRpbWVyLWNudC5jCj4gKysrIGIvZHJpdmVycy9jb3VudGVy L3N0bTMyLXRpbWVyLWNudC5jCj4gQEAgLTI5LDcgKzI5LDYgQEAgc3RydWN0IHN0bTMyX3RpbWVy X3JlZ3Mgewo+ICB9Owo+ICAKPiAgc3RydWN0IHN0bTMyX3RpbWVyX2NudCB7Cj4gLQlzdHJ1Y3Qg Y291bnRlcl9kZXZpY2UgY291bnRlcjsKPiAgCXN0cnVjdCByZWdtYXAgKnJlZ21hcDsKPiAgCXN0 cnVjdCBjbGsgKmNsazsKPiAgCXUzMiBtYXhfYXJyOwo+IEBAIC0zMTcsMzEgKzMxNiwzOCBAQCBz dGF0aWMgaW50IHN0bTMyX3RpbWVyX2NudF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpw ZGV2KQo+ICAJc3RydWN0IHN0bTMyX3RpbWVycyAqZGRhdGEgPSBkZXZfZ2V0X2RydmRhdGEocGRl di0+ZGV2LnBhcmVudCk7Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+ICAJ c3RydWN0IHN0bTMyX3RpbWVyX2NudCAqcHJpdjsKPiArCXN0cnVjdCBjb3VudGVyX2RldmljZSAq Y291bnRlcjsKPiArCWludCByZXQ7Cj4gIAo+ICAJaWYgKElTX0VSUl9PUl9OVUxMKGRkYXRhKSkK PiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gLQlwcml2ID0gZGV2bV9remFsbG9jKGRldiwgc2l6 ZW9mKCpwcml2KSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAoIXByaXYpCj4gKwljb3VudGVyID0gZGV2 bV9jb3VudGVyX2FsbG9jKGRldiwgc2l6ZW9mKCpwcml2KSk7Cj4gKwlpZiAoIWNvdW50ZXIpCj4g IAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICsJcHJpdiA9IGNvdW50ZXJfcHJpdihjb3VudGVyKTsK PiArCj4gIAlwcml2LT5yZWdtYXAgPSBkZGF0YS0+cmVnbWFwOwo+ICAJcHJpdi0+Y2xrID0gZGRh dGEtPmNsazsKPiAgCXByaXYtPm1heF9hcnIgPSBkZGF0YS0+bWF4X2FycjsKPiAgCj4gLQlwcml2 LT5jb3VudGVyLm5hbWUgPSBkZXZfbmFtZShkZXYpOwo+IC0JcHJpdi0+Y291bnRlci5wYXJlbnQg PSBkZXY7Cj4gLQlwcml2LT5jb3VudGVyLm9wcyA9ICZzdG0zMl90aW1lcl9jbnRfb3BzOwo+IC0J cHJpdi0+Y291bnRlci5jb3VudHMgPSAmc3RtMzJfY291bnRzOwo+IC0JcHJpdi0+Y291bnRlci5u dW1fY291bnRzID0gMTsKPiAtCXByaXYtPmNvdW50ZXIuc2lnbmFscyA9IHN0bTMyX3NpZ25hbHM7 Cj4gLQlwcml2LT5jb3VudGVyLm51bV9zaWduYWxzID0gQVJSQVlfU0laRShzdG0zMl9zaWduYWxz KTsKPiAtCXByaXYtPmNvdW50ZXIucHJpdiA9IHByaXY7Cj4gKwljb3VudGVyLT5uYW1lID0gZGV2 X25hbWUoZGV2KTsKPiArCWNvdW50ZXItPnBhcmVudCA9IGRldjsKPiArCWNvdW50ZXItPm9wcyA9 ICZzdG0zMl90aW1lcl9jbnRfb3BzOwo+ICsJY291bnRlci0+Y291bnRzID0gJnN0bTMyX2NvdW50 czsKPiArCWNvdW50ZXItPm51bV9jb3VudHMgPSAxOwo+ICsJY291bnRlci0+c2lnbmFscyA9IHN0 bTMyX3NpZ25hbHM7Cj4gKwljb3VudGVyLT5udW1fc2lnbmFscyA9IEFSUkFZX1NJWkUoc3RtMzJf c2lnbmFscyk7Cj4gIAo+ICAJcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgcHJpdik7Cj4gIAo+ ICAJLyogUmVnaXN0ZXIgQ291bnRlciBkZXZpY2UgKi8KPiAtCXJldHVybiBkZXZtX2NvdW50ZXJf cmVnaXN0ZXIoZGV2LCAmcHJpdi0+Y291bnRlcik7Cj4gKwlyZXQgPSBkZXZtX2NvdW50ZXJfYWRk KGRldiwgY291bnRlcik7Cj4gKwlpZiAocmV0IDwgMCkKPiArCQlkZXZfZXJyX3Byb2JlKGRldiwg cmV0LCAiRmFpbGVkIHRvIGFkZCBjb3VudGVyXG4iKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICB9 Cj4gIAo+ICBzdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIHN0bTMyX3RpbWVyX2NudF9zdXNwZW5k KHN0cnVjdCBkZXZpY2UgKmRldikKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==