All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@marvell.com>
To: <andrew@lunn.ch>
Cc: <aelior@marvell.com>, <netdev@vger.kernel.org>,
	<palok@marvell.com>, <vbhavaraju@marvell.com>
Subject: Re: [PATCH net-next v2 1/1] qed: add prints if request_firmware() failed
Date: Wed, 29 Dec 2021 03:02:32 -0800	[thread overview]
Message-ID: <20211229110232.336845-1-vbhavaraju@marvell.com> (raw)
In-Reply-To: <YcrmpvMAD5zKHqTE@lunn.ch>

> Hi Venkata
> 
> When you decide to do something different to what has been requested,
> it is a good idea to say why. There might be a very good reason for
> this, but unless you explain it, i have no idea what it is.
> 
>    Andrew

Hello Andrew,

I moved the FW_REPO macro to qed_if.h under include/linux since I didn't
want to bloat something like include/linux/firmware.h. It's really used
(exact URL in a print after request_firmware() fails) at two other places.

If you think it's more useful in include/linux/firmware.h so that other
drivers can make use of it in future, I can move it there.

-Venkata

  reply	other threads:[~2021-12-29 18:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27 17:56 [PATCH net-next v2 1/1] qed: add prints if request_firmware() failed Venkata Sudheer Kumar Bhavaraju
2021-12-28 10:27 ` Andrew Lunn
2021-12-29 11:02   ` Venkata Sudheer Kumar Bhavaraju [this message]
2021-12-29 19:13     ` Jakub Kicinski
2021-12-30 16:41     ` Andrew Lunn
2022-01-06 17:58       ` Venkata Sudheer Kumar Bhavaraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211229110232.336845-1-vbhavaraju@marvell.com \
    --to=vbhavaraju@marvell.com \
    --cc=aelior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=netdev@vger.kernel.org \
    --cc=palok@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.