From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Tom Rini <trini@konsulko.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Bin Meng <bmeng.cn@gmail.com>,
Christian Melki <christian.melki@t2data.com>,
Simon Glass <sjg@chromium.org>, Alexander Graf <agraf@csgraf.de>
Subject: [PATCH v8 20/25] x86: efi: Don't set up global_data again with EFI
Date: Wed, 29 Dec 2021 11:57:54 -0700 [thread overview]
Message-ID: <20211229115722.v8.20.I8106c6bf199fd2c7ec7ba51f3cd19b917f195e73@changeid> (raw)
In-Reply-To: <20211229185759.1432518-1-sjg@chromium.org>
Since EFI does not relocate and uses the same global_data pointer
throughout the board-init process, drop this unnecessary setup, to avoid
a hang.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v5)
Changes in v5:
- Add new patch to avoid setting up global_data again with EFI
common/board_r.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 31a59c585a8..8b5948100b1 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -817,9 +817,8 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
* TODO(sjg@chromium.org): Consider doing this for all archs, or
* dropping the new_gd parameter.
*/
-#if CONFIG_IS_ENABLED(X86_64)
- arch_setup_gd(new_gd);
-#endif
+ if (CONFIG_IS_ENABLED(X86_64) && !IS_ENABLED(CONFIG_EFI_APP))
+ arch_setup_gd(new_gd);
#ifdef CONFIG_NEEDS_MANUAL_RELOC
int i;
--
2.34.1.448.ga2b2bfdf31-goog
next prev parent reply other threads:[~2021-12-29 19:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 18:57 [PATCH v8 00/25] efi: Improvements to U-Boot running on top of UEFI Simon Glass
2021-12-29 18:57 ` [PATCH v8 01/25] efi: Make unicode printf available to the app Simon Glass
2021-12-30 12:48 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 02/25] efi: Locate all block devices in " Simon Glass
2021-12-30 12:53 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 03/25] efi: serial: Support arrow keys Simon Glass
2021-12-29 18:57 ` [PATCH v8 04/25] x86: Allow booting a kernel from the EFI app Simon Glass
2021-12-29 18:57 ` [PATCH v8 05/25] x86: Don't process the kernel command line unless enabled Simon Glass
2021-12-30 13:11 ` Heinrich Schuchardt
2021-12-30 13:33 ` Simon Glass
2021-12-29 18:57 ` [PATCH v8 06/25] x86: efi: Add room for the binman definition in the dtb Simon Glass
2021-12-30 13:29 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 07/25] efi: Drop device_path from struct efi_priv Simon Glass
2021-12-30 13:33 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 08/25] efi: Add comments to " Simon Glass
2021-12-30 13:40 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 09/25] efi: Fix ll_boot_init() operation with the app Simon Glass
2021-12-31 4:58 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 10/25] efi: Add a few comments to the stub Simon Glass
2021-12-31 5:00 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 11/25] efi: Share struct efi_priv between the app and stub code Simon Glass
2021-12-31 5:11 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 12/25] efi: Move exit_boot_services into a function Simon Glass
2021-12-31 5:41 ` Heinrich Schuchardt
2022-01-04 10:52 ` Simon Glass
2022-01-05 8:01 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 13/25] efi: Check for failure when initing the app Simon Glass
2021-12-31 5:49 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 14/25] efi: Mention that efi_info_get() is only used in the stub Simon Glass
2021-12-31 5:57 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 15/25] efi: Show when allocated pages are used Simon Glass
2021-12-31 6:01 ` Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 16/25] efi: Allow easy selection of serial-only operation Simon Glass
2021-12-31 6:18 ` Heinrich Schuchardt
2022-01-04 10:52 ` Simon Glass
2021-12-29 18:57 ` [PATCH v8 17/25] x86: efi: Update efi_get_next_mem_desc() to avoid needing a map Simon Glass
2021-12-29 18:57 ` [PATCH v8 18/25] efi: Support the efi command in the app Simon Glass
2021-12-29 18:57 ` [PATCH v8 19/25] x86: efi: Show the system-table revision Simon Glass
2021-12-31 6:33 ` Heinrich Schuchardt
2022-01-04 10:52 ` Simon Glass
2021-12-29 18:57 ` Simon Glass [this message]
2021-12-31 6:36 ` [PATCH v8 20/25] x86: efi: Don't set up global_data again with EFI Heinrich Schuchardt
2021-12-29 18:57 ` [PATCH v8 21/25] x86: efi: Tweak the code used for the 64-bit EFI app Simon Glass
2021-12-29 18:57 ` [PATCH v8 22/25] x86: efi: Round out the link script for 64-bit EFI Simon Glass
2021-12-29 18:57 ` [PATCH v8 23/25] x86: efi: Don't use the 64-bit link script for the EFI app Simon Glass
2021-12-29 18:57 ` [PATCH v8 24/25] x86: efi: Set the correct link flags for the 64-bit " Simon Glass
2021-12-29 18:57 ` [PATCH v8 25/25] efi: Build the 64-bit app properly Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211229115722.v8.20.I8106c6bf199fd2c7ec7ba51f3cd19b917f195e73@changeid \
--to=sjg@chromium.org \
--cc=agraf@csgraf.de \
--cc=bmeng.cn@gmail.com \
--cc=christian.melki@t2data.com \
--cc=ilias.apalodimas@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.